8761 Commits (d978c41e1ec4fcf2c4d096f09af035f9e8a7ad81)

Author	SHA1	Message	Date
Wladimir J. van der Laan	d978c41e1e	Merge #9736: Pre-0.14.0 hardcoded seeds update ... a60677e Pre-0.14.0 hardcoded seeds update (Wladimir J. van der Laan) bfa9393 contrib/seeds: Update PATTERN_AGENT (Wladimir J. van der Laan) 4dfac2c Update seeds tooling to Python 3 (Wladimir J. van der Laan)	8 years ago
Matt Corallo	db2dc7a58c	Move CNode::addrLocal access behind locked accessors	8 years ago
Matt Corallo	036073bf87	Move CNode::addrName accesses behind locked accessors	8 years ago
Matt Corallo	d8f2b8a8c0	Make nTimeBestReceived atomic	8 years ago
Matt Corallo	22b4966a29	Move [clean|str]SubVer writes/copyStats into a lock	8 years ago
Matt Corallo	0f31872615	Make nServices atomic	8 years ago
Matt Corallo	96f42d8a12	Make nStartingHeight atomic	8 years ago
Matt Corallo	512731bed0	Access fRelayTxes with cs_filter lock in copyStats	8 years ago
Matt Corallo	ae683c1b19	Avoid copying CNodeStats to make helgrind OK with buggy std::string	8 years ago
Matt Corallo	644f1234e2	Make nTimeConnected const in CNode	8 years ago
Cory Fields	321d0fc6b6	net: fix a few races. Credit @TheBlueMatt ... These are (afaik) all long-standing races or concurrent accesses. Going forward, we can clean these up so that they're not all individual atomic accesses. - Reintroduce cs_vRecv to guard receive-specific vars - Lock vRecv/vSend for CNodeStats - Make some vars atomic. - Only set the connection time in CNode's constructor so that it doesn't change	8 years ago
Wladimir J. van der Laan	2447c1024e	Merge #9698: net: fix socket close race ... 9a0b784 net: add a lock around hSocket (Cory Fields) 45e2e08 net: rearrange so that socket accesses can be grouped together (Cory Fields)	8 years ago
Wladimir J. van der Laan	a60677e394	Pre-0.14.0 hardcoded seeds update	8 years ago
Jonas Schnelli	ca9955e706	Remove bitseed.xf2.org form the dns seed list	8 years ago
Wladimir J. van der Laan	36f9d3ae6d	Merge #9718: Qt/Intro: Various fixes ... a9baa6d Bugfix: Qt/Intro: Pruned nodes never require *more* space (Luke Dashjr) 93ffba7 Bugfix: Qt/Intro: Chain state needs to be stored even with the full blockchain (Luke Dashjr) c8cee26 Qt/Intro: Update block chain size (Luke Dashjr)	8 years ago
Luke Dashjr	a9baa6d742	Bugfix: Qt/Intro: Pruned nodes never require *more* space	8 years ago
Luke Dashjr	93ffba7163	Bugfix: Qt/Intro: Chain state needs to be stored even with the full blockchain	8 years ago
Luke Dashjr	c8cee26100	Qt/Intro: Update block chain size	8 years ago
Wladimir J. van der Laan	dd163f5788	Merge #9674: Always enforce strict lock ordering (try or not) ... 618ee92 Further-enforce lockordering by enforcing directly after TRY_LOCKs (Matt Corallo) 2a962d4 Fixup style a bit by moving { to the same line as if statements (Matt Corallo) 8465631 Always enforce lock strict lock ordering (try or not) (Matt Corallo) fd13eca Lock cs_vSend and cs_inventory in a consistent order even in TRY (Matt Corallo)	8 years ago
Matt Corallo	618ee9249b	Further-enforce lockordering by enforcing directly after TRY_LOCKs	8 years ago
Wladimir J. van der Laan	29c53289a9	bench: Fix initialization order in registration ... The initialization order of global data structures in different implementation units is undefined. Making use of this is essentially gambling on what the linker does, the so-called [Static initialization order fiasco](https://isocpp.org/wiki/faq/ctors#static-init-order). In this case it apparently worked on Linux but failed on OpenBSD and FreeBSD. To create it on first use, make the registration structure local to a function. Fixes #8910.	8 years ago
Wladimir J. van der Laan	b709fe7ffc	Merge #9532: Remove unused variables ... 90fd29b Remove unused int64_t nSinceLastSeen (practicalswift) ac4a095 Remove unused Python variables (practicalswift)	8 years ago
Wladimir J. van der Laan	729de15b63	Merge #9604: [Trivial] add comment about setting peer as HB peer. ... dd5b011 [Trivial] add comment about setting peer as HB peer. (John Newbery)	8 years ago
Cory Fields	9a0b784dea	net: add a lock around hSocket	8 years ago
Cory Fields	45e2e08561	net: rearrange so that socket accesses can be grouped together	8 years ago
Wladimir J. van der Laan	02464da5e4	Merge #9227: Make nWalletDBUpdated atomic to avoid a potential race. ... d63ff62 Make nWalletDBUpdated atomic to avoid a potential race. (Patrick Strateman)	8 years ago
Wladimir J. van der Laan	870cd2b58a	Merge #9378: [trivial] Add documentation for CWalletTx::fFromMe member. ... 39c77b0 Add documentation for CWalletTx::fFromMe member. (Russell Yanofsky)	8 years ago
Wladimir J. van der Laan	40f7e27d25	Merge #9650: Better handle invalid parameters to signrawtransaction ... 6dbfe08 [qa] test signrawtransaction merge with missing inputs (Matt Corallo) ec4f7e4 [qa] Add second input to signrawtransaction test case (Matt Corallo) 691710a [qa] Test that decoderawtransaction throws with extra data appended (Matt Corallo) 922bea9 Better handle invalid parameters to signrawtransaction (Matt Corallo) 7ea0ad5 Fail in DecodeHexTx if there is extra data at the end (Matt Corallo)	8 years ago
Wladimir J. van der Laan	09e0c28f85	Merge #9659: Net: Turn some methods and params/variables const ... 0729102 Net: pass interruptMsgProc as const where possible (Jorge Timón) fc7f2ff Net: Make CNetMsgMaker more const (Jorge Timón) d45955f Net: CConnman: Make some methods const (Jorge Timón)	8 years ago
Wladimir J. van der Laan	986ba005ed	Merge #9651: Fix typos ... 5f62e3e Fix typos (practicalswift)	8 years ago
Wladimir J. van der Laan	8d6447ecf7	Merge #9673: Set correct metadata on bumpfee wallet transactions ... 4ec057d [wallet] Set correct metadata on bumpfee wallet transactions (Russell Yanofsky)	8 years ago
Wladimir J. van der Laan	fc67cd22f8	Merge #9691: Init ECC context for test_bitcoin_fuzzy. ... ac719c9 Init ECC context for test_bitcoin_fuzzy. (Gregory Maxwell)	8 years ago
Pieter Wuille	923dc447ea	Merge #9578: Add missing mempool lock for CalculateMemPoolAncestors ... 003cd60 Add missing mempool lock for CalculateMemPoolAncestors (Matt Corallo)	8 years ago
Gregory Maxwell	ac719c936d	Init ECC context for test_bitcoin_fuzzy. ... This avoids calling things like pubkey_parse with a null context argument.	8 years ago
Matt Corallo	2a962d4540	Fixup style a bit by moving { to the same line as if statements	8 years ago
Wladimir J. van der Laan	7821db30e1	Merge #9671: Fix super-unlikely race introduced in 236618061a ... 885cfdd Fix super-unlikely race introduced in 236618061a (Matt Corallo)	8 years ago
Wladimir J. van der Laan	496691741d	Merge #9609: net: fix remaining net assertions ... 08bb6f4 net: log an error rather than asserting if send version is misused (Cory Fields) 7a8c251 net: Disallow sending messages until the version handshake is complete (Cory Fields) 12752af net: don't run callbacks on nodes that haven't completed the version handshake (Cory Fields) 2046617 net: deserialize the entire version message locally (Cory Fields) 80ff034 Dont deserialize nVersion into CNode, should fix #9212 (Matt Corallo)	8 years ago
Matt Corallo	7b2d96b634	Access WorkQueue::running only within the cs lock. ... This removes a "race" between Interrupt() and Run(), though it should not effect any of our supported platforms.	8 years ago
Matt Corallo	8465631845	Always enforce lock strict lock ordering (try or not)	8 years ago
Matt Corallo	fd13eca147	Lock cs_vSend and cs_inventory in a consistent order even in TRY	8 years ago
Russell Yanofsky	4ec057dfa7	[wallet] Set correct metadata on bumpfee wallet transactions ... Preserve comment, order form, and account strings from the original wallet transaction. Also set fTimeReceivedIsTxTime and fFromMe fields for consistency with CWallet::CreateTransaction. The latter two fields don't influence current wallet behavior, but do record that the transaction originated in the wallet instead of coming from the network or sendrawtransaction.	8 years ago
Matt Corallo	922bea90c2	Better handle invalid parameters to signrawtransaction ... This silently skips trying to merge signatures from inputs which do not exist from transactions provided to signrawtransaction, instead of hitting an assert.	8 years ago
Matt Corallo	7ea0ad539f	Fail in DecodeHexTx if there is extra data at the end	8 years ago
Cory Fields	08bb6f4ed4	net: log an error rather than asserting if send version is misused ... Also cleaned up the comments and moved from the header to the .cpp so that logging headers aren't needed from net.h	8 years ago
Cory Fields	7a8c251901	net: Disallow sending messages until the version handshake is complete ... This is a change in behavior, though it's much more sane now than before.	8 years ago
Cory Fields	12752af0cc	net: don't run callbacks on nodes that haven't completed the version handshake ... Since ForEach* are can be used to send messages to all nodes, the caller may end up sending a message before the version handshake is complete. To limit this, filter out these nodes. While we're at it, may as well filter out disconnected nodes as well. Delete unused methods rather than updating them.	8 years ago
Cory Fields	2046617b5e	net: deserialize the entire version message locally ... This avoids having some vars set if the version negotiation fails. Also copy it all into CNode at the same site. nVersion and fSuccessfullyConnected are set last, as they are the gates for the other vars. Make them atomic for that reason.	8 years ago
Matt Corallo	80ff0344ae	Dont deserialize nVersion into CNode, should fix #9212	8 years ago
Matt Corallo	885cfdd217	Fix super-unlikely race introduced in 236618061a ... Once the CNode has been added to vNodes, it is possible that it is disconnected+deleted in the socket handler thread. However, after that we now call InitializeNode, which accesses the pnode. helgrind managed to tickle this case (somehow), but I suspect it requires in immensely braindead scheduler.	8 years ago
Wladimir J. van der Laan	4e19efba03	Merge #9556: Remove redundant semicolons ... 8fc6989 Remove redundant semicolons (practicalswift)	8 years ago