Merge #19840: Avoid callback when -blocknotify is empty

413e0d1d31 Avoid callback when -blocknotify is empty (João Barbosa)

Pull request description:

ACKs for top commit:
  MarcoFalke:
    ACK 413e0d1d31
  practicalswift:
    ACK 413e0d1d31 -- patch looks correct
  laanwj:
    Code review ACK 413e0d1d31

Tree-SHA512: 915e796666b4e74dbb029ba5436e5573a4b881aad9e118f737bcff4024528b7ff3b00dd035138f63d30963cfd66195f6e53a2dbe429ee28cb6f0b9cc47218ecf

src/init.cpp

@@ -1833,20 +1833,15 @@ bool AppInitMain(const util::Ref& context, NodeContext& node, interfaces::BlockA
     }
 
 #if HAVE_SYSTEM
-    if (args.IsArgSet("-blocknotify")) {
+    const std::string block_notify = args.GetArg("-blocknotify", "");
-        const std::string block_notify = args.GetArg("-blocknotify", "");
+    if (!block_notify.empty()) {
-        const auto BlockNotifyCallback = [block_notify](SynchronizationState sync_state, const CBlockIndex* pBlockIndex) {
+        uiInterface.NotifyBlockTip_connect([block_notify](SynchronizationState sync_state, const CBlockIndex* pBlockIndex) {
-            if (sync_state != SynchronizationState::POST_INIT || !pBlockIndex)
+            if (sync_state != SynchronizationState::POST_INIT || !pBlockIndex) return;
-                return;
+            std::string command = block_notify;
-
+            boost::replace_all(command, "%s", pBlockIndex->GetBlockHash().GetHex());
-            std::string strCmd = block_notify;
+            std::thread t(runCommand, command);
-            if (!strCmd.empty()) {
+            t.detach(); // thread runs free
-                boost::replace_all(strCmd, "%s", pBlockIndex->GetBlockHash().GetHex());
+        });
-                std::thread t(runCommand, strCmd);
-                t.detach(); // thread runs free
-            }
-        };
-        uiInterface.NotifyBlockTip_connect(BlockNotifyCallback);
     }
 #endif