Perform member initialization in initialization lists where possible

src/primitives/block.h

@@ -129,10 +129,7 @@ struct CBlockLocator
 
     CBlockLocator() {}
 
-    CBlockLocator(const std::vector<uint256>& vHaveIn)
+    CBlockLocator(const std::vector<uint256>& vHaveIn) : vHave(vHaveIn) {}
-    {
-        vHave = vHaveIn;
-    }
 
     ADD_SERIALIZE_METHODS;
 

src/protocol.cpp

@@ -151,11 +151,7 @@ CInv::CInv()
     hash.SetNull();
 }
 
-CInv::CInv(int typeIn, const uint256& hashIn)
+CInv::CInv(int typeIn, const uint256& hashIn) : type(typeIn), hash(hashIn) {}
-{
-    type = typeIn;
-    hash = hashIn;
-}
 
 bool operator<(const CInv& a, const CInv& b)
 {

src/rpc/server.h

@@ -50,7 +50,7 @@ public:
     std::string URI;
     std::string authUser;
 
-    JSONRPCRequest() { id = NullUniValue; params = NullUniValue; fHelp = false; }
+    JSONRPCRequest() : id(NullUniValue), params(NullUniValue), fHelp(false) {}
     void parse(const UniValue& valRequest);
 };
 

src/wallet/wallet.h

@@ -136,10 +136,7 @@ public:
     std::string name;
     std::string purpose;
 
-    CAddressBookData()
+    CAddressBookData() : purpose("unknown") {}
-    {
-        purpose = "unknown";
-    }
 
     typedef std::map<std::string, std::string> StringMap;
     StringMap destdata;