rpc: fix docs for bumpfee psbt update

- "psbt" field is only returned in psbtbumpfee and not bumpfee
- bumpfee raises if privkeys are disabled, so drop "Only returned when wallet private keys are enabled."
- add missing space in RPC example
pull/826/head
Jon Atack 4 years ago
parent eb4df9a628
commit 5cb7ac23fb
No known key found for this signature in database
GPG Key ID: 4F5721B3D0E3921D

@ -3430,12 +3430,10 @@ static RPCHelpMan bumpfee_helper(std::string method_name)
"options"}, "options"},
}, },
RPCResult{ RPCResult{
RPCResult::Type::OBJ, "", "", Cat(Cat<std::vector<RPCResult>>( RPCResult::Type::OBJ, "", "", Cat(
{ want_psbt ?
{RPCResult::Type::STR, "psbt", "The base64-encoded unsigned PSBT of the new transaction."}, std::vector<RPCResult>{{RPCResult::Type::STR, "psbt", "The base64-encoded unsigned PSBT of the new transaction."}} :
}, std::vector<RPCResult>{{RPCResult::Type::STR_HEX, "txid", "The id of the new transaction."}},
want_psbt ? std::vector<RPCResult>{} : std::vector<RPCResult>{{RPCResult::Type::STR_HEX, "txid", "The id of the new transaction. Only returned when wallet private keys are enabled."}}
),
{ {
{RPCResult::Type::STR_AMOUNT, "origfee", "The fee of the replaced transaction."}, {RPCResult::Type::STR_AMOUNT, "origfee", "The fee of the replaced transaction."},
{RPCResult::Type::STR_AMOUNT, "fee", "The fee of the new transaction."}, {RPCResult::Type::STR_AMOUNT, "fee", "The fee of the new transaction."},
@ -3446,7 +3444,7 @@ static RPCHelpMan bumpfee_helper(std::string method_name)
}) })
}, },
RPCExamples{ RPCExamples{
"\nBump the fee, get the new transaction\'s" + std::string(want_psbt ? "psbt" : "txid") + "\n" + "\nBump the fee, get the new transaction\'s " + std::string(want_psbt ? "psbt" : "txid") + "\n" +
HelpExampleCli(method_name, "<txid>") HelpExampleCli(method_name, "<txid>")
}, },
[want_psbt](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue [want_psbt](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue

Loading…
Cancel
Save