Merge bitcoin-core/gui#420: Ensure translator comments end in full stop

5cc783f5f3 qt: ensure translator comments end in full stop (Jarol Rodriguez)

Pull request description:

  This is a follow-up to #318 which addresses this [nit](https://github.com/bitcoin-core/gui/pull/318#discussion_r706856893) by addressing it globally.

  This ensures that all GUI translator comments end in a full stop. If a comment does not end in a full stop, a translator may think  that the rest of the comment is being cut off.

  While here, add a colon to the word "see" for any comments touched which point to look at a link.

ACKs for top commit:
  hebasto:
    ACK 5cc783f5f3, I have reviewed the code and it looks OK, I agree it can be merged.
  shaavan:
    Code Review ACK 5cc783f5f3

Tree-SHA512: 67a1d56175c974e0af9b460fa44163f7ce139a7b81cfaf8ed2c0e7fb6d5120957c3135d96010aeb6229689468e36673fe9571b5a8c3e1c07e047aba1bd563444
pull/826/head
Hennadii Stepanov 3 years ago
commit 2161a05855
No known key found for this signature in database
GPG Key ID: 410108112E7EA81F

@ -282,7 +282,7 @@ void AddressBookPage::on_exportButton_clicked()
QString filename = GUIUtil::getSaveFileName(this, QString filename = GUIUtil::getSaveFileName(this,
tr("Export Address List"), QString(), tr("Export Address List"), QString(),
/*: Expanded name of the CSV file format. /*: Expanded name of the CSV file format.
See https://en.wikipedia.org/wiki/Comma-separated_values */ See: https://en.wikipedia.org/wiki/Comma-separated_values. */
tr("Comma separated file") + QLatin1String(" (*.csv)"), nullptr); tr("Comma separated file") + QLatin1String(" (*.csv)"), nullptr);
if (filename.isNull()) if (filename.isNull())

@ -119,7 +119,7 @@ void QRImageWidget::saveImage()
QString fn = GUIUtil::getSaveFileName( QString fn = GUIUtil::getSaveFileName(
this, tr("Save QR Code"), QString(), this, tr("Save QR Code"), QString(),
/*: Expanded name of the PNG file format. /*: Expanded name of the PNG file format.
See https://en.wikipedia.org/wiki/Portable_Network_Graphics */ See: https://en.wikipedia.org/wiki/Portable_Network_Graphics. */
tr("PNG Image") + QLatin1String(" (*.png)"), nullptr); tr("PNG Image") + QLatin1String(" (*.png)"), nullptr);
if (!fn.isEmpty()) if (!fn.isEmpty())
{ {

@ -680,7 +680,7 @@ void RPCConsole::setClientModel(ClientModel *model, int bestblock_height, int64_
// create peer table context menu // create peer table context menu
peersTableContextMenu = new QMenu(this); peersTableContextMenu = new QMenu(this);
//: Context menu action to copy the address of a peer //: Context menu action to copy the address of a peer.
peersTableContextMenu->addAction(tr("&Copy address"), [this] { peersTableContextMenu->addAction(tr("&Copy address"), [this] {
GUIUtil::copyEntryData(ui->peerWidget, PeerTableModel::Address, Qt::DisplayRole); GUIUtil::copyEntryData(ui->peerWidget, PeerTableModel::Address, Qt::DisplayRole);
}); });
@ -713,7 +713,7 @@ void RPCConsole::setClientModel(ClientModel *model, int bestblock_height, int64_
banTableContextMenu = new QMenu(this); banTableContextMenu = new QMenu(this);
/*: Context menu action to copy the IP/Netmask of a banned peer. /*: Context menu action to copy the IP/Netmask of a banned peer.
IP/Netmask is the combination of a peer's IP address and its Netmask. IP/Netmask is the combination of a peer's IP address and its Netmask.
For IP address see: https://en.wikipedia.org/wiki/IP_address */ For IP address, see: https://en.wikipedia.org/wiki/IP_address. */
banTableContextMenu->addAction(tr("&Copy IP/Netmask"), [this] { banTableContextMenu->addAction(tr("&Copy IP/Netmask"), [this] {
GUIUtil::copyEntryData(ui->banlistWidget, BanTableModel::Address, Qt::DisplayRole); GUIUtil::copyEntryData(ui->banlistWidget, BanTableModel::Address, Qt::DisplayRole);
}); });

@ -200,7 +200,7 @@ void SendCoinsDialog::setModel(WalletModel *_model)
ui->optInRBF->setCheckState(Qt::Checked); ui->optInRBF->setCheckState(Qt::Checked);
if (model->wallet().hasExternalSigner()) { if (model->wallet().hasExternalSigner()) {
//: "device" usually means a hardware wallet //: "device" usually means a hardware wallet.
ui->sendButton->setText(tr("Sign on device")); ui->sendButton->setText(tr("Sign on device"));
if (gArgs.GetArg("-signer", "") != "") { if (gArgs.GetArg("-signer", "") != "") {
ui->sendButton->setEnabled(true); ui->sendButton->setEnabled(true);

@ -353,7 +353,7 @@ void TransactionView::exportClicked()
QString filename = GUIUtil::getSaveFileName(this, QString filename = GUIUtil::getSaveFileName(this,
tr("Export Transaction History"), QString(), tr("Export Transaction History"), QString(),
/*: Expanded name of the CSV file format. /*: Expanded name of the CSV file format.
See https://en.wikipedia.org/wiki/Comma-separated_values */ See: https://en.wikipedia.org/wiki/Comma-separated_values. */
tr("Comma separated file") + QLatin1String(" (*.csv)"), nullptr); tr("Comma separated file") + QLatin1String(" (*.csv)"), nullptr);
if (filename.isNull()) if (filename.isNull())

Loading…
Cancel
Save