@ -170,13 +170,13 @@ judge the general consensus of contributors.
In general, all pull requests must:
In general, all pull requests must:
- h ave a clear use case, fix a demonstrable bug or serve the greater good of
- H ave a clear use case, fix a demonstrable bug or serve the greater good of
the project (for example refactoring for modularisation);
the project (for example refactoring for modularisation);
- b e well peer reviewed;
- B e well peer reviewed;
- h ave unit tests and functional tests where appropriate;
- H ave unit tests and functional tests where appropriate;
- f ollow code style guidelines;
- F ollow code style guidelines;
- n ot break the existing test suite;
- N ot break the existing test suite;
- w here bugs are fixed, where possible, there should be unit tests
- W here bugs are fixed, where possible, there should be unit tests
demonstrating the bug and also proving the fix. This helps prevent regression.
demonstrating the bug and also proving the fix. This helps prevent regression.
Patches that change Bitcoin consensus rules are considerably more involved than
Patches that change Bitcoin consensus rules are considerably more involved than