merge-script
db8350b0e3
Merge bitcoin/bitcoin#30803 : build: Minor build system fixes and amendments
...
1cc93fe7b4
build: Delete dead code that implements `IF_CHECK_FAILED` option (Hennadii Stepanov)
341ad23809
build: Delete MSVC special case for `BUILD_FOR_FUZZING` option (Hennadii Stepanov)
fdad128b52
build: Stop enabling CMake's CMP0141 policy (Hennadii Stepanov)
b2a6f545b4
doc: Drop `ctest` command from Windows cross-compiling instructions (Hennadii Stepanov)
73b618582d
build: Print `CMAKE_CXX_COMPILER_ARG1` in summary (Hennadii Stepanov)
f03c942095
build, test: Add missed log options (Hennadii Stepanov)
6f2cb0eafd
doc: Amend comment about ZeroMQ config files (Hennadii Stepanov)
Pull request description:
This PR addresses the following comments:
- https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1742342524
- https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1728692369
- https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1736110362
- https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1742931121
- https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1747723657
- https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1742328675
- https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1723106474
ACKs for top commit:
sipsorcery:
tACK 1cc93fe7b4
(win11 msvc).
maflcko:
re-ACK 1cc93fe7b4
Tree-SHA512: a390797bb4d3b7eb9163653b6c9c324e7a01090f6cdda74df7349a24a5c4a2084e5912878747f56561315afc70cae9adb1c363f47ceb0af96004ea591d25171b
2 months ago
Hennadii Stepanov
5ba03e7d35
build: Use CMake's default permissions in macOS `deploy` target
...
This change fixes reproducibility issue with macOS Guix builds.
2 months ago
Hennadii Stepanov
1cc93fe7b4
build: Delete dead code that implements `IF_CHECK_FAILED` option
2 months ago
Hennadii Stepanov
73b618582d
build: Print `CMAKE_CXX_COMPILER_ARG1` in summary
...
When `-DCMAKE_CXX_COMPILER='clang++;-stdlib=libc++;-m32'` is provided,
`-stdlib=libc++ -m32` flags are printed in the summary now.
2 months ago
fanquake
1f054eca4e
cmake: add USE_SOURCE_PERMISSIONS to all configure_file usage
...
`USE_SOURCE_PERMISSIONS` is the default, so this should not change
behaviour. However, being explicit makes it clear what we are doing.
Related to #30815 .
See
https://cmake.org/cmake/help/latest/command/configure_file.html#options .
2 months ago
fanquake
a7a4e11db8
cmake: scope Boost Test check to vcpkg
...
This check was added for vcpkg, given how it packages Boost. However, we
don't need to run the check for other platforms, and it's quite slow.
So, scope it to VCPKG. On my machine, this reduces the time to run
`cmake -B build` from ~12 seconds, to ~6 seconds.
Fixes : #30787
2 months ago
merge-script
6852d1d487
Merge bitcoin/bitcoin#30796 : test: Use std::span and std::string_view for raw data
...
faecca9a85
test: Use span for raw data (MarcoFalke)
fac973647d
test: Use string_view for json_tests (MarcoFalke)
Pull request description:
The build system converts raw data into a C++ header file for tests.
This change modernizes the code to use the convenience wrappers `std::span` and `std::string_view`, so that redundant copies can be avoided.
ACKs for top commit:
fjahr:
re-ACK faecca9a85
TheCharlatan:
ACK faecca9a85
stickies-v:
ACK faecca9a85
hebasto:
ACK faecca9a85
, I have reviewed the code and the generated headers.
Tree-SHA512: 1f4951c54aff11ba27c41fb70f2821bdb79e06ca0abae734b970bd0d64dda9d8cced824a891fd51b3e9d4e5715ee9eb49ed5d369010a45eca7c3bec9f8641235
2 months ago
MarcoFalke
faecca9a85
test: Use span for raw data
...
This change allows to drop brittle sizeof calls in favor of the
std::span::size method.
Other improvements include:
* Use of a namespace to mark test and bench data
* Use of the modern std::byte
* Drop of a no longer used std::vector copy and the bench/data module
2 months ago
Hennadii Stepanov
e7cf4a6f27
build: Add missed `-g` for "Coverage" build configuration
2 months ago
Hennadii Stepanov
8b6f1c4353
cmake: Add `Coverage` and `CoverageFuzz` scripts
3 months ago
Hennadii Stepanov
747adb6ffe
cmake: Add `Maintenance` module
3 months ago
Hennadii Stepanov
1f60b30df0
cmake: Add `APPEND_{CPP,C,CXX,LD}FLAGS` cache variables
...
The content of those variables is appended to the each target after the
flags added by the build system.
3 months ago
Hennadii Stepanov
2b43c45b13
cmake: Add `AddWindowsResources` module
3 months ago
Hennadii Stepanov
57a6e2ef4a
cmake: Build `bitcoin-qt` executable
3 months ago
Hennadii Stepanov
353e0c9e96
cmake: Add `systemtap-sdt` optional package support
3 months ago
Hennadii Stepanov
ae7b39a0e1
cmake: Add `libminiupnpc` optional package support
3 months ago
Hennadii Stepanov
6480e1dcdb
cmake: Add `libnatpmp` optional package support
3 months ago
Hennadii Stepanov
d10c5c34c3
cmake: Add wallet functionality
3 months ago
Hennadii Stepanov
959370bd76
cmake: Build `test_bitcoin` executable
3 months ago
Hennadii Stepanov
a9813df826
cmake: Build `bitcoind` executable
3 months ago
Hennadii Stepanov
97829ce2d5
cmake: Add `FindLibevent` module
3 months ago
Hennadii Stepanov
cedfdf6c72
cmake: Redefine/adjust per-configuration flags
3 months ago
Hennadii Stepanov
f98327931b
cmake: Add `TryAppendLinkerFlag` module
3 months ago
Hennadii Stepanov
4a0af29697
cmake: Add `TryAppendCXXFlags` module
3 months ago
Hennadii Stepanov
07069e2bb0
cmake: Add introspection module
...
Co-authored-by: Cory Fields <cory-nospam-@coryfields.com>
Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
3 months ago
Hennadii Stepanov
fe5cdace5f
cmake: Print compiler and linker flags in summary
3 months ago
Hennadii Stepanov
70683884c5
cmake: Introduce interface libraries to encapsulate common flags
...
Also add a sanity check for non-encapsulated (directory-wide) build
properties.
3 months ago