504 Commits (14aacdc5e5a5a3562e3b61d318d33818cbd7fac0)

 

All Branches   

Search

Author	SHA1	Message	Date
Pieter Wuille	14aacdc5e5	Merge pull request #239 ... 93226a5 secp256k1.c: Add missing DEBUG_CHECKs for sufficiently capable contexts (Andrew Poelstra)	10 years ago
Andrew Poelstra	93226a54b4	secp256k1.c: Add missing DEBUG_CHECKs for sufficiently capable contexts	10 years ago
Pieter Wuille	6099220e7b	Merge pull request #237 ... 6066bb6 Fix typo: avg -> max (Pieter Wuille)	10 years ago
Pieter Wuille	6066bb684c	Fix typo: avg -> max	10 years ago
Pieter Wuille	9688030874	Merge pull request #236 ... d899b5b Expose ability to deep-copy a context (Andrew Poelstra)	10 years ago
Andrew Poelstra	d899b5b67c	Expose ability to deep-copy a context	10 years ago
Pieter Wuille	3608c7f2f6	Merge pull request #208 ... a9b6595 [API BREAK] Introduce explicit contexts (Pieter Wuille)	10 years ago
Pieter Wuille	a9b6595ef8	[API BREAK] Introduce explicit contexts	10 years ago
Pieter Wuille	a0d3b89dd6	Merge pull request #233 ... 6534ee1 initialize variable (Cory Fields)	10 years ago
Pieter Wuille	9e8d89bf6d	Merge pull request #234 ... 4450e24 Add a comment about the avoidance of secret data in array indexes. (Gregory Maxwell)	10 years ago
Pieter Wuille	65e70e7542	Merge pull request #235 ... 5098f62 Improve documentation formatting consistency (Daniel Cousens)	10 years ago
Daniel Cousens	5098f62571	Improve documentation formatting consistency	10 years ago
Gregory Maxwell	4450e24a82	Add a comment about the avoidance of secret data in array indexes. ... People elsewhere still seem to be writing crypto code making this mistake, so it must not be that well known.	10 years ago
Cory Fields	6534ee1259	initialize variable	10 years ago
Pieter Wuille	d5b53aa818	Merge pull request #232 ... c01df1a Avoid some implicit type conversions to make C++ compilers happy. (Gregory Maxwell)	10 years ago
Gregory Maxwell	c01df1adc9	Avoid some implicit type conversions to make C++ compilers happy.	10 years ago
Pieter Wuille	bfe96ba1ee	Merge pull request #231 ... 33270bf Add a couple comments pointing to particular sections of RFC6979. (Gregory Maxwell)	10 years ago
Gregory Maxwell	33270bff87	Add a couple comments pointing to particular sections of RFC6979.	10 years ago
Pieter Wuille	41603aa727	Merge pull request #230 ... 2632019 Brace all the if/for/while. (Gregory Maxwell)	10 years ago
Gregory Maxwell	2632019713	Brace all the if/for/while. ... Unbraced statements spanning multiple lines has been shown in many projects to contribute to the introduction of bugs and a failure to catch them in review, especially for maintenance on infrequently modified code. Most, but not all, of the existing practice in the codebase were not cases that I would have expected to eventually result in bugs but applying it as a rule makes it easier for other people to safely contribute. I'm not aware of any such evidence for the case with the statement on a single line, but some people strongly prefer to never do that and the opposite rule of "_always_ use a single line for single statement blocks" isn't a reasonable rule for formatting reasons. Might as well brace all these too, since that's more universally acceptable. [In any case, I seem to have introduced the vast majority of the single-line form (as they're my preference where they fit).] This also removes a broken test which is no longer needed.	10 years ago
Pieter Wuille	1897b8e90b	Merge pull request #229 ... efc571c Add simple testcases for signing with rfc6979 extra entropy. (Gregory Maxwell) 1573a10 Add ability to pass extra entropy to rfc6979 (Pieter Wuille)	10 years ago
Gregory Maxwell	efc571ceea	Add simple testcases for signing with rfc6979 extra entropy.	10 years ago
Pieter Wuille	1573a102c0	Add ability to pass extra entropy to rfc6979 ... Suggested by Greg Maxwell.	10 years ago
Pieter Wuille	3087bc4d75	Merge pull request #228 ... 27bc131 Silence some warnings from pedantic static analysis tools, improve compatibility with C++. (Gregory Maxwell)	10 years ago
Pieter Wuille	d9b9f119e8	Merge pull request #218 ... 0065a8f Eliminate multiple-returns from secp256k1.c. (Gregory Maxwell) 354ffa3 Make secp256k1_ec_pubkey_create reject oversized secrets. (Gregory Maxwell)	10 years ago
Gregory Maxwell	0065a8fb9c	Eliminate multiple-returns from secp256k1.c. ... Goto, multiple returns, continue, and/or multiple breaks in a loop are often used to build complex or non-local control flow in software. (They're all basically the same thing, and anyone axiomatically opposing goto and not the rest is probably cargo-culting from the title of Dijkstra's essay without thinking hard about it.) Personally, I think the current use of these constructs in the code base is fine: no where are we using them to create control- flow that couldn't easily be described in plain English, which is hard to read or reason about, or which looks like a trap for future developers. Some, however, prefer a more rules based approach to software quality. In particular, MISRA forbids all of these constructs, and for good experience based reasons. Rules also have the benefit of being machine checkable and surviving individual developers. (To be fair-- MISRA also has a process for accommodating code that breaks the rules for good reason). I think that in general we should also try to satisfy the rules- based measures of software quality, except where there is an objective reason not do: a measurable performance difference, logic that turns to spaghetti, etc. Changing out all the multiple returns in secp256k1.c appears to be basically neutral: Some parts become slightly less clear, some parts slightly more.	10 years ago
Gregory Maxwell	354ffa33e6	Make secp256k1_ec_pubkey_create reject oversized secrets.	10 years ago
Gregory Maxwell	27bc1311af	Silence some warnings from pedantic static analysis tools, improve compatibility with C++. ... C doesn't include the null in an array initilized from a string literal if it doesn't fit, in C++ this is invalid. The vararray style prototypes and init+calc also changed in this commit are not C89 enough for some tools.	10 years ago
Pieter Wuille	3b7ea633fb	Merge pull request #221 ... 443cd4b Get rid of hex format and some binary conversions (Pieter Wuille)	10 years ago
Pieter Wuille	f789c5baf2	Merge pull request #215 ... 8956111 use 128-bit hex seed (Pieter Wuille) 02efd06 Use RFC6979 for test PRNGs (Pieter Wuille)	10 years ago
Pieter Wuille	4bc273bd9c	Merge pull request #222 ... 7c3771d Disable overlength-strings warnings. (evoskuil)	10 years ago
Pieter Wuille	137a8ec45b	Merge pull request #216 ... ae55e85 Use faster byteswapping and avoid alignment-increasing casts. (Pieter Wuille)	10 years ago
evoskuil	7c3771dd0f	Disable overlength-strings warnings.	10 years ago
Pieter Wuille	8956111802	use 128-bit hex seed	10 years ago
Pieter Wuille	02efd06554	Use RFC6979 for test PRNGs	10 years ago
Pieter Wuille	ae55e850c7	Use faster byteswapping and avoid alignment-increasing casts.	10 years ago
Pieter Wuille	443cd4b8ee	Get rid of hex format and some binary conversions	10 years ago
Pieter Wuille	0bada0e2a9	Merge #214: Improve signing API documentation & specification ... 8030d7c Improve signing API documentation & specification (Pieter Wuille)	10 years ago
Pieter Wuille	8030d7c0e5	Improve signing API documentation & specification	10 years ago
Pieter Wuille	7b2fc1cac6	Merge #213: Removed gotos, which are hard to trace and maintain. ... 11690d3 Removed gotos, which are hard to trace and maintain. (Iang)	10 years ago
Iang	11690d3bb9	Removed gotos, which are hard to trace and maintain.	10 years ago
Pieter Wuille	122a1ecf30	Merge pull request #205 ... 6cc8425 Include a comment on secp256k1_ecdsa_sign explaining low-s. (Gregory Maxwell)	10 years ago
Pieter Wuille	035406d6db	Merge pull request #206 ... 34b898d Additional comments for the testing PRNG and a seeding fix. (Gregory Maxwell) 6efd6e7 Some comments explaining some of the constants in the code. (Gregory Maxwell)	10 years ago
Pieter Wuille	2d4cd53087	Merge pull request #161 ... ffccfd2 x86_64 assembly optimization for scalar_4x64 (Pieter Wuille)	10 years ago
Gregory Maxwell	34b898dc84	Additional comments for the testing PRNG and a seeding fix. ... Rw has additional short-cycle inputs because 2^32/0x464fffff >= 2.	10 years ago
Gregory Maxwell	6efd6e7777	Some comments explaining some of the constants in the code.	10 years ago
Pieter Wuille	ffccfd2d00	x86_64 assembly optimization for scalar_4x64	10 years ago
Pieter Wuille	67cbdf0440	Merge pull request #207 ... 039723d Benchmarks for all internal operations (Pieter Wuille)	10 years ago
Pieter Wuille	039723d5da	Benchmarks for all internal operations	10 years ago
Gregory Maxwell	6cc8425c91	Include a comment on secp256k1_ecdsa_sign explaining low-s. ... This was suggested by DavidEGrayson.	10 years ago