test: Properly raise FailedToStartError when rpc shutdown before warmup finished (take 2)

pull/18633/head
MarcoFalke 5 years ago
parent 4702cadca9
commit fa03713e13
No known key found for this signature in database
GPG Key ID: CE2B75697E69A548

@ -225,9 +225,6 @@ class TestNode():
self.rpc_connected = True self.rpc_connected = True
self.url = self.rpc.url self.url = self.rpc.url
return return
except IOError as e:
if e.errno != errno.ECONNREFUSED: # Port not yet open?
raise # unknown IO error
except JSONRPCException as e: # Initialization phase except JSONRPCException as e: # Initialization phase
# -28 RPC in warmup # -28 RPC in warmup
# -342 Service unavailable, RPC server started but is shutting down due to error # -342 Service unavailable, RPC server started but is shutting down due to error
@ -237,6 +234,9 @@ class TestNode():
# This might happen when the RPC server is in warmup, but shut down before the call to getblockcount # This might happen when the RPC server is in warmup, but shut down before the call to getblockcount
# succeeds. Try again to properly raise the FailedToStartError # succeeds. Try again to properly raise the FailedToStartError
pass pass
except OSError as e:
if e.errno != errno.ECONNREFUSED: # Port not yet open?
raise # unknown OS error
except ValueError as e: # cookie file not found and no rpcuser or rpcassword. bitcoind still starting except ValueError as e: # cookie file not found and no rpcuser or rpcassword. bitcoind still starting
if "No RPC credentials" not in str(e): if "No RPC credentials" not in str(e):
raise raise

Loading…
Cancel
Save