boxtec
/
bitcoin
mirror of https://github.com/bitcoin/bitcoin
4
1
Fork 0
Code Issues Projects Releases Wiki Activity

Merge #12322: Docs: Remove step making cloned repository world-writable for Windows build.

Browse Source 
eeeb416 Remove suggestion to make cloned repository world-writable for Windows build. (murrayn)

Pull request description:

  Current documentation for Windows build on Ubuntu suggests cloning the repository into /usr/src, as root, and making the tree world-writable(!). I can see no problem this solves, and it introduces obvious security issues.

Tree-SHA512: 05429a64319c046f5506f7d27c64c94f94cfe6d14ec5f01dccf843fc417e954fe96e1abc43126b9204a1178f101e4a8da9eece32b5de4b348c7c9358615c7e0f
pull/12325/merge
Wladimir J. van der Laan 7 years ago
parent 9a32114626 eeeb416d73
commit c3451483d2
No known key found for this signature in database
GPG Key ID: 1E4AED62986CD25D
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File

12
doc/build-windows.md
Unescape View File

@ -102,11 +102,9 @@ Note that for WSL the Bitcoin Core source path MUST be somewhere in the default
example /usr/src/bitcoin, AND not under /mnt/d/. If this is not the case the dependency autoconf scripts will fail. example /usr/src/bitcoin, AND not under /mnt/d/. If this is not the case the dependency autoconf scripts will fail.
This means you cannot use a directory that located directly on the host Windows file system to perform the build. This means you cannot use a directory that located directly on the host Windows file system to perform the build.
The next three steps are an example of how to acquire the source in an appropriate way. Acquire the source in the usual way:
cd /usr/src git clone https://github.com/bitcoin/bitcoin.git
sudo git clone https://github.com/bitcoin/bitcoin.git
sudo chmod -R a+rw bitcoin
Once the source code is ready the build steps are below. Once the source code is ready the build steps are below.
@ -132,11 +130,9 @@ Note that for WSL the Bitcoin Core source path MUST be somewhere in the default
example /usr/src/bitcoin, AND not under /mnt/d/. If this is not the case the dependency autoconf scripts will fail. example /usr/src/bitcoin, AND not under /mnt/d/. If this is not the case the dependency autoconf scripts will fail.
This means you cannot use a directory that located directly on the host Windows file system to perform the build. This means you cannot use a directory that located directly on the host Windows file system to perform the build.
The next three steps are an example of how to acquire the source in an appropriate way. Acquire the source in the usual way:
cd /usr/src git clone https://github.com/bitcoin/bitcoin.git
sudo git clone https://github.com/bitcoin/bitcoin.git
sudo chmod -R a+rw bitcoin
Then build using: Then build using:

Write Preview
Loading…
Cancel
Save