Merge #12849: Tests: Add logging in loops in p2p_sendhears.py

8dd547d82b Adding logging for loop iteration level in p2p_sendheaders.py (ccdle12)

Pull request description:

  PR for #12453

  New contributor looking at mainly the 'good first issues'.

  From my understanding of the issue:
   * Track the iteration level of loop when test fails in Travis CI

  Further clarification on the issue would be greatly appreciated to narrow down what can be fixed or updated.

Tree-SHA512: 228524aad54c09979d990a0fc6818e13a11e1ab5e78b606b892e897bba7b1e09bf25447feb631049e45ac017eeb61fbf1c1f11e8bd5103648f976a05099ba9f9

test/functional/p2p_sendheaders.py

@@ -411,21 +411,18 @@ class SendHeadersTest(BitcoinTestFramework):
                 inv_node.check_last_announcement(inv=[tip], headers=[])
                 test_node.check_last_announcement(inv=[tip], headers=[])
                 if i == 0:
-                    # Just get the data -- shouldn't cause headers announcements to resume
+                    self.log.debug("Just get the data -- shouldn't cause headers announcements to resume")
                     test_node.send_get_data([tip])
                     test_node.wait_for_block(tip)
                 elif i == 1:
-                    # Send a getheaders message that shouldn't trigger headers announcements
+                    self.log.debug("Send a getheaders message that shouldn't trigger headers announcements to resume (best header sent will be too old)")
-                    # to resume (best header sent will be too old)
                     test_node.send_get_headers(locator=[fork_point], hashstop=new_block_hashes[1])
                     test_node.send_get_data([tip])
                     test_node.wait_for_block(tip)
                 elif i == 2:
                     test_node.send_get_data([tip])
                     test_node.wait_for_block(tip)
-                    # This time, try sending either a getheaders to trigger resumption
+                    self.log.debug("This time, try sending either a getheaders to trigger resumption of headers announcements, or mine a new block and inv it, also triggering resumption of headers announcements.")
-                    # of headers announcements, or mine a new block and inv it, also
-                    # triggering resumption of headers announcements.
                     if j == 0:
                         test_node.send_get_headers(locator=[tip], hashstop=0)
                         test_node.sync_with_ping()