mirror of https://github.com/bitcoin/bitcoin
Merge bitcoin/bitcoin#29363: test: Fix CPartialMerkleTree.nTransactions signedness
pull/29404/headfacafa90f7
test: Fix CPartialMerkleTree.nTransactions signedness (MarcoFalke) Pull request description: It is unsigned in Bitcoin Core, so the tests should match it:aa9231fafe/src/merkleblock.h (L59)
Large positive values, or "negative" values, are rejected anyway, but it still seems fine to fix this. The bug was introduced when the code was written ind280617bf5
. (Lowercase `i` means signed, see https://docs.python.org/3/library/struct.html#format-characters) ACKs for top commit: theStack: LGTM ACKfacafa90f7
Empact: ACKfacafa90f7
Tree-SHA512: 35ac11bb5382dffe132bfae6097efc343ef6c06b1b4b1545130ca27b228ca6894679004862fee921b095172abaddbef5972c24d9bc195ce970f35643bd4a0f09
commit
6737331c4c
Loading…
Reference in new issue