mirror of https://github.com/bitcoin/bitcoin
Merge bitcoin/bitcoin#31015: build: have "make test" depend on "make all"
pull/31198/head2957ca9611
build: have "make test" depend on "make all" (Cory Fields) Pull request description: See [Upstream docs](https://cmake.org/cmake/help/latest/variable/CMAKE_SKIP_TEST_ALL_DEPENDENCY.html) for specifics. Unfortunately, this **seems to have no effect when directly executing `ctest`** :( This brings the test -> hack -> test cycle more inline with how it worked with autotools. With `CMAKE_SKIP_TEST_ALL_DEPENDENCY` set to FALSE, `make test` will trigger a rebuild, ensuring that test binaries are current before running them. To test: ``` cmake -S . -B build make -C build -j24 touch src/primitives/transaction.cpp make -C build test ARGS=-j24 ``` Without this commit, the above will not rebuild before running tests. ACKs for top commit: tdb3: ACK2957ca9611
itornaza: ACK2957ca9611
laanwj: ACK2957ca9611
Tree-SHA512: 46e6d53fd9c28b2f47b34c42ae0b061b01ef7614cdf5ee7d49fb9d3413ca92983d8a996379a9067ac8a8cfc16b230946401e68cf114bd4e3c5c02db2c55ec6bb
commit
6251610553
Loading…
Reference in new issue