Skip --descriptor tests if sqlite is not compiled

pull/20262/head
Andrew Chow 4 years ago
parent 42b66a6b81
commit 586640381a

@ -16,6 +16,7 @@ RPCAUTH=@abs_top_srcdir@/share/rpcauth/rpcauth.py
[components] [components]
# Which components are enabled. These are commented out by `configure` if they were disabled when running config. # Which components are enabled. These are commented out by `configure` if they were disabled when running config.
@ENABLE_WALLET_TRUE@ENABLE_WALLET=true @ENABLE_WALLET_TRUE@ENABLE_WALLET=true
@USE_SQLITE_TRUE@USE_SQLITE=true
@BUILD_BITCOIN_CLI_TRUE@ENABLE_CLI=true @BUILD_BITCOIN_CLI_TRUE@ENABLE_CLI=true
@BUILD_BITCOIN_WALLET_TRUE@ENABLE_WALLET_TOOL=true @BUILD_BITCOIN_WALLET_TRUE@ENABLE_WALLET_TOOL=true
@BUILD_BITCOIND_TRUE@ENABLE_BITCOIND=true @BUILD_BITCOIND_TRUE@ENABLE_BITCOIND=true

@ -769,6 +769,13 @@ class BitcoinTestFramework(metaclass=BitcoinTestMetaClass):
"""Skip the running test if wallet has not been compiled.""" """Skip the running test if wallet has not been compiled."""
if not self.is_wallet_compiled(): if not self.is_wallet_compiled():
raise SkipTest("wallet has not been compiled.") raise SkipTest("wallet has not been compiled.")
if self.options.descriptors:
self.skip_if_no_sqlite()
def skip_if_no_sqlite(self):
"""Skip the running test if sqlite has not been compiled."""
if not self.is_sqlite_compiled():
raise SkipTest("sqlite has not been compiled.")
def skip_if_no_wallet_tool(self): def skip_if_no_wallet_tool(self):
"""Skip the running test if bitcoin-wallet has not been compiled.""" """Skip the running test if bitcoin-wallet has not been compiled."""
@ -808,3 +815,7 @@ class BitcoinTestFramework(metaclass=BitcoinTestMetaClass):
def is_zmq_compiled(self): def is_zmq_compiled(self):
"""Checks whether the zmq module was compiled.""" """Checks whether the zmq module was compiled."""
return self.config["components"].getboolean("ENABLE_ZMQ") return self.config["components"].getboolean("ENABLE_ZMQ")
def is_sqlite_compiled(self):
"""Checks whether the wallet module was compiled."""
return self.config["components"].getboolean("USE_SQLITE")

@ -171,7 +171,7 @@ BASE_SCRIPTS = [
'rpc_net.py', 'rpc_net.py',
'wallet_keypool.py', 'wallet_keypool.py',
'wallet_keypool.py --descriptors', 'wallet_keypool.py --descriptors',
'wallet_descriptor.py', 'wallet_descriptor.py --descriptors',
'p2p_nobloomfilter_messages.py', 'p2p_nobloomfilter_messages.py',
'p2p_filter.py', 'p2p_filter.py',
'rpc_setban.py', 'rpc_setban.py',
@ -208,7 +208,7 @@ BASE_SCRIPTS = [
'mempool_expiry.py', 'mempool_expiry.py',
'wallet_import_rescan.py', 'wallet_import_rescan.py',
'wallet_import_with_label.py', 'wallet_import_with_label.py',
'wallet_importdescriptors.py', 'wallet_importdescriptors.py --descriptors',
'wallet_upgradewallet.py', 'wallet_upgradewallet.py',
'rpc_bind.py --ipv4', 'rpc_bind.py --ipv4',
'rpc_bind.py --ipv6', 'rpc_bind.py --ipv6',

@ -19,6 +19,7 @@ class WalletDescriptorTest(BitcoinTestFramework):
def skip_test_if_missing_module(self): def skip_test_if_missing_module(self):
self.skip_if_no_wallet() self.skip_if_no_wallet()
self.skip_if_no_sqlite()
def run_test(self): def run_test(self):
wallet_info = self.nodes[0].getwalletinfo() wallet_info = self.nodes[0].getwalletinfo()

@ -37,6 +37,7 @@ class ImportDescriptorsTest(BitcoinTestFramework):
def skip_test_if_missing_module(self): def skip_test_if_missing_module(self):
self.skip_if_no_wallet() self.skip_if_no_wallet()
self.skip_if_no_sqlite()
def test_importdesc(self, req, success, error_code=None, error_message=None, warnings=None, wallet=None): def test_importdesc(self, req, success, error_code=None, error_message=None, warnings=None, wallet=None):
"""Run importdescriptors and assert success""" """Run importdescriptors and assert success"""

Loading…
Cancel
Save