mirror of https://github.com/bitcoin/bitcoin
This is the same approach as for the addpeeraddress test in `test/functional/rpc_net.py` in commitpull/23084/head869f1368
. The probability of collision when adding an addrman entry is expected to be 1/2^16 = 1/65536 for an address from a different /16. This change hopes to avoid these collisions by adding 1 tried entry before adding 1 new table one, instead of 2 tried entries followed by 2 new entries, which appears to have caused a collision in the CI. To verify the regression test stills fails when expected: - git checkout181a120
&& git cherry-pickef242f5
- recompile bitcoind - git checkout this branch and run test/functional/feature_asmap.py. Expected output: ``` AssertionError: Unexpected stderr bitcoind: ./addrman.h:739: void CAddrMan::Check() const: Assertion `false' failed. != ``` Co-authored-by: Martin Zumsande <mzumsande@gmail.com>
parent
b7e3600815
commit
5825b34783
Loading…
Reference in new issue