Merge pull request #6272

edbdf88 tests: Extend RPC proxy tests (Wladimir J. van der Laan)
baf0507 Improve proxy initialization (Wladimir J. van der Laan)

qa/rpc-tests/proxy_test.py

@@ -68,10 +68,10 @@ class ProxyTest(BitcoinTestFramework):
             ['-listen', '-debug=net', '-debug=proxy', '-proxy=%s:%i' % (self.conf1.addr),'-proxyrandomize=1'], 
             ['-listen', '-debug=net', '-debug=proxy', '-proxy=%s:%i' % (self.conf1.addr),'-onion=%s:%i' % (self.conf2.addr),'-proxyrandomize=0'], 
             ['-listen', '-debug=net', '-debug=proxy', '-proxy=%s:%i' % (self.conf2.addr),'-proxyrandomize=1'], 
-            ['-listen', '-debug=net', '-debug=proxy', '-proxy=[%s]:%i' % (self.conf3.addr),'-proxyrandomize=0']
+            ['-listen', '-debug=net', '-debug=proxy', '-proxy=[%s]:%i' % (self.conf3.addr),'-proxyrandomize=0', '-noonion']
             ])
 
-    def node_test(self, node, proxies, auth):
+    def node_test(self, node, proxies, auth, test_onion=True):
         rv = []
         # Test: outgoing IPv4 connection through node
         node.addnode("15.61.23.23:1234", "onetry")
@@ -99,17 +99,18 @@ class ProxyTest(BitcoinTestFramework):
             assert_equal(cmd.password, None)
         rv.append(cmd)
 
-        # Test: outgoing onion connection through node
+        if test_onion:
-        node.addnode("bitcoinostk4e4re.onion:8333", "onetry")
+            # Test: outgoing onion connection through node
-        cmd = proxies[2].queue.get()
+            node.addnode("bitcoinostk4e4re.onion:8333", "onetry")
-        assert(isinstance(cmd, Socks5Command))
+            cmd = proxies[2].queue.get()
-        assert_equal(cmd.atyp, AddressType.DOMAINNAME)
+            assert(isinstance(cmd, Socks5Command))
-        assert_equal(cmd.addr, "bitcoinostk4e4re.onion")
+            assert_equal(cmd.atyp, AddressType.DOMAINNAME)
-        assert_equal(cmd.port, 8333)
+            assert_equal(cmd.addr, "bitcoinostk4e4re.onion")
-        if not auth:
+            assert_equal(cmd.port, 8333)
-            assert_equal(cmd.username, None)
+            if not auth:
-            assert_equal(cmd.password, None)
+                assert_equal(cmd.username, None)
-        rv.append(cmd)
+                assert_equal(cmd.password, None)
+            rv.append(cmd)
 
         # Test: outgoing DNS name connection through node
         node.addnode("node.noumenon:8333", "onetry")
@@ -139,8 +140,41 @@ class ProxyTest(BitcoinTestFramework):
         assert_equal(len(credentials), 4)
 
         # proxy on IPv6 localhost
-        self.node_test(self.nodes[3], [self.serv3, self.serv3, self.serv3, self.serv3], False)
+        self.node_test(self.nodes[3], [self.serv3, self.serv3, self.serv3, self.serv3], False, False)
+
+        def networks_dict(d):
+            r = {}
+            for x in d['networks']:
+                r[x['name']] = x
+            return r
+
+        # test RPC getnetworkinfo
+        n0 = networks_dict(self.nodes[0].getnetworkinfo())
+        for net in ['ipv4','ipv6','onion']:
+            assert_equal(n0[net]['proxy'], '%s:%i' % (self.conf1.addr))
+            assert_equal(n0[net]['proxy_randomize_credentials'], True)
+        assert_equal(n0['onion']['reachable'], True)
+
+        n1 = networks_dict(self.nodes[1].getnetworkinfo())
+        for net in ['ipv4','ipv6']:
+            assert_equal(n1[net]['proxy'], '%s:%i' % (self.conf1.addr))
+            assert_equal(n1[net]['proxy_randomize_credentials'], False)
+        assert_equal(n1['onion']['proxy'], '%s:%i' % (self.conf2.addr))
+        assert_equal(n1['onion']['proxy_randomize_credentials'], False)
+        assert_equal(n1['onion']['reachable'], True)
         
+        n2 = networks_dict(self.nodes[2].getnetworkinfo())
+        for net in ['ipv4','ipv6','onion']:
+            assert_equal(n2[net]['proxy'], '%s:%i' % (self.conf2.addr))
+            assert_equal(n2[net]['proxy_randomize_credentials'], True)
+        assert_equal(n2['onion']['reachable'], True)
+
+        n3 = networks_dict(self.nodes[3].getnetworkinfo())
+        for net in ['ipv4','ipv6']:
+            assert_equal(n3[net]['proxy'], '[%s]:%i' % (self.conf3.addr))
+            assert_equal(n3[net]['proxy_randomize_credentials'], False)
+        assert_equal(n3['onion']['reachable'], False)
+
 if __name__ == '__main__':
     ProxyTest().main()
 

src/init.cpp

@@ -987,31 +987,36 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)
         }
     }
 
-    proxyType addrProxy;
+    bool proxyRandomize = GetBoolArg("-proxyrandomize", true);
-    bool fProxy = false;
+    // -proxy sets a proxy for all outgoing network traffic
-    if (mapArgs.count("-proxy")) {
+    // -noproxy (or -proxy=0) as well as the empty string can be used to not set a proxy, this is the default
-        addrProxy = proxyType(CService(mapArgs["-proxy"], 9050), GetBoolArg("-proxyrandomize", true));
+    std::string proxyArg = GetArg("-proxy", "");
+    if (proxyArg != "" && proxyArg != "0") {
+        proxyType addrProxy = proxyType(CService(proxyArg, 9050), proxyRandomize);
         if (!addrProxy.IsValid())
-            return InitError(strprintf(_("Invalid -proxy address: '%s'"), mapArgs["-proxy"]));
+            return InitError(strprintf(_("Invalid -proxy address: '%s'"), proxyArg));
 
         SetProxy(NET_IPV4, addrProxy);
         SetProxy(NET_IPV6, addrProxy);
+        SetProxy(NET_TOR, addrProxy);
         SetNameProxy(addrProxy);
-        fProxy = true;
+        SetReachable(NET_TOR); // by default, -proxy sets onion as reachable, unless -noonion later
     }
 
-    // -onion can override normal proxy, -noonion disables connecting to .onion entirely
+    // -onion can be used to set only a proxy for .onion, or override normal proxy for .onion addresses
-    if (!(mapArgs.count("-onion") && mapArgs["-onion"] == "0") &&
+    // -noonion (or -onion=0) disables connecting to .onion entirely
-        (fProxy || mapArgs.count("-onion"))) {
+    // An empty string is used to not override the onion proxy (in which case it defaults to -proxy set above, or none)
-        proxyType addrOnion;
+    std::string onionArg = GetArg("-onion", "");
-        if (!mapArgs.count("-onion"))
+    if (onionArg != "") {
-            addrOnion = addrProxy;
+        if (onionArg == "0") { // Handle -noonion/-onion=0
-        else
+            SetReachable(NET_TOR, false); // set onions as unreachable
-            addrOnion = proxyType(CService(mapArgs["-onion"], 9050), GetBoolArg("-proxyrandomize", true));
+        } else {
-        if (!addrOnion.IsValid())
+            proxyType addrOnion = proxyType(CService(onionArg, 9050), proxyRandomize);
-            return InitError(strprintf(_("Invalid -onion address: '%s'"), mapArgs["-onion"]));
+            if (!addrOnion.IsValid())
-        SetProxy(NET_TOR, addrOnion);
+                return InitError(strprintf(_("Invalid -onion address: '%s'"), onionArg));
-        SetReachable(NET_TOR);
+            SetProxy(NET_TOR, addrOnion);
+            SetReachable(NET_TOR);
+        }
     }
 
     // see Step 2: parameter interactions for more information about these