|
|
@ -76,7 +76,7 @@ the passed message.
|
|
|
|
|
|
|
|
|
|
|
|
#### Tracepoint `net:outbound_message`
|
|
|
|
#### Tracepoint `net:outbound_message`
|
|
|
|
|
|
|
|
|
|
|
|
Is called when a message is send to a peer over the P2P network. Passes
|
|
|
|
Is called when a message is sent to a peer over the P2P network. Passes
|
|
|
|
information about our peer, the connection and the message as arguments.
|
|
|
|
information about our peer, the connection and the message as arguments.
|
|
|
|
|
|
|
|
|
|
|
|
Arguments passed:
|
|
|
|
Arguments passed:
|
|
|
@ -116,7 +116,7 @@ added to and removed (spent) from the cache when we connect a new block.
|
|
|
|
(`chainstate.CoinsTip()`). For example, the RPCs `generateblock` and
|
|
|
|
(`chainstate.CoinsTip()`). For example, the RPCs `generateblock` and
|
|
|
|
`getblocktemplate` call `TestBlockValidity()`, which applies the UTXO set
|
|
|
|
`getblocktemplate` call `TestBlockValidity()`, which applies the UTXO set
|
|
|
|
changes to a temporary cache. Similarly, mempool consistency checks, which are
|
|
|
|
changes to a temporary cache. Similarly, mempool consistency checks, which are
|
|
|
|
frequent on regtest, also apply the the UTXO set changes to a temporary cache.
|
|
|
|
frequent on regtest, also apply the UTXO set changes to a temporary cache.
|
|
|
|
Changes to the _main_ UTXO cache and to temporary caches trigger the tracepoints.
|
|
|
|
Changes to the _main_ UTXO cache and to temporary caches trigger the tracepoints.
|
|
|
|
We can't tell if a temporary cache or the _main_ cache was changed.
|
|
|
|
We can't tell if a temporary cache or the _main_ cache was changed.
|
|
|
|
|
|
|
|
|
|
|
@ -253,8 +253,8 @@ TRACE6(net, inbound_message,
|
|
|
|
|
|
|
|
|
|
|
|
### Guidelines and best practices
|
|
|
|
### Guidelines and best practices
|
|
|
|
|
|
|
|
|
|
|
|
#### Clear motivation and use-case
|
|
|
|
#### Clear motivation and use case
|
|
|
|
Tracepoints need a clear motivation and use-case. The motivation should
|
|
|
|
Tracepoints need a clear motivation and use case. The motivation should
|
|
|
|
outweigh the impact on, for example, code readability. There is no point in
|
|
|
|
outweigh the impact on, for example, code readability. There is no point in
|
|
|
|
adding tracepoints that don't end up being used.
|
|
|
|
adding tracepoints that don't end up being used.
|
|
|
|
|
|
|
|
|
|
|
|