You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

MarcoFalke deb2327b43 Merge #17018: tests: Add descriptor Parse(...) fuzzing harness ... b5ffa9f3db tests: Add Parse(...) (descriptor) fuzzing harness (practicalswift) fdef8bbf2f tests: Allow for using non-default fuzzing initialization (practicalswift) Pull request description: Add `Parse(...)` (descriptor) fuzzing harness. To test this PR: We can run `test_fuzzing_harnesses.sh` (#17000) during ten seconds to quickly verify that the newly added fuzz harness seem to hit relevant code regions, that the fuzzing throughput seems reasonable, etc. `test_fuzzing_harnesses.sh descriptor 10` runs all fuzzers matching the regexp `descriptor` giving them ten seconds of runtime each. ``` $ CC=clang CXX=clang++ ./configure --enable-fuzz --with-sanitizers=address,fuzzer,undefined $ make $ contrib/devtools/test_fuzzing_harnesses.sh descriptor 10 Testing fuzzer descriptor_parse during 10 second(s) A subset of reached functions: NEW_FUNC[0/17]: 0x55ec8a240c90 in tinyformat::detail::formatImpl(std::ostream&, char const*, tinyformat::detail::FormatArg const*, int) src/./tinyformat.h:791 NEW_FUNC[4/17]: 0x55ec8a2435f0 in tinyformat::detail::printFormatStringLiteral(std::ostream&, char const*) src/./tinyformat.h:564 NEW_FUNC[5/17]: 0x55ec8a2439d0 in tinyformat::detail::streamStateFromFormat(std::ostream&, bool&, int&, char const*, tinyformat::detail::FormatArg const*, int&, int) src/./tinyformat.h:601 NEW_FUNC[6/17]: 0x55ec8a24a3d0 in tinyformat::detail::FormatArg::format(std::ostream&, char const*, char const*, int) const src/./tinyformat.h:513 NEW_FUNC[12/17]: 0x55ec8a29cd70 in void tinyformat::detail::FormatArg::formatImpl<long>(std::ostream&, char const*, char const*, int, void const*) src/./tinyformat.h:530 NEW_FUNC[13/17]: 0x55ec8a29cf50 in void tinyformat::formatValue<long>(std::ostream&, char const*, char const*, int, long const&) src/./tinyformat.h:317 NEW_FUNC[14/17]: 0x55ec8a2ea450 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > tinyformat::format<long>(char const*, long const&) src/./tinyformat.h:976 NEW_FUNC[15/17]: 0x55ec8a346ac0 in void tinyformat::format<long>(std::ostream&, char const*, long const&) src/./tinyformat.h:968 NEW_FUNC[16/17]: 0x55ec8a346d80 in tinyformat::detail::FormatListN<1>::FormatListN<long>(long const&) src/./tinyformat.h:885 NEW_FUNC[0/16]: 0x55ec8a210c90 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > tinyformat::format<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) src/./tinyformat.h:976 NEW_FUNC[2/16]: 0x55ec8a25c3e0 in void tinyformat::format<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(std::ostream&, char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) src/./tinyformat.h:968 NEW_FUNC[3/16]: 0x55ec8a25c6a0 in tinyformat::detail::FormatListN<1>::FormatListN<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) src/./tinyformat.h:885 NEW_FUNC[4/16]: 0x55ec8a25c980 in void tinyformat::detail::FormatArg::formatImpl<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(std::ostream&, char const*, char const*, int, void const*) src/./tinyformat.h:530 NEW_FUNC[6/16]: 0x55ec8b29cc60 in (anonymous namespace)::ParseScript(Span<char const>&, (anonymous namespace)::ParseScriptContext, FlatSigningProvider&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&) src/script/descriptor.cpp:810 NEW_FUNC[8/16]: 0x55ec8b2a4710 in (anonymous namespace)::Expr(Span<char const>&) src/script/descriptor.cpp:657 NEW_FUNC[9/16]: 0x55ec8b2a4d40 in (anonymous namespace)::Func(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, Span<char const>&) src/script/descriptor.cpp:647 NEW_FUNC[15/16]: 0x55ec8b2d7dd0 in Span<char const>::subspan(long) const src/./span.h:33 NEW_FUNC[0/1]: 0x55ec8b2d7830 in Span<char const>::operator[](long) const src/./span.h:31 NEW_FUNC[0/10]: 0x55ec8a2ea090 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > tinyformat::format<char const*>(char const*, char const* const&) src/./tinyformat.h:976 NEW_FUNC[1/10]: 0x55ec8a345d40 in void tinyformat::format<char const*>(std::ostream&, char const*, char const* const&) src/./tinyformat.h:968 NEW_FUNC[2/10]: 0x55ec8a346000 in tinyformat::detail::FormatListN<1>::FormatListN<char const*>(char const* const&) src/./tinyformat.h:885 NEW_FUNC[3/10]: 0x55ec8a3462e0 in void tinyformat::detail::FormatArg::formatImpl<char const*>(std::ostream&, char const*, char const*, int, void const*) src/./tinyformat.h:530 NEW_FUNC[4/10]: 0x55ec8a3464b0 in void tinyformat::formatValue<char const*>(std::ostream&, char const*, char const*, int, char const* const&) src/./tinyformat.h:317 NEW_FUNC[8/10]: 0x55ec8b438ef0 in ParsePrechecks(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) src/util/strencodings.cpp:267 NEW_FUNC[9/10]: 0x55ec8b4398b0 in ParseUInt32(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int*) src/util/strencodings.cpp:309 NEW_FUNC[0/3]: 0x55ec8a2e9430 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > tinyformat::format<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) src/./tinyformat.h:976 NEW_FUNC[1/3]: 0x55ec8a33a6f0 in void tinyformat::format<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(std::ostream&, char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) src/./tinyformat.h:968 NEW_FUNC[2/3]: 0x55ec8a33aa40 in tinyformat::detail::FormatListN<2>::FormatListN<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) src/./tinyformat.h:885 NEW_FUNC[1/2]: 0x55ec8b4331b0 in IsHex(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) src/util/strencodings.cpp:61 NEW_FUNC[13/24]: 0x55ec8b126eb0 in Params() src/chainparams.cpp:384 NEW_FUNC[14/24]: 0x55ec8b19a500 in DecodeDestination(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) src/key_io.cpp:217 NEW_FUNC[15/24]: 0x55ec8b19a610 in (anonymous namespace)::DecodeDestination(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, CChainParams const&) src/key_io.cpp:74 NEW_FUNC[18/24]: 0x55ec8b357160 in IsValidDestination(boost::variant<CNoDestination, PKHash, ScriptHash, WitnessV0ScriptHash, WitnessV0KeyHash, WitnessUnknown> const&) src/script/standard.cpp:325 NEW_FUNC[19/24]: 0x55ec8b36fe40 in DecodeBase58(char const*, std::vector<unsigned char, std::allocator<unsigned char> >&) src/base58.cpp:36 stat::number_of_executed_units: 54900 stat::average_exec_per_sec: 4990 stat::new_units_added: 421 stat::slowest_unit_time_sec: 0 stat::peak_rss_mb: 412 Number of unique code paths taken during fuzzing round: 93 Tested fuzz harnesses seem to work as expected. ``` Top commit has no ACKs. Tree-SHA512: f18d0a6798c55d2c85ef9e604af2c1d626da2b81c01ea3f77c5cecd4ce35b197030778b3cfebab4869dab84a022325dba94fd83290026bfbc59814938e1daa02		5 years ago
..
bench	refactor: test/bench: dedup Build{Crediting,Spending}Transaction()	5 years ago
compat	build: Fix #include sys/poll.h to just poll.h (without sys/)	5 years ago
config	…
consensus	Remove unused includes	5 years ago
crypto	Remove unused includes	5 years ago
index	Remove unused includes	5 years ago
interfaces	Merge #17070: wallet: Avoid showing GUI popups on RPC errors	5 years ago
leveldb	Pull leveldb subtree	6 years ago
node	Remove unused includes	5 years ago
policy	Remove unused includes	5 years ago
primitives	Remove unused includes	5 years ago
qt	Merge #17180: gui: Improved tooltip for send amount field	5 years ago
rpc	Merge #17119: doc: Fix broken bitcoin-cli examples	5 years ago
script	Merge #16889: Add some general std::vector utility functions	5 years ago
secp256k1	Update the secp256k1 subtree to the latest upstream version	6 years ago
support	Improve documentation of memory_cleanse()	5 years ago
test	Merge #17018: tests: Add descriptor Parse(...) fuzzing harness	5 years ago
univalue	Update univalue subtree	6 years ago
util	Merge #17184: util: Filter out macOS process serial number	5 years ago
wallet	Merge #16911: wallet: Only check the hash of transactions loaded from disk	5 years ago
zmq	Remove unused includes	5 years ago
.clang-format	util: Add AllowShortCaseLabelsOnASingleLine option	5 years ago
Makefile.am	Add some general std::vector utility functions	5 years ago
Makefile.bench.include	refactor: test/bench: dedup Build{Crediting,Spending}Transaction()	5 years ago
Makefile.leveldb.include	build: Remove WINVER pre define in Makefile.leveldb.inlcude	6 years ago
Makefile.qt.include	Always generate `bitcoinstrings.cpp` on `make translate`	5 years ago
Makefile.qt_locale.include	qt: Periodic translations update	5 years ago
Makefile.qttest.include	scripted-diff: Rename test_bitcoin to test/setup_common	6 years ago
Makefile.test.include	Merge #17018: tests: Add descriptor Parse(...) fuzzing harness	5 years ago
addrdb.cpp	addrdb: Remove temporary files created in SerializeFileDB. Fixes non-determinism in unit tests.	5 years ago
addrdb.h	banman: Add, use CBanEntry ctor that takes ban reason	6 years ago
addrman.cpp	Make reasoning about dependencies easier by not including unused dependencies	6 years ago
addrman.h	[addrman] Ensure collisions eventually get resolved	6 years ago
amount.h	Update copyright headers to 2018	6 years ago
arith_uint256.cpp	Remove unused includes	5 years ago
arith_uint256.h	Remove unused includes	5 years ago
attributes.h	Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes.	6 years ago
banman.cpp	scripted-diff: Make translation bilingual	5 years ago
banman.h	Allow connections from misbehavior banned peers.	6 years ago
base58.cpp	scripted-diff: Move util files to separate directory.	6 years ago
base58.h	Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes.	6 years ago
bech32.cpp	Add some general std::vector utility functions	5 years ago
bech32.h	Assert that the HRP is lowercase in Bech32::Encode	5 years ago
bitcoin-cli-res.rc	…
bitcoin-cli.cpp	Merge #16659: refactoring: Remove unused includes	5 years ago
bitcoin-tx-res.rc	…
bitcoin-tx.cpp	Remove unused includes	5 years ago
bitcoin-wallet-res.rc	[tools] Add wallet inspection and modification tool	6 years ago
bitcoin-wallet.cpp	Remove unused includes	5 years ago
bitcoind-res.rc	…
bitcoind.cpp	Remove unused includes	5 years ago
blockencodings.cpp	CorruptionPossible -> BLOCK_MUTATED	6 years ago
blockencodings.h	Remove unused includes	5 years ago
blockfilter.cpp	init: Add CLI option to enable block filter index.	6 years ago
blockfilter.h	init: Add CLI option to enable block filter index.	6 years ago
bloom.cpp	refactor: Improve CRollingBloomFilter::reset by using std::fill	6 years ago
bloom.h	Removes unsed `CBloomFilter` constructor.	6 years ago
chain.cpp	refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight	6 years ago
chain.h	chain: Set all CBlockIndex members to null, remove SetNull helper	5 years ago
chainparams.cpp	chainparams: Bump assumed chain params	5 years ago
chainparams.h	Remove wallet settings from chainparams	5 years ago
chainparamsbase.cpp	Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest	5 years ago
chainparamsbase.h	Remove wallet settings from chainparams	5 years ago
chainparamsseeds.h	contrib: Remove invalid nodes from seeds list	5 years ago
checkqueue.h	Update copyright headers to 2018	6 years ago
clientversion.cpp	Update copyright headers to 2018	6 years ago
clientversion.h	Update copyright headers to 2018	6 years ago
coins.cpp	move-onlyish: move CCoinsViewErrorCatcher out of init.cpp	5 years ago
coins.h	make SaltedOutpointHasher noexcept	5 years ago
compat.h	windows: Set _WIN32_WINNT to 0x0601 (Windows 7)	6 years ago
compressor.cpp	Remove unused includes	5 years ago
compressor.h	Update copyright headers to 2018	6 years ago
core_io.h	Move PSBT decoding functions from core_io to psbt.cpp	6 years ago
core_memusage.h	Update copyright headers to 2018	6 years ago
core_read.cpp	Include core_io.h from core_read.cpp	6 years ago
core_write.cpp	Don't show addresses or P2PK in decoderawtransaction	5 years ago
cuckoocache.h	Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.	6 years ago
dbwrapper.cpp	Replace deprecated Boost Filesystem function	6 years ago
dbwrapper.h	Remove unused includes	5 years ago
dummywallet.cpp	Remove unused includes	5 years ago
flatfile.cpp	Style cleanup.	6 years ago
flatfile.h	Style cleanup.	6 years ago
fs.cpp	Avoid redefine warning	6 years ago
fs.h	Replace deprecated Boost Filesystem function	6 years ago
hash.cpp	Extract CSipHasher to it's own file in crypto/ directory.	6 years ago
hash.h	Squashed 'src/secp256k1/' changes from 0b70241850..b19c000063	6 years ago
httprpc.cpp	Remove unused includes	5 years ago
httprpc.h	Remove unused includes	5 years ago
httpserver.cpp	Remove unused includes	5 years ago
httpserver.h	Remove unused includes	5 years ago
indirectmap.h	…
init.cpp	p2p: Remove BIP61 reject messages	5 years ago
init.h	Pass chain and client variables where needed	6 years ago
key.cpp	Make reasoning about dependencies easier by not including unused dependencies	6 years ago
key.h	CKey: add method to negate the key	6 years ago
key_io.cpp	Remove unused includes	5 years ago
key_io.h	Update copyright headers to 2018	6 years ago
limitedmap.h	Update copyright headers to 2018	6 years ago
logging.cpp	util: Filter control characters out of log messages	5 years ago
logging.h	test: Log to debug.log in all tests	5 years ago
memusage.h	Update copyright headers to 2018	6 years ago
merkleblock.cpp	Make reasoning about dependencies easier by not including unused dependencies	6 years ago
merkleblock.h	Update copyright headers to 2018	6 years ago
miner.cpp	Remove unused includes	5 years ago
miner.h	[rpc] mining: Omit uninitialized currentblockweight, currentblocktx	6 years ago
net.cpp	Remove unused includes	5 years ago
net.h	txmempool: Make entry time type-safe (std::chrono)	5 years ago
net_permissions.cpp	util: Move ResolveErrMsg to util/error	5 years ago
net_permissions.h	Make whitebind/whitelist permissions more flexible	5 years ago
net_processing.cpp	Remove unused includes	5 years ago
net_processing.h	p2p: Remove BIP61 reject messages	5 years ago
netaddress.cpp	Fix spelling errors identified by codespell 1.15.0	5 years ago
netaddress.h	Remove unused includes	5 years ago
netbase.cpp	util: refactor upper/lowercase functions	5 years ago
netbase.h	util: refactor upper/lowercase functions	5 years ago
netmessagemaker.h	Update copyright headers to 2018	6 years ago
noui.cpp	Remove unused includes	5 years ago
noui.h	Suppress output in test_bitcoin for expected errors	5 years ago
optional.h	Remove 'boost::optional'-related gcc warnings	6 years ago
outputtype.cpp	Add some general std::vector utility functions	5 years ago
outputtype.h	Move various SigningProviders to signingprovider.{cpp,h}	5 years ago
pow.cpp	Update copyright headers to 2018	6 years ago
pow.h	Update copyright headers to 2018	6 years ago
prevector.h	Remove unused includes	5 years ago
protocol.cpp	p2p: Remove BIP61 reject messages	5 years ago
protocol.h	Remove unused includes	5 years ago
psbt.cpp	Remove unused includes	5 years ago
psbt.h	Fix bug where duplicate PSBT keys are accepted	5 years ago
pubkey.cpp	Update copyright headers to 2018	6 years ago
pubkey.h	Update copyright headers to 2018	6 years ago
random.cpp	random: remove call to RAND_screen() (Windows only)	5 years ago
random.h	net: Use mockable time for tx download	5 years ago
rest.cpp	Remove unused includes	5 years ago
reverse_iterator.h	scripted-diff: Remove trailing whitespaces	6 years ago
reverselock.h	…
scheduler.cpp	Switch all RNG code to the built-in PRNG.	6 years ago
scheduler.h	trivial: correct parameter name in comments	6 years ago
serialize.h	Remove unused includes	5 years ago
shutdown.cpp	…
shutdown.h	…
span.h	Add more methods to Span class	6 years ago
streams.h	Remove unused includes	5 years ago
sync.cpp	Remove unused includes	5 years ago
sync.h	refactor: consolidate PASTE macros	5 years ago
threadinterrupt.cpp	Merge #11640: Make LOCK, LOCK2, TRY_LOCK work with CWaitableCriticalSection	6 years ago
threadinterrupt.h	Remove unused includes	5 years ago
threadsafety.h	Move LockAnnotation from threadsafety.h (imported code) to sync.h (our code)	6 years ago
timedata.cpp	scripted-diff: Make translation bilingual	5 years ago
timedata.h	Update copyright headers to 2018	6 years ago
tinyformat.h	tinyformat: Add doc to Bitcoin Core specific strprintf	5 years ago
torcontrol.cpp	fix: tor: Call event_base_loopbreak from the event's callback	5 years ago
torcontrol.h	Remove unused includes	5 years ago
txdb.cpp	Add some general std::vector utility functions	5 years ago
txdb.h	Remove unused includes	5 years ago
txmempool.cpp	feefilter: Compute the absolute fee rather than stored rate to match mempool acceptance logic	5 years ago
txmempool.h	Remove unused includes	5 years ago
ui_interface.cpp	Merge #16092: Don't use global (external) symbols for symbols that are used in only one translation unit	5 years ago
ui_interface.h	Remove unused includes	5 years ago
uint256.cpp	Remove unused includes	5 years ago
uint256.h	Remove unused includes	5 years ago
undo.h	Extract CSipHasher to it's own file in crypto/ directory.	6 years ago
validation.cpp	Remove unused includes	5 years ago
validation.h	Remove unused includes	5 years ago
validationinterface.cpp	Remove unused includes	5 years ago
validationinterface.h	Remove extra CBlockIndex declaration	5 years ago
version.h	Update copyright headers to 2018	6 years ago
versionbits.cpp	doc: Improve versionbits.h documentation	5 years ago
versionbits.h	doc: Improve versionbits.h documentation	5 years ago
versionbitsinfo.cpp	[Consensus] Bury segwit deployment	5 years ago
versionbitsinfo.h	MOVEONLY: Move versionbits info out of versionbits.o	6 years ago
walletinitinterface.h	refactor: Cleanup walletinitinterface.h	5 years ago
warnings.cpp	scripted-diff: Make translation bilingual	5 years ago
warnings.h	Remove unused includes	5 years ago