You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
litecoin/test/functional
João Barbosa d3bf3b930d
qa: Test .walletlock file is closed
6 years ago
..
data test: add invalid tx templates for use in functional tests 6 years ago
test_framework tests: unify RPC argument to cli argument conversion and handle dicts and lists 6 years ago
.gitignore
README.md Docs: Update python docs to reflect that wildcard imports are disallowed 6 years ago
combine_logs.py tests: have combine_logs default to most recent test dir 6 years ago
combined_log_template.html
create_cache.py Update copyright headers to 2018 6 years ago
example_test.py Docs: Update python docs to reflect that wildcard imports are disallowed 6 years ago
feature_assumevalid.py Increase timeout of featuer_assumevalid test to fix flaky tests 6 years ago
feature_bip68_sequence.py qa: Run all tests even if wallet is not compiled 6 years ago
feature_block.py Merge #15059: test: Add basic test for BIP34 6 years ago
feature_blocksdir.py Improve blocksdir functional test. 6 years ago
feature_cltv.py tests: Remove unused testing code 6 years ago
feature_config_args.py Error if rpcpassword contains hash in conf sections 6 years ago
feature_csv_activation.py Merge #14180: qa: Run all tests even if wallet is not compiled 6 years ago
feature_dbcrash.py scripted-diff: Rename rpc_timewait to rpc_timeout 6 years ago
feature_dersig.py tests: Remove unused testing code 6 years ago
feature_fee_estimation.py [tests] Move deterministic address import to setup_nodes 6 years ago
feature_filelock.py utils: Fix broken Windows filelock 6 years ago
feature_help.py qa: Raise feature_help timeout to 5s 6 years ago
feature_includeconf.py Ignore unknown config file options for now 6 years ago
feature_logging.py Changed functional tests which do not require wallets to run without 6 years ago
feature_maxuploadtarget.py qa: Run all tests even if wallet is not compiled 6 years ago
feature_minchainwork.py Changed functional tests which do not require wallets to run without 6 years ago
feature_notifications.py tests: Stop node before removing the notification file 6 years ago
feature_nulldummy.py [tests] Remove deprecated addwitnessaddress call from feature_nulldummy 6 years ago
feature_proxy.py Update copyright headers to 2018 6 years ago
feature_pruning.py Correct units for "-dbcache" and "-prune" 6 years ago
feature_rbf.py qa: Run all tests even if wallet is not compiled 6 years ago
feature_reindex.py Changed functional tests which do not require wallets to run without 6 years ago
feature_segwit.py [RPC] Update getrawtransaction interface 6 years ago
feature_shutdown.py qa: Remove race between connecting and shutdown on separate connections 6 years ago
feature_uacomment.py utils: Convert Windows args to utf-8 string 6 years ago
feature_versionbits_warning.py Changed functional tests which do not require wallets to run without 6 years ago
interface_bitcoin_cli.py Fix typo 6 years ago
interface_http.py Compare to None with is/is not 6 years ago
interface_rest.py Merge #15159: [RPC] Remove lookup to UTXO set from GetTransaction 6 years ago
interface_rpc.py qa: Add tests for getrpcinfo 6 years ago
interface_zmq.py Merge #14060: ZMQ: add options to configure outbound message high water mark, aka SNDHWM 6 years ago
mempool_accept.py Update copyright headers to 2018 6 years ago
mempool_limit.py qa: Run all tests even if wallet is not compiled 6 years ago
mempool_packages.py qa: Run all tests even if wallet is not compiled 6 years ago
mempool_persist.py test: mempool_persist: Verify prioritization is dumped correctly 6 years ago
mempool_reorg.py qa: Run all tests even if wallet is not compiled 6 years ago
mempool_resurrect.py Tests: Fix a comment 6 years ago
mempool_spend_coinbase.py qa: Run all tests even if wallet is not compiled 6 years ago
mining_basic.py [mining] segwit option must be set in GBT 6 years ago
mining_getblocktemplate_longpoll.py [mining] segwit option must be set in GBT 6 years ago
mining_prioritisetransaction.py Merge #14811: Mining: Enforce that segwit option must be set in GBT 6 years ago
p2p_compactblocks.py Merge #14296: [wallet] Remove addwitnessaddress 6 years ago
p2p_disconnect_ban.py rpc: Correctly name arguments 6 years ago
p2p_feefilter.py qa: Run all tests even if wallet is not compiled 6 years ago
p2p_fingerprint.py Changed functional tests which do not require wallets to run without 6 years ago
p2p_invalid_block.py qa: Avoid race in p2p_invalid_block by waiting for the block request 6 years ago
p2p_invalid_locator.py Update copyright headers to 2018 6 years ago
p2p_invalid_messages.py test: Fix race in p2p_invalid_messages 6 years ago
p2p_invalid_tx.py test: add invalid tx templates for use in functional tests 6 years ago
p2p_leak.py Changed functional tests which do not require wallets to run without 6 years ago
p2p_leak_tx.py [tests] Test that nodes respond to getdata with notfound 6 years ago
p2p_mempool.py tests: Use explicit imports 6 years ago
p2p_node_network_limited.py [tests] Move deterministic address import to setup_nodes 6 years ago
p2p_segwit.py Default -whitelistforcerelay to off 6 years ago
p2p_sendheaders.py Merge #13424: Consistently validate txid / blockhash length and encoding in rpc calls 6 years ago
p2p_timeouts.py test: Avoid racy test p2p_timeouts 6 years ago
p2p_unrequested_blocks.py Changed functional tests which do not require wallets to run without 6 years ago
rpc_bind.py Merge #14790: Tests: Allow running rpc_bind.py --nonloopback test without IPv6 6 years ago
rpc_blockchain.py rpc: Correctly name arguments 6 years ago
rpc_createmultisig.py qa: Run all tests even if wallet is not compiled 6 years ago
rpc_decodescript.py tests: Use explicit imports 6 years ago
rpc_deprecated.py [wallet] Deprecate the generate RPC method 6 years ago
rpc_fundrawtransaction.py scripted-diff: Remove unused 'split' parameter to setup_network 6 years ago
rpc_getblockstats.py rpc: Always throw in getblockstats if -txindex is required 6 years ago
rpc_getchaintips.py Changed functional tests which do not require wallets to run without 6 years ago
rpc_help.py qa: Add test to ensure node can generate all help texts at runtime 6 years ago
rpc_invalidateblock.py [rpc] Correct reconsiderblock help text, add test 6 years ago
rpc_named_arguments.py Update copyright headers to 2018 6 years ago
rpc_net.py test: Fix rpc_net.py "pong" race condition 6 years ago
rpc_preciousblock.py Changed functional tests which do not require wallets to run without 6 years ago
rpc_psbt.py [RPC] Update getrawtransaction interface 6 years ago
rpc_rawtransaction.py [RPC] Update getrawtransaction interface 6 years ago
rpc_scantxoutset.py Add matching descriptors to scantxoutset output + tests 6 years ago
rpc_signmessage.py qa: Run all tests even if wallet is not compiled 6 years ago
rpc_signrawtransaction.py [wallet] remove redundand restart node 6 years ago
rpc_txoutproof.py Merge #13424: Consistently validate txid / blockhash length and encoding in rpc calls 6 years ago
rpc_uptime.py Update copyright headers to 2018 6 years ago
rpc_users.py Merge #13867: qa: Make extended tests pass on native Windows 6 years ago
test_runner.py [tests] Add wallet-tool test 6 years ago
tool_wallet.py [tests] Add wallet-tool test 6 years ago
wallet_abandonconflict.py Merge #15247: qa: Use wallet to retrieve raw transactions 6 years ago
wallet_address_types.py Add descriptors to listunspent and getaddressinfo + tests 6 years ago
wallet_backup.py scripted-diff: Remove unused 'split' parameter to setup_network 6 years ago
wallet_balance.py [tests] Add wallet_balance.py 6 years ago
wallet_basic.py Merge #15247: qa: Use wallet to retrieve raw transactions 6 years ago
wallet_bumpfee.py [test] Remove deprecated addwitnessaddress from wallet_bumpfee.py 6 years ago
wallet_coinbase_category.py Test coinbase category in wallet rpcs 6 years ago
wallet_create_tx.py wallet: Avoid leaking locktime fingerprint when anti-fee-sniping 6 years ago
wallet_disable.py tests: Use explicit imports 6 years ago
wallet_disableprivatekeys.py Do not import private keys to wallets with private keys disabled 6 years ago
wallet_dump.py scripted-diff: Remove unused 'split' parameter to setup_network 6 years ago
wallet_encryption.py qa: Add wallet_encryption error tests 6 years ago
wallet_fallbackfee.py qa: Run all tests even if wallet is not compiled 6 years ago
wallet_groups.py scripted-diff: Rename rpc_timewait to rpc_timeout 6 years ago
wallet_hd.py [wallet] Remove -usehd 6 years ago
wallet_import_rescan.py [wallet] Restore ability to list incoming transactions by label 6 years ago
wallet_import_with_label.py [tests] move wallet util functions to wallet_util.py 6 years ago
wallet_importmulti.py [tests] move wallet util functions to wallet_util.py 6 years ago
wallet_importprunedfunds.py rpc: Correctly name arguments 6 years ago
wallet_keypool.py [tests] Small fixups before deprecating generate 6 years ago
wallet_keypool_topup.py wallet_keypool_topup.py: Test for all keypool address types 6 years ago
wallet_labels.py [tests] Small fixups before deprecating generate 6 years ago
wallet_listreceivedby.py [tests] Move deterministic address import to setup_nodes 6 years ago
wallet_listsinceblock.py Merge #13424: Consistently validate txid / blockhash length and encoding in rpc calls 6 years ago
wallet_listtransactions.py Fix running individually through test_runner.py, as suggested by @MarcoFalke (#14732) 6 years ago
wallet_multiwallet.py qa: Test .walletlock file is closed 6 years ago
wallet_resendwallettransactions.py qa: Run all tests even if wallet is not compiled 6 years ago
wallet_txn_clone.py [test] wallet_txn_clone: Correctly clone txin sequence 6 years ago
wallet_txn_doublespend.py qa: Run all tests even if wallet is not compiled 6 years ago
wallet_zapwallettxes.py qa: Run all tests even if wallet is not compiled 6 years ago

README.md

Functional tests

Writing Functional Tests

Example test

The example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The Travis linter also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramwork, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use '{}'.format(x) for string formatting, not '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel or on Travis).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x50=1250 BTC) in its wallet.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • messages.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

  • Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are p2p_unrequested_blocks.py, p2p_compactblocks.py.

test-framework modules

test_framework/authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework/test_framework.py

Base class for functional tests.

test_framework/util.py

Generally useful functions.

test_framework/mininode.py

Basic code to support P2P connectivity to a bitcoind.

test_framework/script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

test_framework/key.py

Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)

test_framework/bignum.py

Helpers for script.py

test_framework/blocktools.py

Helper functions for creating blocks and transactions.