You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
litecoin/test/functional
John Newbery a533834d50
[tests] Fix flake8 warnings in several wallet functional tests
7 years ago
..
test_framework Merge #13003: qa: Add test for orphan handling 7 years ago
.gitignore
README.md [tests] Remove Comparison Test Framework 7 years ago
combine_logs.py Format timestamps using ISO 8601 formatting (e.g. "2018-02-28T12:34:56Z") 7 years ago
combined_log_template.html
create_cache.py
example_test.py Fix typos 7 years ago
feature_assumevalid.py
feature_bip68_sequence.py Minor Python cleanups to make flake8 pass with the new rules enabled 7 years ago
feature_block.py Merge #13003: qa: Add test for orphan handling 7 years ago
feature_blocksdir.py qa: Match full plain text by default 7 years ago
feature_cltv.py
feature_config_args.py [tests] Use regtest section in functional tests configs 7 years ago
feature_csv_activation.py [tests] Change feature_csv_activation.py to use BitcoinTestFramework 7 years ago
feature_dbcrash.py
feature_dersig.py
feature_fee_estimation.py [Tests] Use blockmaxweight where tests previously had blockmaxsize 7 years ago
feature_help.py [qa] Ensure bitcoind processes are cleaned up when tests end 7 years ago
feature_logging.py Print to console by default when not run with -daemon 7 years ago
feature_maxuploadtarget.py Minor Python cleanups to make flake8 pass with the new rules enabled 7 years ago
feature_minchainwork.py
feature_notifications.py qa: Windows fixups for functional tests 7 years ago
feature_nulldummy.py
feature_proxy.py Minor Python cleanups to make flake8 pass with the new rules enabled 7 years ago
feature_pruning.py Remove Safe mode 7 years ago
feature_rbf.py
feature_reindex.py test: Use wait_until in tests where time was used for polling 7 years ago
feature_segwit.py Merge #13002: Do not treat bare multisig outputs as IsMine unless watched 7 years ago
feature_uacomment.py qa: Match full plain text by default 7 years ago
feature_versionbits_warning.py
interface_bitcoin_cli.py tests: Test connecting with non-existing RPC cookie file 7 years ago
interface_http.py
interface_rest.py Minor Python cleanups to make flake8 pass with the new rules enabled 7 years ago
interface_zmq.py qa: Normalize executable location 7 years ago
mempool_accept.py rpc: Add testmempoolaccept 7 years ago
mempool_limit.py
mempool_packages.py Add new fee structure with all sub-fields denominated in BTC 7 years ago
mempool_persist.py qa: Windows fixups for functional tests 7 years ago
mempool_reorg.py
mempool_resurrect.py
mempool_spend_coinbase.py
mining_basic.py
mining_getblocktemplate_longpoll.py
mining_prioritisetransaction.py Don't test against min relay fee information in mining_prioritisetransaction.py 7 years ago
p2p_compactblocks.py Merge #12716: Fix typos and cleanup in various files 7 years ago
p2p_disconnect_ban.py
p2p_feefilter.py scripted-diff: rename TestNode to TestP2PConn in tests 7 years ago
p2p_fingerprint.py
p2p_invalid_block.py
p2p_invalid_tx.py qa: Add test for orphan handling 7 years ago
p2p_leak.py Fix typos 7 years ago
p2p_mempool.py Minor Python cleanups to make flake8 pass with the new rules enabled 7 years ago
p2p_node_network_limited.py Fix typos 7 years ago
p2p_segwit.py Merge #11739: Enforce SCRIPT_VERIFY_P2SH and SCRIPT_VERIFY_WITNESS from genesis 7 years ago
p2p_sendheaders.py Adding logging for loop iteration level in p2p_sendheaders.py 7 years ago
p2p_timeouts.py scripted-diff: rename TestNode to TestP2PConn in tests 7 years ago
p2p_unrequested_blocks.py qa: Normalize executable location 7 years ago
rpc_bind.py test: Add rpc_bind test to default-run tests 7 years ago
rpc_blockchain.py Merge #12431: Only call NotifyBlockTip when chainActive changes 7 years ago
rpc_decodescript.py
rpc_deprecated.py [tests] Fix race in rpc_deprecated.py 7 years ago
rpc_fundrawtransaction.py
rpc_getchaintips.py
rpc_invalidateblock.py
rpc_named_arguments.py
rpc_net.py [tests] Fix intermittent rpc_net.py failure. 7 years ago
rpc_preciousblock.py [qa] util: Remove unused sync_chain 7 years ago
rpc_rawtransaction.py Merge #12436: [rpc] Adds a functional test to validate the transaction version number in the RPC output 7 years ago
rpc_signmessage.py
rpc_signrawtransaction.py
rpc_txoutproof.py
rpc_uptime.py
rpc_users.py test: Add rpcauth pair that generated by rpcauth 7 years ago
test_runner.py Add --failfast option to functional test runner 7 years ago
wallet_abandonconflict.py Fix typos 7 years ago
wallet_address_types.py
wallet_backup.py qa: Use node.datadir instead of tmpdir in test framework 7 years ago
wallet_basic.py [tests] Fix flake8 warnings in several wallet functional tests 7 years ago
wallet_bumpfee.py Merge #12749: [wallet] feebumper: discard change outputs below discard rate 7 years ago
wallet_disable.py
wallet_dump.py Merge #12627: qa: Fix some tests to work on native windows 7 years ago
wallet_encryption.py [rpcwallet] Clamp walletpassphrase value at 100M seconds 7 years ago
wallet_fallbackfee.py
wallet_hd.py speed up wallet_hd.py and clarify/augment checks 7 years ago
wallet_import_rescan.py [tests] Fix flake8 warnings in several wallet functional tests 7 years ago
wallet_importmulti.py Remove assigned but never used local variables 7 years ago
wallet_importprunedfunds.py [tests] Fix flake8 warnings in several wallet functional tests 7 years ago
wallet_keypool.py Minor Python cleanups to make flake8 pass with the new rules enabled 7 years ago
wallet_keypool_topup.py [tests] Set -deprecatedrpc=accounts in tests 7 years ago
wallet_labels.py [wallet] [tests] Add tests for accounts/labels APIs 7 years ago
wallet_listreceivedby.py [tests] Fix flake8 warnings in several wallet functional tests 7 years ago
wallet_listsinceblock.py [tests] Fix flake8 warnings in several wallet functional tests 7 years ago
wallet_listtransactions.py [tests] Fix flake8 warnings in several wallet functional tests 7 years ago
wallet_multiwallet.py Merge #12909: wallet: Make fee settings to be non-static members 7 years ago
wallet_resendwallettransactions.py
wallet_txn_clone.py [tests] Fix flake8 warnings in several wallet functional tests 7 years ago
wallet_txn_doublespend.py [tests] Fix flake8 warnings in several wallet functional tests 7 years ago
wallet_zapwallettxes.py

README.md

Functional tests

Writing Functional Tests

Example test

The example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • Avoid wildcard imports where possible
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramwork, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel or on Travis).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x50=1250 BTC) in its wallet.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • mininode.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested (using python's asyncore package); the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

  • Call network_thread_start() after all P2PInterface objects are created to start the networking thread. (Continue with the test logic in your existing thread.)

  • Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are p2p_unrequested_blocks.py, p2p_compactblocks.py.

test-framework modules

test_framework/authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework/test_framework.py

Base class for functional tests.

test_framework/util.py

Generally useful functions.

test_framework/mininode.py

Basic code to support P2P connectivity to a bitcoind.

test_framework/script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

test_framework/key.py

Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)

test_framework/bignum.py

Helpers for script.py

test_framework/blocktools.py

Helper functions for creating blocks and transactions.