History

Jonas Schnelli 73a6bac9ff Merge #15196 : [test]: Update all subprocess.check_output functions to be Python 3.4 compatible `fdf82ba18` Update all subprocess.check_output functions in CI scripts to be Python 3.4 compatible (Graham Krizek) Pull request description: CI is failing the `lint` stage on every Cron run (regular PR/Push runs still pass). The failure was introduced in `74ce326` and has been broken since. The Python version running in CI was downgraded to 3.4 from 3.6. There were a couple files that were using the `encoding` argument in the `subprocess.check_output` function. This was introduced in Python 3.6 and therefore broke the scripts that were using it. The `universal_newlines` argument was used as well, but in order to use it we must be able to set encoding because of issues on some BSD systems. To get CI to pass, I removed all `universal_newline` and `encoding` args to the `check_ouput` function. Then I decoded all `check_output` return values. This should keep the same behavior but be Python 3.4 compatible. Tree-SHA512: f5e5885e98cf4777be9cc254446a873eedb03bdccbd8e06772a964db95e9fcf46736aa9cdcab1d8f123ea9f4947ed6020679898d8b2f47ffb1d94c21a4b08209		6 years ago
..
README.md	…
check-doc.py	Update all subprocess.check_output functions in CI scripts to be Python 3.4 compatible	6 years ago
check-rpc-mappings.py	Merge #13707 : tests: Add usage note to check-rpc-mappings.py	6 years ago
commit-script-check.sh	scripted-diff: Run scripted-diff in subshell	6 years ago
git-subtree-check.sh	…
lint-all.sh	…
lint-assertions.sh	Add regression test: Don't assert(...) with side effects	6 years ago
lint-circular-dependencies.sh	Merge #14350 : Add WalletLocation class	6 years ago
lint-filenames.sh	…
lint-format-strings.py	lint/format-strings: Correctly exclude escaped percent symbols	6 years ago
lint-format-strings.sh	Fix warnings introduced in shellcheck v0.6.0	6 years ago
lint-include-guards.sh	…
lint-includes.sh	scripted-diff: Replace boost::bind with std::bind	6 years ago
lint-locale-dependence.sh	Update KNOWN_VIOLATIONS: Remove fixed violations	6 years ago
lint-logs.sh	…
lint-python-dead-code.sh	Merge #14457 : test: add invalid tx templates for use in functional tests	6 years ago
lint-python-utf8-encoding.sh	lint: Make sure we read the command line inputs using utf-8 decoding in python	6 years ago
lint-python.sh	lint: Enable python linters via an array	6 years ago
lint-qt.sh	test: Add lint to prevent SIGNAL/SLOT connect style	6 years ago
lint-rpc-help.sh	rpc: Documentation fixups	6 years ago
lint-shebang.sh	Scripts and tools & Docs: Used #!/usr/bin/env bash instead of obsolete #!/bin/bash, added linting for .sh files shebang and updated the Developer Notes.	6 years ago
lint-shell-locale.sh	macOS fix: Work around empty (sub)expression error when using BSD grep	6 years ago
lint-shell.sh	Remove no longer needed shellcheck suppressions	6 years ago
lint-spelling.ignore-words.txt	Add ignored word: mut	6 years ago
lint-spelling.sh	Revert "qa: Fix codespell error and have lint-spelling error instead of warn"	6 years ago
lint-tests.sh	…
lint-whitespace.sh	Fix warnings introduced in shellcheck v0.6.0	6 years ago

README.md

This folder contains lint scripts.

check-doc.py

Check for missing documentation of command line options.

commit-script-check.sh

Verification of scripted diffs.

git-subtree-check.sh

Run this script from the root of the repository to verify that a subtree matches the contents of the commit it claims to have been updated to.

To use, make sure that you have fetched the upstream repository branch in which the subtree is maintained:

for src/secp256k1: https://github.com/bitcoin-core/secp256k1.git (branch master)
for src/leveldb: https://github.com/bitcoin-core/leveldb.git (branch bitcoin-fork)
for src/univalue: https://github.com/bitcoin-core/univalue.git (branch master)
for src/crypto/ctaes: https://github.com/bitcoin-core/ctaes.git (branch master)

Usage: git-subtree-check.sh DIR (COMMIT)

COMMIT may be omitted, in which case HEAD is used.

lint-all.sh

Calls other scripts with the lint- prefix.