You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
litecoin/test/functional
Andrew Chow 9a4c631e1c
Update wallet_labels.py to not require descriptors=False
4 years ago
..
data This PR adds initial support for type hints checking in python scripts. 5 years ago
test_framework tests: Add a --legacy-wallet that is mutually exclusive with --descriptors 4 years ago
.gitignore
README.md [doc] sample code for test framework p2p objects 4 years ago
combine_logs.py
combined_log_template.html
create_cache.py
example_test.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
feature_abortnode.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
feature_asmap.py
feature_assumevalid.py scripted-diff: Rename mininode to p2p 4 years ago
feature_backwards_compatibility.py test: Get rid of default wallet hacks 4 years ago
feature_bip68_sequence.py Merge #19401: QA: Use GBT to get block versions correct 4 years ago
feature_block.py test: Default blockversion to 4 in feature_block 4 years ago
feature_blocksdir.py
feature_cltv.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
feature_config_args.py wallet: Make -wallet setting not create wallets 4 years ago
feature_csv_activation.py test: Remove unused -blockversion from tests 4 years ago
feature_dbcrash.py test: Get rid of default wallet hacks 4 years ago
feature_dersig.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
feature_fee_estimation.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
feature_filelock.py test: Get rid of default wallet hacks 4 years ago
feature_help.py
feature_includeconf.py
feature_loadblock.py test: refactor functional tests to use restart_node 4 years ago
feature_logging.py test: refactor functional tests to use restart_node 4 years ago
feature_maxuploadtarget.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
feature_minchainwork.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
feature_notifications.py Merge #20167: test: Add test for -blockversion 4 years ago
feature_nulldummy.py Use separate watchonly wallet for multisig in feature_nulldummy.py 4 years ago
feature_proxy.py rpc, test: expose CNodeStats network in RPC getpeerinfo 4 years ago
feature_pruning.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
feature_rbf.py refactor: test: use _ variable for unused loop counters 4 years ago
feature_reindex.py test: Fix intermittent sync_blocks failures 5 years ago
feature_segwit.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
feature_settings.py Merge #19624: Warn on unknown rw_settings 4 years ago
feature_shutdown.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
feature_signet.py signet: do not log signet startup messages for other chains 4 years ago
feature_taproot.py tests: dumping and minimizing of script assets data 4 years ago
feature_uacomment.py
feature_versionbits_warning.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
interface_bitcoin_cli.py test, refactor: add default_wallet_name and wallet_data_filename variables 4 years ago
interface_http.py
interface_rest.py
interface_rpc.py Test batch rpc with params 4 years ago
interface_zmq.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
mempool_accept.py Convert amounts from float to decimal 4 years ago
mempool_compatibility.py test: Get rid of default wallet hacks 4 years ago
mempool_expiry.py
mempool_limit.py
mempool_package_onemore.py refactor: test: use _ variable for unused loop counters 4 years ago
mempool_packages.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
mempool_persist.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
mempool_reorg.py
mempool_resurrect.py
mempool_spend_coinbase.py
mempool_unbroadcast.py test: Replace use of (dis)?connect_nodes globals 4 years ago
mempool_updatefromblock.py refactor: test: use _ variable for unused loop counters 4 years ago
mining_basic.py test: Add test for -blockversion 4 years ago
mining_getblocktemplate_longpoll.py test: add logging for mining_getblocktemplate_longpoll.py 4 years ago
mining_prioritisetransaction.py
p2p_addr_relay.py test: resort imports 4 years ago
p2p_addrv2_relay.py net: advertise support for ADDRv2 via new message 4 years ago
p2p_blockfilters.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
p2p_blocksonly.py RPC: getpeerinfo: Deprecate "whitelisted" field (replaced by "permissions") 4 years ago
p2p_compactblocks.py Merge #19401: QA: Use GBT to get block versions correct 4 years ago
p2p_disconnect_ban.py [test] Clarify setup of node topology. 4 years ago
p2p_dos_header_tree.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
p2p_eviction.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
p2p_feefilter.py test: Fix typo (one tx is enough) in p2p_feefilter 4 years ago
p2p_filter.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
p2p_fingerprint.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
p2p_getaddr_caching.py Refactor the functional test 4 years ago
p2p_getdata.py test: use explicit p2p objects where available 4 years ago
p2p_ibd_txrelay.py test: fix intermittent p2p_ibd_txrelay race, add test_framework.py#wait_until 4 years ago
p2p_invalid_block.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
p2p_invalid_locator.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
p2p_invalid_messages.py net: advertise support for ADDRv2 via new message 4 years ago
p2p_invalid_tx.py scripted-diff: replace p2p with p2ps[0] in p2p_invalid_tx 4 years ago
p2p_leak.py test: Remove unused lock arg from BitcoinTestFramework.wait_until 4 years ago
p2p_leak_tx.py test: add p2p_lock acquires in p2p_leak_tx.py 4 years ago
p2p_nobloomfilter_messages.py scripted-diff: Rename mininode to p2p 4 years ago
p2p_node_network_limited.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
p2p_permissions.py [net processing] Don't add AlreadyHave txs to recentRejects 4 years ago
p2p_ping.py scripted-diff: Rename mininode to p2p 4 years ago
p2p_segwit.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
p2p_sendheaders.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
p2p_timeouts.py scripted-diff: Rename mininode to p2p 4 years ago
p2p_tx_download.py Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers 4 years ago
p2p_unrequested_blocks.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
rpc_bind.py
rpc_blockchain.py Activate Taproot/Tapscript on regtest (BIP 341, BIP 342) 4 years ago
rpc_createmultisig.py wallet: Remove path checking code from loadwallet RPC 4 years ago
rpc_decodescript.py
rpc_deprecated.py test, refactor: add default_wallet_name and wallet_data_filename variables 4 years ago
rpc_deriveaddresses.py
rpc_dumptxoutset.py
rpc_estimatefee.py
rpc_fundrawtransaction.py Use a separate watchonly wallet in rpc_fundrawtransaction.py 4 years ago
rpc_generate.py rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining) 4 years ago
rpc_generateblock.py refactor: test: use _ variable for unused loop counters 4 years ago
rpc_getblockfilter.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
rpc_getblockstats.py
rpc_getchaintips.py
rpc_getdescriptorinfo.py test: Get rid of default wallet hacks 4 years ago
rpc_getpeerinfo_deprecation.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
rpc_help.py wallet: Make RPC help compile-time static 4 years ago
rpc_invalidateblock.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
rpc_misc.py test: Add tests for getindexinfo RPC 4 years ago
rpc_named_arguments.py
rpc_net.py [tests] Remove getnettotals/getpeerinfo consistency test 4 years ago
rpc_preciousblock.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
rpc_psbt.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
rpc_rawtransaction.py Make raw multisig tests legacy wallet only in rpc_rawtransaction.py 4 years ago
rpc_scantxoutset.py wallet: Make -wallet setting not create wallets 4 years ago
rpc_setban.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
rpc_signmessage.py
rpc_signrawtransaction.py Avoid dumpprivkey and watchonly behavior in rpc_signrawtransaction.py 4 years ago
rpc_txoutproof.py test: gettxoutproof duplicate txid 4 years ago
rpc_uptime.py
rpc_users.py http: Avoid crash when g_thread_http was never started 5 years ago
rpc_whitelist.py
test-shell.md
test_runner.py tests: Add a --legacy-wallet that is mutually exclusive with --descriptors 4 years ago
tool_wallet.py Disable some tests for tool_wallet when descriptors 4 years ago
wallet_abandonconflict.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
wallet_address_types.py Do addmultisigaddress tests in legacy wallet mode in wallet_address_types.py 4 years ago
wallet_avoidreuse.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
wallet_backup.py wallet: Make -wallet setting not create wallets 4 years ago
wallet_balance.py Move import and watchonly tests to be legacy wallet only in wallet_balance.py 4 years ago
wallet_basic.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
wallet_bumpfee.py Use importdescriptors for descriptor wallets in wallet_bumpfee.py 4 years ago
wallet_coinbase_category.py
wallet_create_tx.py scripted-diff: update max-fee-exceeded error message to include RPC 4 years ago
wallet_createwallet.py Use importdescriptors when in descriptor wallet mode in wallet_createwallet.py 4 years ago
wallet_descriptor.py Ensure a legacy wallet for BDB format check 4 years ago
wallet_disable.py test: Get rid of default wallet hacks 4 years ago
wallet_dump.py wallet: Make -wallet setting not create wallets 4 years ago
wallet_encryption.py test: Fix intermittent failure in wallet_encryption 4 years ago
wallet_fallbackfee.py [rpc] refactor: consolidate sendmany and sendtoaddress code 4 years ago
wallet_groups.py -maxapsfee: follow-up fixes 4 years ago
wallet_hd.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
wallet_implicitsegwit.py
wallet_import_rescan.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
wallet_import_with_label.py
wallet_importdescriptors.py Skip --descriptor tests if sqlite is not compiled 4 years ago
wallet_importmulti.py test, refactor: add default_wallet_name and wallet_data_filename variables 4 years ago
wallet_importprunedfunds.py Update wallet_importprunedfunds to avoid dumpprivkey 4 years ago
wallet_keypool.py test, refactor: add default_wallet_name and wallet_data_filename variables 4 years ago
wallet_keypool_topup.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
wallet_labels.py Update wallet_labels.py to not require descriptors=False 4 years ago
wallet_listreceivedby.py
wallet_listsinceblock.py Avoid dumpprivkey in wallet_listsinceblock.py 4 years ago
wallet_listtransactions.py Make import tests in wallet_listtransactions.py legacy wallet only 4 years ago
wallet_multiwallet.py wallet: Make -wallet setting not create wallets 4 years ago
wallet_reorgsrestore.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
wallet_resendwallettransactions.py test: Speed up wallet_resendwallettransactions test with mockscheduler RPC 4 years ago
wallet_send.py test: Fix intermittent issue in wallet_send 4 years ago
wallet_startup.py Do not create default wallet 4 years ago
wallet_txn_clone.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
wallet_txn_doublespend.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 4 years ago
wallet_upgradewallet.py test: Get rid of default wallet hacks 4 years ago
wallet_watchonly.py

README.md

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The Travis linter also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use '{}'.format(x) for string formatting, not '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x50=1250 BTC) in its wallet.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: