You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

MarcoFalke 1c7be9ab90 Merge #20286: rpc: deprecate `addresses` and `reqSigs` from rpc outputs ... 90ae3d8ca6 doc: Add release notes for -deprecatedrpc=addresses and bitcoin-tx (Michael Dietz) 085b3a7299 rpc: deprecate `addresses` and `reqSigs` from rpc outputs (Michael Dietz) Pull request description: Considering the limited applicability of `reqSigs` and the confusing output of `1` in all cases except bare multisig, the `addresses` and `reqSigs` outputs are removed for all rpc commands. 1) add a new sane "address" field (for outputs that have an identifiable address, which doesn't include bare multisig) 2) with -deprecatedrpc: leave "reqSigs" and "addresses" intact (with all weird/wrong behavior they have now) 3) without -deprecatedrpc: drop "reqSigs" and "addresses" entirely always. Note: Some light refactoring done to allow us to very easily delete a few chunks of code (marked with TODOs) when we remove this deprecated behavior. Using `IsDeprecatedRPCEnabled` in core_write.cpp caused some circular dependencies involving core_io Circular dependencies were caused by rpc/util unnecessarily importing node/coinstats and node/transaction. Really what rpc/util needs are some fundamental type/helper-function definitions. So this was cleaned up to make more sense. This fixes #20102. ACKs for top commit: MarcoFalke: re-ACK 90ae3d8ca6 📢 Tree-SHA512: 8ffb617053b5f4a8b055da17c06711fd19632e0037d71c4c8135e50c8cd7a19163989484e4e0f17a6cc48bd597f04ecbfd609aef54b7d1d1e76a784214fcf72a		4 years ago
..
__init__.py	…
address.py	[tests] Replace bytes literals with hex literals	4 years ago
authproxy.py	test: retry when write to a socket fails on macOS	4 years ago
bdb.py	test: remove unnecessary assignment in bdb	4 years ago
bip340_test_vectors.csv	tests: add BIP340 Schnorr signature support to test framework	4 years ago
blocktools.py	scripted-diff: Bump copyright headers	4 years ago
coverage.py	…
descriptors.py	Output a descriptor in createmultisig and addmultisigaddress	5 years ago
key.py	test: remove unused function xor_bytes	4 years ago
messages.py	Unconditionally check for fRelay field in test framework	4 years ago
muhash.py	test: Change MuHash Python implementation to match cpp version again	4 years ago
netutil.py	doc: Use https URLs where possible	4 years ago
p2p.py	[test] Add P2P_SERVICES to p2p.py	4 years ago
script.py	Correction for VerifyTaprootCommitment comments	4 years ago
script_util.py	scripted-diff: Bump copyright headers	4 years ago
segwit_addr.py	Use Bech32m encoding for v1+ segwit addresses	4 years ago
siphash.py	…
socks5.py	…
test_framework.py	Merge #21200: test: Speed up rpc_blockchain.py by removing miniwallet.generate()	4 years ago
test_node.py	rpc: add external_signer option to createwallet	4 years ago
test_shell.py	…
util.py	rpc: deprecate `addresses` and `reqSigs` from rpc outputs	4 years ago
wallet.py	test: Remove wallet dependency of utxo set hash test	4 years ago
wallet_util.py	[tests] move generate_wif_key to wallet_util.py	4 years ago