You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
litecoin/test/functional
gzhao408 784f757994
[refactor] clarify tests by referencing p2p objects directly
4 years ago
..
data This PR adds initial support for type hints checking in python scripts. 5 years ago
test_framework Merge #19818: p2p: change `CInv::type` from `int` to `uint32_t`, fix UBSan warning 4 years ago
.gitignore
README.md [test] Remove final references to mininode 4 years ago
combine_logs.py scripted-diff: Add missed copyright headers 5 years ago
combined_log_template.html
create_cache.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
example_test.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
feature_abortnode.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
feature_asmap.py init: move asmap code earlier in init process 5 years ago
feature_assumevalid.py scripted-diff: Rename mininode to p2p 4 years ago
feature_backwards_compatibility.py qa: Changes v0.17.1 to v0.17.2 4 years ago
feature_bip68_sequence.py refactor: test: use _ variable for unused loop counters 4 years ago
feature_block.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
feature_blocksdir.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
feature_cltv.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
feature_config_args.py test: Add test coverage for -networkactive option 4 years ago
feature_csv_activation.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
feature_dbcrash.py refactor: test: use _ variable for unused loop counters 4 years ago
feature_dersig.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
feature_fee_estimation.py refactor: test: use _ variable for unused loop counters 4 years ago
feature_filelock.py scripted-diff: Bump copyright headers 5 years ago
feature_help.py scripted-diff: Bump copyright headers 5 years ago
feature_includeconf.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
feature_loadblock.py test: refactor functional tests to use restart_node 4 years ago
feature_logging.py test: refactor functional tests to use restart_node 4 years ago
feature_maxuploadtarget.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
feature_minchainwork.py
feature_notifications.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
feature_nulldummy.py test: Check submitblock return values 5 years ago
feature_proxy.py
feature_pruning.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
feature_rbf.py refactor: test: use _ variable for unused loop counters 4 years ago
feature_reindex.py test: Fix intermittent sync_blocks failures 5 years ago
feature_segwit.py refactor: test: use _ variable for unused loop counters 4 years ago
feature_settings.py Add <datadir>/settings.json persistent settings storage. 4 years ago
feature_shutdown.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
feature_uacomment.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
feature_versionbits_warning.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
interface_bitcoin_cli.py rpc: add missing space in JSON parsing error message, update test 5 years ago
interface_http.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
interface_rest.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
interface_rpc.py scripted-diff: Bump copyright headers 5 years ago
interface_zmq.py Have zmq reorg test cover mempool txns 4 years ago
mempool_accept.py scripted-diff: Bump copyright headers 5 years ago
mempool_compatibility.py qa: Changes v0.17.1 to v0.17.2 4 years ago
mempool_expiry.py add: test that transactions expire from mempool 5 years ago
mempool_limit.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
mempool_package_onemore.py refactor: test: use _ variable for unused loop counters 4 years ago
mempool_packages.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
mempool_persist.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
mempool_reorg.py test: Remove raw-tx byte juggling in mempool_reorg 5 years ago
mempool_resurrect.py
mempool_spend_coinbase.py
mempool_unbroadcast.py scripted-diff: Rename mininode to p2p 4 years ago
mempool_updatefromblock.py refactor: test: use _ variable for unused loop counters 4 years ago
mining_basic.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
mining_getblocktemplate_longpoll.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
mining_prioritisetransaction.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
p2p_addr_relay.py test: resort imports 4 years ago
p2p_blockfilters.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
p2p_blocksonly.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
p2p_compactblocks.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
p2p_disconnect_ban.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
p2p_dos_header_tree.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
p2p_eviction.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
p2p_feefilter.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
p2p_filter.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
p2p_fingerprint.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
p2p_getaddr_caching.py scripted-diff: Rename mininode to p2p 4 years ago
p2p_getdata.py scripted-diff: Rename mininode to p2p 4 years ago
p2p_ibd_txrelay.py test: fix intermittent p2p_ibd_txrelay race, add test_framework.py#wait_until 4 years ago
p2p_invalid_block.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
p2p_invalid_locator.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
p2p_invalid_messages.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
p2p_invalid_tx.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
p2p_leak.py test: Remove unused lock arg from BitcoinTestFramework.wait_until 4 years ago
p2p_leak_tx.py scripted-diff: Rename mininode to p2p 4 years ago
p2p_nobloomfilter_messages.py scripted-diff: Rename mininode to p2p 4 years ago
p2p_node_network_limited.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
p2p_permissions.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
p2p_ping.py scripted-diff: Rename mininode to p2p 4 years ago
p2p_segwit.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
p2p_sendheaders.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
p2p_timeouts.py scripted-diff: Rename mininode to p2p 4 years ago
p2p_tx_download.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
p2p_unrequested_blocks.py scripted-diff: Rename mininode to p2p 4 years ago
rpc_bind.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
rpc_blockchain.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
rpc_createmultisig.py [tests] move generate_wif_key to wallet_util.py 4 years ago
rpc_decodescript.py
rpc_deprecated.py Hide bumpfee's psbt creation behavior behind -deprecatedrpc 4 years ago
rpc_deriveaddresses.py tests: Use a default of supports_cli=True (instead of supports_cli=False) 5 years ago
rpc_dumptxoutset.py scripted-diff: Bump copyright headers 5 years ago
rpc_estimatefee.py scripted-diff: Bump copyright headers 5 years ago
rpc_fundrawtransaction.py refactor: test: use _ variable for unused loop counters 4 years ago
rpc_generate.py rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining) 4 years ago
rpc_generateblock.py refactor: test: use _ variable for unused loop counters 4 years ago
rpc_getblockfilter.py test: move sync_blocks and sync_mempool functions to test_framework.py 4 years ago
rpc_getblockstats.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
rpc_getchaintips.py
rpc_getdescriptorinfo.py qa: Add getdescriptorinfo functional test 5 years ago
rpc_getpeerinfo_banscore_deprecation.py test: getpeerinfo banscore deprecation test 4 years ago
rpc_help.py wallet: Make RPC help compile-time static 4 years ago
rpc_invalidateblock.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
rpc_misc.py test: Add tests for getindexinfo RPC 4 years ago
rpc_named_arguments.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
rpc_net.py test: Update wait_until usage in tests not to use the one from utils 4 years ago
rpc_preciousblock.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
rpc_psbt.py Merge #18244: rpc: fundrawtransaction and walletcreatefundedpsbt also lock manually selected coins 4 years ago
rpc_rawtransaction.py Merge #16525: Dump transaction version as an unsigned integer in RPC/TxToUniv 4 years ago
rpc_scantxoutset.py scripted-diff: Bump copyright headers 5 years ago
rpc_setban.py bump test timeouts so that functional tests run in valgrind 5 years ago
rpc_signmessage.py
rpc_signrawtransaction.py test: ensure OP_1NEGATE satisfies BIP62 minimal push rule 4 years ago
rpc_txoutproof.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
rpc_uptime.py
rpc_users.py http: Avoid crash when g_thread_http was never started 5 years ago
rpc_whitelist.py test: Change filemode of rpc_whitelist.py 5 years ago
test-shell.md
test_runner.py Merge #19105: Add Muhash3072 implementation in Python 4 years ago
tool_wallet.py walletdb: Combine VerifyDatabaseFile and VerifyEnvironment 4 years ago
wallet_abandonconflict.py test: refactor functional tests to use restart_node 4 years ago
wallet_address_types.py scripted-diff: Bump copyright headers 5 years ago
wallet_avoidreuse.py test: refactor functional tests to use restart_node 4 years ago
wallet_backup.py refactor: test: use _ variable for unused loop counters 4 years ago
wallet_balance.py test: move sync_blocks and sync_mempool functions to test_framework.py 4 years ago
wallet_basic.py Merge #19671: wallet: Remove -zapwallettxes 4 years ago
wallet_bumpfee.py test: Fix intermittent issue in wallet_bumpfee 4 years ago
wallet_coinbase_category.py
wallet_create_tx.py refactor: test: use _ variable for unused loop counters 4 years ago
wallet_createwallet.py scripted-diff: Bump copyright headers 5 years ago
wallet_descriptor.py refactor: test: use _ variable for unused loop counters 4 years ago
wallet_disable.py
wallet_dump.py refactor: test: use _ variable for unused loop counters 4 years ago
wallet_encryption.py test: Fix intermittent failure in wallet_encryption 4 years ago
wallet_fallbackfee.py [rpc] refactor: consolidate sendmany and sendtoaddress code 4 years ago
wallet_groups.py -maxapsfee: follow-up fixes 4 years ago
wallet_hd.py test: refactor functional tests to use restart_node 4 years ago
wallet_implicitsegwit.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
wallet_import_rescan.py test: Bump timeout in wallet_import_rescan 5 years ago
wallet_import_with_label.py Merge #17585: rpc: deprecate getaddressinfo label 5 years ago
wallet_importdescriptors.py walletdb: don't reinitialize desc cache with multiple cache entries 4 years ago
wallet_importmulti.py test: Fix intermittent failure in wallet_importmulti 5 years ago
wallet_importprunedfunds.py
wallet_keypool.py Add a --descriptors option to various tests 5 years ago
wallet_keypool_topup.py Add a --descriptors option to various tests 5 years ago
wallet_labels.py refactor: test: use _ variable for unused loop counters 4 years ago
wallet_listreceivedby.py test: remove getaddressinfo label tests 5 years ago
wallet_listsinceblock.py Cap listsinceblock target_confirmations param 4 years ago
wallet_listtransactions.py rpc: Document all aliases for first arg of listtransactions 5 years ago
wallet_multiwallet.py Remove -zapwallettxes 4 years ago
wallet_reorgsrestore.py test: refactor functional tests to use restart_node 4 years ago
wallet_resendwallettransactions.py [refactor] clarify tests by referencing p2p objects directly 4 years ago
wallet_startup.py Add loadwallet and createwallet RPC load_on_startup options 4 years ago
wallet_txn_clone.py test: remove redundant two-way disconnect_nodes calls 5 years ago
wallet_txn_doublespend.py test: remove redundant two-way disconnect_nodes calls 5 years ago
wallet_upgradewallet.py qa: Changes v0.17.1 to v0.17.2 4 years ago
wallet_watchonly.py tests: Use a default of supports_cli=True (instead of supports_cli=False) 5 years ago

README.md

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The Travis linter also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use '{}'.format(x) for string formatting, not '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x50=1250 BTC) in its wallet.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • messages.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

  • Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2p.send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: