History

MarcoFalke 4b1fb50def Merge bitcoin/bitcoin#22528 : refactor: move GetTransaction to node/transaction.cpp `f685a13bef` doc: GetTransaction()/getrawtransaction follow-ups to #22383 (John Newbery) `abc57e1f08` refactor: move `GetTransaction(...)` to node/transaction.cpp (Sebastian Falbesoner) Pull request description: ~This PR is based on #22383, which should be reviewed first~ (merged by now). In [yesterday's PR review club session to PR 22383](https://bitcoincore.reviews/22383), the idea of moving the function `GetTransaction(...)` from src/validation.cpp to src/node/transaction.cpp came up. With this, the circular dependency "index/txindex -> validation -> index/txindex" is removed (see change in `lint-circular-dependencies.sh`). Thanks to jnewbery for suggesting and to sipa for providing historical background. Relevant IRC log: ``` 17:52 <jnewbery> Was anyone surprised that GetTransaction() is in validation.cpp? It seems to me that node/transaction.cpp would be a more appropriate place for it. 17:53 <raj_> jnewbery, +1 17:53 <stickies-v> agreed! 17:54 <glozow> jnewbery ya 17:54 <jnewbery> seems weird that validation would call into txindex. I wonder if we remove this function, then validation would no longer need to #include txindex 17:54 <sipa> GetTransaction predates node/transaction.cpp, and even the generic index framework itself :) 17:55 <sipa> (before 0.8, validation itself used the txindex) 17:55 <jnewbery> (and GetTransaction() seems like a natural sibling to BroadcastTransaction(), which is already in node/transaction.cpp) 17:55 <jnewbery> sipa: right, this is not meant as a criticism of course. Just wondering if we can organize things a bit more rationally now that we have better separation between things. 17:55 <sipa> jnewbery: sure, just providing background 17:56 <sipa> seems very reasonable to move it elsewhere now ``` The commit should be trivial to review with `--color-moved`. ACKs for top commit: jnewbery: Code review ACK `f685a13bef` rajarshimaitra: tACK `f685a13bef` mjdietzx: crACK `f685a13bef` LarryRuane: Code review, test ACK `f685a13bef` Tree-SHA512: 0e844a6ecb1be04c638b55bc4478c2949549a4fcae01c984eee078de74d176fb19d508fc09360a62ad130677bfa7daf703b67870800e55942838d7313246248c		3 years ago
..
README.md	test: Add option to git-subtree-check to do full check, add help	4 years ago
check-doc.py	scripted-diff: Bump copyright headers	4 years ago
commit-script-check.sh	test: Bump shellcheck version	4 years ago
extended-lint-all.sh	scripted-diff: Bump copyright headers	5 years ago
extended-lint-cppcheck.sh	remove unused class util::Ref and its unit test	4 years ago
git-subtree-check.sh	scripted-diff: Bump copyright headers	4 years ago
lint-all.sh	…
lint-assertions.sh	scripted-diff: Bump copyright headers	4 years ago
lint-circular-dependencies.sh	refactor: move `GetTransaction(...)` to node/transaction.cpp	3 years ago
lint-cpp.sh	lint: add C++ code linter	4 years ago
lint-files.py	test: minor fixes & improvements for files linter test	4 years ago
lint-files.sh	test: add new python linter to check file names and permissions	4 years ago
lint-format-strings.py	Refactor: Copy CWallet signals and print function to LegacyScriptPubKeyMan	5 years ago
lint-format-strings.sh	scripted-diff: Bump copyright headers	5 years ago
lint-git-commit-check.sh	ci: Drop Travis-specific way to set COMMIT_RANGE variable	4 years ago
lint-include-guards.sh	multiprocess: Add Ipc interface implementation	4 years ago
lint-includes.sh	Merge #21064 : refactor: use std::shared_mutex & remove Boost Thread	4 years ago
lint-locale-dependence.sh	refactor: Move pruning/reindex/importing globals to blockstorage	4 years ago
lint-logs.sh	scripted-diff: Bump copyright of files changed in 2019	5 years ago
lint-python-dead-code.sh	Re-add dead code detection	4 years ago
lint-python-mutable-default-parameters.sh	…
lint-python-utf8-encoding.sh	scripted-diff: Bump copyright headers	4 years ago
lint-python.sh	lint: Run mypy with --show-error-codes	3 years ago
lint-qt.sh	…
lint-shell-locale.sh	…
lint-shell.sh	ci: Drop Travis-specific workaround for shellcheck	4 years ago
lint-spelling.ignore-words.txt	script, doc: spelling update	3 years ago
lint-spelling.sh	tree-wide: Rename gitian-keys to builder-keys	3 years ago
lint-submodule.sh	ci: Check for submodules	5 years ago
lint-tests.sh	…
lint-whitespace.sh	lint: Skip whitespace lint for guix patches	4 years ago

README.md

This folder contains lint scripts.

check-doc.py

Check for missing documentation of command line options.

commit-script-check.sh

Verification of scripted diffs. Scripted diffs are only assumed to run on the latest LTS release of Ubuntu. Running them on other operating systems might require installing GNU tools, such as GNU sed.

git-subtree-check.sh

Run this script from the root of the repository to verify that a subtree matches the contents of the commit it claims to have been updated to.

Usage: test/lint/git-subtree-check.sh [-r] DIR [COMMIT]
       test/lint/git-subtree-check.sh -?

DIR is the prefix within the repository to check.
COMMIT is the commit to check, if it is not provided, HEAD will be used.
-r checks that subtree commit is present in repository.

To do a full check with -r, make sure that you have fetched the upstream repository branch in which the subtree is maintained:

for src/secp256k1: https://github.com/bitcoin-core/secp256k1.git (branch master)
for src/leveldb: https://github.com/bitcoin-core/leveldb.git (branch bitcoin-fork)
for src/univalue: https://github.com/bitcoin-core/univalue.git (branch master)
for src/crypto/ctaes: https://github.com/bitcoin-core/ctaes.git (branch master)
for src/crc32c: https://github.com/google/crc32c.git (branch master)

To do so, add the upstream repository as remote:

git remote add --fetch secp256k1 https://github.com/bitcoin-core/secp256k1.git

lint-all.sh

Calls other scripts with the lint- prefix.