litecoin

History

MarcoFalke 6af013792f Merge #19315 : [tests] Allow outbound & block-relay-only connections in functional tests. `b4dd2ef800` [test] Test the add_outbound_p2p_connection functionality (Amiti Uttarwar) `602e69e427` [test] P2PBlocksOnly - Test block-relay-only connections. (Amiti Uttarwar) `8bb6beacb1` [test/refactor] P2PBlocksOnly - Extract transaction violation test into helper. (Amiti Uttarwar) `99791e7560` [test/refactor] P2PBlocksOnly - simplify transaction creation using blocktool helper. (Amiti Uttarwar) `3997ab9154` [test] Add test framework support to create outbound connections. (Amiti Uttarwar) `5bc04e8837` [rpc/net] Introduce addconnection to test outbounds & blockrelay (Amiti Uttarwar) Pull request description: The existing functional test framework uses the `addnode` RPC to spin up manual connections between bitcoind nodes. This limits our ability to add integration tests for our networking code, which often executes different code paths for different connection types. This PR enables creating `outbound` & `block-relay-only` P2P connections in the functional tests. This allows us to increase our p2p test coverage, since we can now verify expectations around these connection types. This builds out the [prototype](https://github.com/bitcoin/bitcoin/issues/14210#issuecomment-527421978) proposed by ajtowns in #14210. 🙌🏽 An overview of this branch: - introduces a new test-only RPC function `addconnection` which initiates opening an `outbound` or `block-relay-only` connection. (conceptually similar to `addnode` but for different connection types & restricted to regtest) - adds `test_framework` support so a mininode can open an `outbound`/`block-relay-only` connection to a `P2PInterface`/`P2PConnection`. - updates `p2p_blocksonly` tests to create a `block-relay-only` connection & verify expectations around transaction relay. - introduces `p2p_add_connections` test that checks the behaviors of the newly introduced `add_outbound_p2p_connection` test framework function. With these changes, there are many more behaviors that we can add integration tests for. The blocksonly updates is just one example. Huge props to ajtowns for conceiving the approach & providing me feedback as I've built out this branch. Also thank you to jnewbery for lots of thoughtful input along the way. ACKs for top commit: troygiorshev: reACK `b4dd2ef800` jnewbery: utACK `b4dd2ef800` MarcoFalke: Approach ACK `b4dd2ef800` 🍢 Tree-SHA512: d1cba768c19c9c80e6a38b1c340cc86a90701b14772c4a0791c458f9097f6a4574b4a4acc7d13d6790c7b1f1f197e2c3d87996270f177402145f084ef8519a6b		4 years ago
..
__init__.py	…
address.py	[tests] Replace bytes literals with hex literals	4 years ago
authproxy.py	test: retry when write to a socket fails on macOS	4 years ago
bdb.py	test: Add test_framework/bdb.py module for inspecting bdb files	4 years ago
bip340_test_vectors.csv	tests: add BIP340 Schnorr signature support to test framework	4 years ago
blocktools.py	scripted-diff: Bump copyright headers	4 years ago
coverage.py	…
descriptors.py	…
key.py	doc: Use https URLs where possible	4 years ago
messages.py	Remove unused bits from service flags enum	4 years ago
muhash.py	test: Change MuHash Python implementation to match cpp version again	4 years ago
netutil.py	doc: Use https URLs where possible	4 years ago
p2p.py	[test] Add test framework support to create outbound connections.	4 years ago
script.py	Merge #20189 : test: Switch to BIP341's suggested scheme for outputs without script	4 years ago
script_util.py	scripted-diff: Bump copyright headers	4 years ago
segwit_addr.py	[tests] Rename segwit encode and decode functions	4 years ago
siphash.py	…
socks5.py	…
test_framework.py	scripted-diff: Bump copyright headers	4 years ago
test_node.py	[test] Add test framework support to create outbound connections.	4 years ago
test_shell.py	…
util.py	net: Add -natpmp command line option	4 years ago
wallet.py	test: Replace getmempoolentry with testmempoolaccept in MiniWallet	4 years ago
wallet_util.py	[tests] move generate_wif_key to wallet_util.py	4 years ago