litecoin

Commit Graph

Author	SHA1	Message	Date
Andrew Chow	a66a7a1a70	walletdb: don't reinitialize desc cache with multiple cache entries When loading descriptor caches, we would accidentally reinitialize the descriptor cache when seeing that one already exists. This should have only been initializing the cache when one does not exist. However this code itself is unnecessary as the act of looking up the cache to add to it will initialize it if it didn't already exist. This issue could be hit by trying to load a wallet that had imported a multisig descriptor. The wallet would fail to load. A test has been added to wallet_importdescriptors.py to catch this case. Another test case has also been added to check that loading a wallet with only single key descriptors works.	4 years ago
Andrew Chow	7b2b06dfe3	tests: Add missing sync_all to wallet_importdescriptors.py node1 will sometimes do sendtoaddress before it has received a funding transaction which will cause the test to fail. sync_all to ensure it gets the transaction first.	5 years ago
Hugo Nguyen	f193ea889d	add importdescriptors RPC and tests for native descriptor wallets Co-authored-by: Andrew Chow <achow101-github@achow101.com>	5 years ago

Author

SHA1

Message

Date

Andrew Chow

a66a7a1a70

walletdb: don't reinitialize desc cache with multiple cache entries

When loading descriptor caches, we would accidentally reinitialize the
descriptor cache when seeing that one already exists. This should have
only been initializing the cache when one does not exist. However this
code itself is unnecessary as the act of looking up the cache to add to
it will initialize it if it didn't already exist.

This issue could be hit by trying to load a wallet that had imported a
multisig descriptor. The wallet would fail to load.

A test has been added to wallet_importdescriptors.py to catch this case.
Another test case has also been added to check that loading a wallet
with only single key descriptors works.

Andrew Chow

7b2b06dfe3

tests: Add missing sync_all to wallet_importdescriptors.py

node1 will sometimes do sendtoaddress before it has received a funding
transaction which will cause the test to fail. sync_all to ensure it
gets the transaction first.

Hugo Nguyen

f193ea889d

add importdescriptors RPC and tests for native descriptor wallets

Co-authored-by: Andrew Chow <achow101-github@achow101.com>

3 Commits (faca3734c00ffaf2be7bd555fbfa2887ba28c811)