25 Commits (fa55dd89cbfababb400624d6c2081487ee6b176f)

Author	SHA1	Message	Date
MarcoFalke	fafe5f0d09	test: Remove unused imports	6 years ago
MarcoFalke	fa16a09215	scripted-diff: use self.sync_* methods ... -BEGIN VERIFY SCRIPT- sed -i -e 's/sync_blocks(self.nodes)/self.sync_blocks()/g' $(git grep -l 'sync_blocks(self.nodes)' ./test/functional/*.py) sed -i -e 's/sync_mempools(self.nodes)/self.sync_mempools()/g' $(git grep -l 'sync_mempools(self.nodes)' ./test/functional/*.py) sed -i -e 's/ sync_blocks(/ self.sync_blocks(/g' $(git grep -l sync_blocks ./test/functional/*.py) sed -i -e 's/ sync_mempools(/ self.sync_mempools(/g' $(git grep -l sync_mempools ./test/functional/*.py) -END VERIFY SCRIPT-	6 years ago
Karl-Johan Alm	6c0a6f73e3	wallet/rpc: add maxfeerate parameter to sendrawtransaction	6 years ago
MarcoFalke	faa7cdf764	scripted-diff: Update copyright in ./test ... -BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./test/ -END VERIFY SCRIPT-	6 years ago
MarcoFalke	fa0e65b772	scripted-diff: test: Remove brackets after assert ... -BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e 's/assert ?\((.+)\)(( )*)?(#.*)?$/assert \1\3\3\4/g' $(git grep -l --extended-regexp 'assert ?\(' test) -END VERIFY SCRIPT-	6 years ago
MarcoFalke	fa6bf21f5e	scripted-diff: test: Use py3.5 bytes::hex() method ... -BEGIN VERIFY SCRIPT- sed -i -e "s/def bytes_to_hex_str/def b_2_x/g" $(git grep -l bytes_to_hex_str) export RE_B_0="[^()]*" # match no bracket export RE_B_1="${RE_B_0}\(${RE_B_0}\)${RE_B_0}" # match exactly one () export RE_B_2="${RE_B_0}\(${RE_B_1}\)${RE_B_0}" # match wrapped (()) export RE_M="(b2x|bytes_to_hex_str)\(((${RE_B_0}|${RE_B_1}|${RE_B_2})*)\)" sed -i --regexp-extended -e "s/${RE_M}/\2.hex()/g" $(git grep -l -E '(b2x|bytes_to_hex_str)') sed -i --regexp-extended -e "/ +bytes_to_hex_str( as b2x)?,/d" $(git grep -l bytes_to_hex_str) sed -i --regexp-extended -e "s/ +bytes_to_hex_str( as b2x)?,//g" $(git grep -l bytes_to_hex_str) sed -i --regexp-extended -e "s/, bytes_to_hex_str( as b2x)?//g" $(git grep -l bytes_to_hex_str) export RE_M="(binascii\.)?hexlify\(((${RE_B_0}|${RE_B_1}|${RE_B_2})*)\).decode\(${RE_B_0}\)" sed -i --regexp-extended -e "s/${RE_M}/\2.hex()/g" $(git grep -l hexlify -- ':(exclude)share') sed -i --regexp-extended -e "/from binascii import hexlify$/d" $(git grep -l hexlify -- ':(exclude)share') sed -i --regexp-extended -e "s/(from binascii import) .*hexlify/\1 unhexlify/g" $(git grep -l hexlify -- ':(exclude)share') sed -i -e 's/ignore-names "/ignore-names "b_2_x,/g' ./test/lint/lint-python-dead-code.sh -END VERIFY SCRIPT-	6 years ago
Amiti Uttarwar	8e4b4f683a	Address test todos by removing -txindex to nodes. ... Originally added when updating getrawtransaction to stop searching unspent utxos.	6 years ago
Amiti Uttarwar	04da9f4834	[RPC] Update getrawtransaction interface	6 years ago
John Newbery	0025c9eae4	[mining] segwit option must be set in GBT ... Calling getblocktemplate without the segwit rule specified is most likely a client error, since it results in lower fees for the miner. Prevent this client error by failing getblocktemplate if called without the segwit rule specified.	6 years ago
John Newbery	07e3f585ab	[test] Remove deprecated addwitnessaddress from feature_segwit.py	6 years ago
John Newbery	67d7d67cf3	[test] Fix flake8 warnings in tests ... Fix all flake8 warnings in tests that are about to be updated to remove addwitnessaddress	6 years ago
MarcoFalke	fac9539836	qa: Run all tests even if wallet is not compiled	6 years ago
practicalswift	68400d8b96	tests: Use explicit imports	6 years ago
Wladimir J. van der Laan	78dae8cacc	Merge #13780: 0.17: Pre-branch maintenance ... 3fc20632a3 qt: Set BLOCK_CHAIN_SIZE = 220 (DrahtBot) 2b6a2f4a28 Regenerate manpages (DrahtBot) eb7daf4d60 Update copyright headers to 2018 (DrahtBot) Pull request description: Some trivial maintenance to avoid having to do it again after the 0.17 branch off. (The scripts to do this are in `./contrib/`) Tree-SHA512: 16b2af45e0351b1c691c5311d48025dc6828079e98c2aa2e600dc5910ee8aa01858ca6c356538150dc46fe14c8819ed8ec8e4ec9a0f682b9950dd41bc50518fa	6 years ago
DrahtBot	eb7daf4d60	Update copyright headers to 2018	6 years ago
MarcoFalke	faa24441ec	policy: Remove promiscuousmempoolflags	6 years ago
MarcoFalke	fa7a6cf1b3	policy: Treat segwit as always active	7 years ago
MarcoFalke	364bae5f7a	qa: Pad scriptPubKeys to get minimum sized txs	7 years ago
Wladimir J. van der Laan	487dcbe80c	Merge #13002: Do not treat bare multisig outputs as IsMine unless watched ... 7d0f80b Use anonymous namespace instead of static functions (Pieter Wuille) b61fb71 Mention removal of bare multisig IsMine in release notes (Pieter Wuille) 9c2a8b8 Do not treat bare multisig as IsMine (Pieter Wuille) 08f3228 Optimization: only test for witness scripts at top level (Pieter Wuille) 3619735 Track difference between scriptPubKey and P2SH execution in IsMine (Pieter Wuille) ac6ec62 Switch to a private version of SigVersion inside IsMine (Pieter Wuille) 19fc973 Do not expose SigVersion argument to IsMine (Pieter Wuille) fb1dfbb Remove unused IsMine overload (Pieter Wuille) 952d821 Make CScript -> CScriptID conversion explicit (Pieter Wuille) Pull request description: Currently our wallet code will treat bare multisig outputs (meaning scriptPubKeys with multiple public keys + `OP_CHECKMULTISIG` operator in it) as ours without the user asking for it, as long as all private keys in it are in our wallet. This is a pointless feature. As it only works when all private keys are in one place, it's useless compared to single key outputs (P2PK, P2PKH, P2WPKH, P2SH-P2WPKH), and worse in terms of space, cost, UTXO size, and ability to test (due to lack of address format for them). Furthermore, they are problematic in that producing a list of all `scriptPubKeys` we accept is not tractable (it involves all combinations of all public keys that are ours). In further wallet changes I'd like to move to a model where all scriptPubKeys that are treated as ours are explicit, rather than defined by whatever keys we have. The current behavior of the wallet is very hard to model in such a design, so I'd like to get rid of it. I think there are two options: * Remove it entirely (do not ever accept bare multisig outputs as ours, unless watched) * Only accept bare multisig outputs in situations where the P2SH version of that output would also be acceptable This PR implements the first option. The second option was explored in #12874. Tree-SHA512: 917ed45b3cac864cee53e27f9a3e900390c576277fbd6751b1250becea04d692b3b426fa09065a3399931013bd579c4f3dbeeb29d51d19ed0c64da75d430ad9a	7 years ago
Pieter Wuille	9c2a8b8d34	Do not treat bare multisig as IsMine ... Such outputs can still be watched, and signed for, but they aren't treated as valid payments. That means they won't cause transactions to appear in listtransactions, their outputs to be shown under listunspent, or affect balances.	7 years ago
Suhas Daftuar	5c31b20a35	[qa] Remove some pre-activation segwit tests ... This is in preparation for always enforcing SCRIPT_VERIFY_WITNESS.	7 years ago
Andrew Chow	eefff65a4b	scripted-diff: change signrawtransaction to signrawtransactionwithwallet in tests ... -BEGIN VERIFY SCRIPT- sed -i 's/\<signrawtransaction\>/signrawtransactionwithwallet/g' test/functional/*.py sed -i 's/\<signrawtransaction\>/signrawtransactionwithwallet/g' test/functional/test_framework/*.py -END VERIFY SCRIPT-	7 years ago
Andrew Chow	b22cce0148	scripted-diff: validateaddress to getaddressinfo in tests ... Change all instances of validateaddress to getaddressinfo since it seems that no test actually uses validateaddress for actually validating addresses. -BEGIN VERIFY SCRIPT- find ./test/functional -path '*py' -not -path ./test/functional/wallet_disable.py -not -path ./test/functional/rpc_deprecated.py -not -path ./test/functional/wallet_address_types.py -exec sed -i'' -e 's/validateaddress/getaddressinfo/g' {} \; -END VERIFY SCRIPT-	7 years ago
Jorge Timón	9bb59cf7ba	QA: segwit.py: s/find_unspent/find_spendable_utxo/	7 years ago
Anthony Towns	ca6523d0c8	[tests] Rename feature_* functional tests.	7 years ago