4 Commits (e3206c9445f8d8e2bdb36d98af609985e8809908)

Author	SHA1	Message	Date
Vasil Dimov	3cb9d9c861	net: make CaptureMessage() mockable ... Rename `CaptureMessage()` to `CaptureMessageToFile()` and introduce a `std::function` variable called `CaptureMessage` whose value can be changed by unit tests, should they need to inspect message contents.	3 years ago
MarcoFalke	fac23c2114	scripted-diff: Bump copyright headers ... The previous diff touched most files in ./test/, so bump the headers to avoid having to touch them again for a bump later. -BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./test/ -END VERIFY SCRIPT-	3 years ago
fanquake	9913419cc9	test: remove type: comments in favour of actual annotations ... Now that we require Python 3.6+, we should be using variable type annotations directly rather than # type: comments. Also takes care of the discarded value issue in p2p_message_capture.py. See: https://github.com/bitcoin/bitcoin/pull/19509/files#r571674446.	4 years ago
Troy Giorshev	381f77be85	Add Message Capture Test ... Add a functional test for CaptureMessage. This connects and then disconnects a peer so that the handshake can be used to check if capture is being done correctly. Included in a docstring in the test is the following: From the data file we'll only check the structure. We won't care about things like: - Deserializing the payload of the message - This is managed by the deserialize methods in test_framework.messages - The order of the messages - There's no reason why we can't, say, change the order of the messages in the handshake - Message Type - We can add new message types We're ignoring these because they're simply too brittle to test here.	4 years ago