6 Commits (d4b67c8ebc2bb7488bcaaccc3a801cdef1cf1678)

Author	SHA1	Message	Date
W. J. van der Laan	0553d75268	Merge bitcoin/bitcoin#22154: Add OutputType::BECH32M and related wallet support for fetching bech32m addresses ... 754f134a50 wallet: Add error message to GetReservedDestination (Andrew Chow) 87a0e7a3b7 Disallow bech32m addresses for legacy wallet things (Andrew Chow) 6dbe4d1072 Use BECH32M for tr() desc, WitV1Taproot, and WitUnknown CTxDests (Andrew Chow) 699dfcd8ad Opportunistically use bech32m change addresses if available (Andrew Chow) 0262536c34 Add OutputType::BECH32M (Andrew Chow) 177c15d2f7 Limit LegacyScriptPubKeyMan address types (Andrew Chow) Pull request description: Currently bech32m addresses are classfied as bech32. Because bech32m is incompatible with bech32, we need to define a new `OutputType` for it so that it can be handled correctly. This PR adds `OutputType::BECH32M`, updates all of the relevant `OutputType` classifications, and handle requests for bech32m addresses. There is now a `bech32m` address type string that can be used. * `tr()` descriptors now report their output type as `OutputType::BECH32M`. `WtinessV1Taproot` and `WitnessUnknown` are also classified as `OutputType::BECH32M`. * Bech32m addresses are completely disabled for legacy wallets. They cannot be imported (explicitly disallowed in `importaddress` and `importmulti`), will not be created when getting all destinations for a pubkey, and will not be added with `addmultisigaddress`. Additional protections have been added to `LegacyScriptPubKeyMan` to disallow attempting to retrieve bech32m addresses. * Since Taproot multisigs are not implemented yet, `createmultisig` will also disallow the bech32m address type. * As Taproot is not yet active, `DescriptorScriptPubKeyMan` cannot and will not create a `tr()` descriptor. Protections have been added to make sure this cannot occur. * The change address type detection algorithm has been updated to return `bech32m` when there is a segwit v1+ output script and the wallet has a bech32m `ScriptPubKeyMan`, falling back to bech32 if one is not available. ACKs for top commit: laanwj: re-review ACK 754f134a50 Sjors: re-utACK 754f134: only change is switching to `bech32m` in two `wallet_taproot.py` test cases. fjahr: re-ACK 754f134a50 jonatack: ACK 754f134a50 Tree-SHA512: 6ea90867d3631d0d438e2b08ce6ed930f37d01323224661e8e38f183ea5ee2ab65b5891394a3612c7382a1aff907b457616c6725665a10c320174017b998ca9f	3 years ago
Andrew Chow	6dbe4d1072	Use BECH32M for tr() desc, WitV1Taproot, and WitUnknown CTxDests ... The tr() descriptor, WitnessV1Taproot CTxDestination, and WitnessUnknown CTxDestination are OutputType::BECH32M so they should report as such.	3 years ago
Pieter Wuille	d637a9b397	Taproot descriptor inference	3 years ago
Pieter Wuille	c0f0c8eccb	tests: check spending of P2TR	3 years ago
Andrew Chow	fbf485c9b2	Allow tr() import only when Taproot is active ... To avoid issues around fund loss, only allow descriptor wallets to import tr() descriptors after taproot has activated.	3 years ago
Pieter Wuille	2667366aaa	tests: check derivation of P2TR	4 years ago