cf9ed307e6
qa: blocktools enforce named args for amount
6 years ago
f66e1c793e
Merge #13669 : Tests: Cleanup create_transaction implementations
...
44bbceeef1736f941424157651855fhttps://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_cltv.py#L52-L60 ), [2](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_csv_activation.py#L88-L95 ) [3](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_dersig.py#L40-L48 ), [4](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_nulldummy.py#L100-L108 ), [5](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L529-L535 ), [6](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/blocktools.py#L120-L129 ), [7](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_block.py#L1218-L1220 )) implementations of a function called something similar to `create_transaction` in the functional tests, some of which are exact copies of each other.
This PR aims to clean this up into [three different cases implemented in blocktools.py](https://github.com/conscott/bitcoin/blob/create_tx_cleanup/test/functional/test_framework/blocktools.py#L121-L149 )
1. `create_tx_with_script`: Return transaction object spending generic tx output optionally specifying scriptSig and scriptPubKey
2. `create_transaction`: Return transaction object spending coinbase tx
2. `create_raw_transaction`: Return raw transaction (hex string) spending coinbase tx
I am not committed to any of these function names, so I'll gladly take suggestions on there.
Additionally there are some related cleanups to feature_block.py tests, specifically removing the [PreviousSpendableOutput](https://github.com/conscott/bitcoin/blob/master/test/functional/feature_block.py#L51-L54 ) object, which seems like an unnecessary layer given that every instance spends the 0 output.
Tree-SHA512: 63c6233b6f0942c81ba1ca67ea6770809b8c9409314c6d4cf8e5a3991cb9ee92b22bebe88c0dde45cd71e754eb351230c4c404b70ff118f5f43c034452ada65c
6 years ago
8ac7125d59
Merge #13916 : qa: wait_for_verack by default
...
fa5587fe71
6 years ago
736f941424
[Tests] Cleanup extra instances of create_transaction
6 years ago
fa5587fe71
qa: wait_for_verack by default
6 years ago
eb7daf4d60
Update copyright headers to 2018
6 years ago
fa87da2f17
qa: Avoid start/stop of the network thread mid-test
6 years ago
12982682a6
[tests] Change feature_csv_activation.py to use BitcoinTestFramework
7 years ago
db7ffb9d1b
[tests] Move utility functions in feature_csv_activation.py out of class.
7 years ago
0842edf9ee
[tests] Remove nested loops from feature_csv_activation.py
...
Makes the test a lot clearer.
7 years ago
2e511d5424
[tests] improve logging in feature_csv_activation.py
7 years ago
6f7f5bc002
[tests] fix flake8 nits in feature_csv_activation.py
7 years ago
eefff65a4b
scripted-diff: change signrawtransaction to signrawtransactionwithwallet in tests
...
-BEGIN VERIFY SCRIPT-
sed -i 's/\<signrawtransaction\>/signrawtransactionwithwallet/g' test/functional/*.py
sed -i 's/\<signrawtransaction\>/signrawtransactionwithwallet/g' test/functional/test_framework/*.py
-END VERIFY SCRIPT-
7 years ago
ca6523d0c8
[tests] Rename feature_* functional tests.
7 years ago
MarcoFalke