From fa25210d6266d50a6c2bfd6d96062bacb2ae393b Mon Sep 17 00:00:00 2001 From: MarcoFalke Date: Fri, 15 Feb 2019 10:15:28 -0500 Subject: [PATCH] qa: Fix wallet_txn_doublespend issue --- test/functional/feature_proxy.py | 1 - test/functional/wallet_txn_doublespend.py | 8 ++++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/test/functional/feature_proxy.py b/test/functional/feature_proxy.py index 5453f0be3b..f042adb7aa 100755 --- a/test/functional/feature_proxy.py +++ b/test/functional/feature_proxy.py @@ -41,7 +41,6 @@ from test_framework.netutil import test_ipv6_local RANGE_BEGIN = PORT_MIN + 2 * PORT_RANGE # Start after p2p and rpc ports - class ProxyTest(BitcoinTestFramework): def set_test_params(self): self.num_nodes = 4 diff --git a/test/functional/wallet_txn_doublespend.py b/test/functional/wallet_txn_doublespend.py index f114d5ab68..9050e21247 100755 --- a/test/functional/wallet_txn_doublespend.py +++ b/test/functional/wallet_txn_doublespend.py @@ -34,6 +34,14 @@ class TxnMallTest(BitcoinTestFramework): def run_test(self): # All nodes should start with 1,250 BTC: starting_balance = 1250 + + # All nodes should be out of IBD. + # If the nodes are not all out of IBD, that can interfere with + # blockchain sync later in the test when nodes are connected, due to + # timing issues. + for n in self.nodes: + assert n.getblockchaininfo()["initialblockdownload"] == False + for i in range(4): assert_equal(self.nodes[i].getbalance(), starting_balance) self.nodes[i].getnewaddress("") # bug workaround, coins generated assigned to first getnewaddress!