From e4a8d561edf3cfb326e86c87155fed41a61e7333 Mon Sep 17 00:00:00 2001 From: Martin Zumsande Date: Tue, 14 Dec 2021 21:36:00 +0000 Subject: [PATCH] doc: add explanations for assert in index and magic numbers in test These were suggested in review of #23365 Co-authored-by: John Newbery --- src/index/base.cpp | 2 ++ test/functional/feature_blockfilterindex_prune.py | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/index/base.cpp b/src/index/base.cpp index 8525dcbfa0..24c289ed51 100644 --- a/src/index/base.cpp +++ b/src/index/base.cpp @@ -96,6 +96,8 @@ bool BaseIndex::Init() prune_violation = false; break; } + // block->pprev must exist at this point, since block_to_test is part of the chain + // and thus must be encountered when going backwards from the tip assert(block->pprev); block = block->pprev; } diff --git a/test/functional/feature_blockfilterindex_prune.py b/test/functional/feature_blockfilterindex_prune.py index 83a50c504e..2451988135 100755 --- a/test/functional/feature_blockfilterindex_prune.py +++ b/test/functional/feature_blockfilterindex_prune.py @@ -29,6 +29,8 @@ class FeatureBlockfilterindexPruneTest(BitcoinTestFramework): self.log.info("prune some blocks") pruneheight = self.nodes[0].pruneblockchain(400) + # the prune heights used here and below are magic numbers that are determined by the + # thresholds at which block files wrap, so they depend on disk serialization and default block file size. assert_equal(pruneheight, 248) self.log.info("check if we can access the tips blockfilter when we have pruned some blocks")