From 07c483895d219d4c44bd8fec5167a53f4701c364 Mon Sep 17 00:00:00 2001 From: Matt Corallo Date: Tue, 5 Dec 2017 10:39:44 -0500 Subject: [PATCH] Always return true if AppInitMain got to the end This should fix a very rare travis failure in zapwallettxes, but is also more correct, as you can currently race ReacceptWalletTransactions with stop RPC calls to get bitcoind to (IMO) eroneously return a non-0 exit code. --- src/init.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/init.cpp b/src/init.cpp index 871a585267..ae60999034 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -1726,5 +1726,5 @@ bool AppInitMain(boost::thread_group& threadGroup, CScheduler& scheduler) StartWallets(scheduler); #endif - return !fRequestShutdown; + return true; }