From a090d1c1c9c379bce7345ba5b78aa9491e350d0b Mon Sep 17 00:00:00 2001 From: Pieter Wuille Date: Sun, 11 Jun 2017 15:53:33 -0700 Subject: [PATCH] Header include guideline --- doc/developer-notes.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/doc/developer-notes.md b/doc/developer-notes.md index ec6abda91e..a596ea0117 100644 --- a/doc/developer-notes.md +++ b/doc/developer-notes.md @@ -425,6 +425,14 @@ Source code organization - *Rationale*: Shorter and simpler header files are easier to read, and reduce compile time +- Every `.cpp` and `.h` file should `#include` every header file it directly uses classes, functions or other + definitions from, even if those headers are already included indirectly through other headers. One exception + is that a `.cpp` file does not need to re-include the includes already included in its corresponding `.h` file. + + - *Rationale*: Excluding headers because they are already indirectly included results in compilation + failures when those indirect dependencies change. Furthermore, it obscures what the real code + dependencies are. + - Don't import anything into the global namespace (`using namespace ...`). Use fully specified types such as `std::string`.