From 58446094519151e2e203944267e592eec2470643 Mon Sep 17 00:00:00 2001
From: practicalswift <practicalswift@users.noreply.github.com>
Date: Thu, 12 Jan 2017 22:51:26 +0100
Subject: [PATCH] [net] Avoid initialization to a value that is never read

Prior to this commit the value stored to `s` at initialization
was never read (in the case of STRERROR_R_CHAR_P).
---
 src/netbase.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/netbase.cpp b/src/netbase.cpp
index fc9a6ed0be..b26f7bcc1c 100644
--- a/src/netbase.cpp
+++ b/src/netbase.cpp
@@ -672,13 +672,14 @@ std::string NetworkErrorString(int err)
 std::string NetworkErrorString(int err)
 {
     char buf[256];
-    const char *s = buf;
     buf[0] = 0;
     /* Too bad there are two incompatible implementations of the
      * thread-safe strerror. */
+    const char *s;
 #ifdef STRERROR_R_CHAR_P /* GNU variant can return a pointer outside the passed buffer */
     s = strerror_r(err, buf, sizeof(buf));
 #else /* POSIX variant always returns message in buffer */
+    s = buf;
     if (strerror_r(err, buf, sizeof(buf)))
         buf[0] = 0;
 #endif