logging: Fix potential use-after-free in LogPrintStr(...)

7 years ago · 76f344de6d
parent 57c57df86f
commit 76f344de6d
1 changed files with 5 additions and 2 deletions
--- a/src/logging.cpp
+++ b/src/logging.cpp
@ -222,8 +222,11 @@ int BCLog::Logger::LogPrintStr(const std::string &str)
            // reopen the log file, if requested
            if (m_reopen_file) {
                m_reopen_file = false;
-                if (fsbridge::freopen(m_file_path,"a",m_fileout) != nullptr)
-                    setbuf(m_fileout, nullptr); // unbuffered
+                m_fileout = fsbridge::freopen(m_file_path, "a", m_fileout);
+                if (!m_fileout) {
+                    return ret;
+                }
+                setbuf(m_fileout, nullptr); // unbuffered
            }

            ret = FileWriteStr(strTimestamped, m_fileout);