From 6040de9a46725826330cd63cdf76e2121a18e728 Mon Sep 17 00:00:00 2001 From: Pieter Wuille Date: Tue, 20 Oct 2020 15:26:29 -0700 Subject: [PATCH] Add comments on CPubKey::IsValid --- src/pubkey.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/pubkey.h b/src/pubkey.h index 0f784b86e4..80d0c18540 100644 --- a/src/pubkey.h +++ b/src/pubkey.h @@ -170,6 +170,15 @@ public: /* * Check syntactic correctness. * + * When setting a pubkey (Set()) or deserializing fails (its header bytes + * don't match the length of the data), the size is set to 0. Thus, + * by checking size, one can observe whether Set() or deserialization has + * failed. + * + * This does not check for more than that. In particular, it does not verify + * that the coordinates correspond to a point on the curve (see IsFullyValid() + * for that instead). + * * Note that this is consensus critical as CheckECDSASignature() calls it! */ bool IsValid() const