From 4fbad9124e3a7e644b6226df301ddd73c8395f0b Mon Sep 17 00:00:00 2001 From: "Wladimir J. van der Laan" Date: Fri, 12 Oct 2012 23:49:44 +0200 Subject: [PATCH] Fix out-of-bounds read noticed by Ricardo Correia Sizeof() returned the size of a pointer instead of the size of the buffer. Fixes issue #1924. --- src/main.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/main.cpp b/src/main.cpp index be1e947ad3..e2b2447b84 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -3745,9 +3745,6 @@ public: } }; -const char* pszDummy = "\0\0"; -CScript scriptDummy(std::vector(pszDummy, pszDummy + sizeof(pszDummy))); - CBlock* CreateNewBlock(CReserveKey& reservekey) { CBlockIndex* pindexPrev = pindexBest; @@ -3981,7 +3978,7 @@ CBlock* CreateNewBlock(CReserveKey& reservekey) pblock->UpdateTime(pindexPrev); pblock->nBits = GetNextWorkRequired(pindexPrev, pblock.get()); pblock->nNonce = 0; - pblock->vtx[0].vin[0].scriptSig = scriptDummy; + pblock->vtx[0].vin[0].scriptSig = CScript() << OP_0 << OP_0; CBlockIndex indexDummy(*pblock); indexDummy.pprev = pindexPrev;