Merge #18364: random: remove getentropy() fallback for macOS < 10.12
pull/764/headf9f210d8de
doc: fix GetTimeMicros() comment in random.cpp (fanquake)a889711562
rand: remove getentropy() fallback for macOS < 10.12 (fanquake) Pull request description: We [no longer support macOS < 10.12](https://github.com/bitcoin/bitcoin/pull/17550) (our binaries will not run), so remove the fallback for when `getentropy()` wasn't available. From the manpage: ```bash HISTORY The getentropy() function appeared in OSX 10.12 ``` Note that compiling on macOS you'll see a new unused function warning: ```bash random.cpp:256:13: warning: unused function 'GetDevURandom' [-Wunused-function] static void GetDevURandom(unsigned char *ent32) ^ 1 warning generated. ``` This will likely be addressed as part of #17563. ACKs for top commit: vasild: ACKf9f210d8
(code review, not tested) elichai: utACKf9f210d8de
practicalswift: ACKf9f210d8de
-- patch looks correct laanwj: ACKf9f210d8de
hebasto: ACKf9f210d8de
, tested on macOS 10.13.6: compiled Tree-SHA512: 6bd2a721f23605a8bca0b7b51f42d628ebf92a18e74eb43194331ba745ee449223aff84119892781c40b188c70b75417447f4e390e3d9ac549292de2b1e8b308
commit
1d64dfe4fa
Loading…
Reference in new issue