You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
bitcoin/test/functional
MarcoFalke fa974f1f14
scripted-diff: Remove redundant sync_all and sync_blocks
3 years ago
..
data lint: enable mypy checking for missing imports 3 years ago
mocks test: Use 4 spaces for indentation 3 years ago
test_framework Merge bitcoin/bitcoin#23300: test: Implicitly sync after generate*, unless opted out 3 years ago
.gitignore
README.md Enable TLS in links in documentation 3 years ago
combine_logs.py lint: enable mypy checking for missing imports 3 years ago
combined_log_template.html
create_cache.py
example_test.py test: Implicitly sync after generate*, unless opted out 3 years ago
feature_abortnode.py test: Implicitly sync after generate*, unless opted out 3 years ago
feature_addrman.py Introduce new V4 format addrman 3 years ago
feature_anchors.py test: Remove useless overwrite 3 years ago
feature_asmap.py test: avoid non-determinism in asmap-addrman test 3 years ago
feature_assumevalid.py Use COINBASE_MATURITY constant in functional tests. 3 years ago
feature_backwards_compatibility.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
feature_bind_extra.py net: don't bind on 0.0.0.0 if binds are restricted to Tor 3 years ago
feature_bip68_sequence.py test: Implicitly sync after generate*, unless opted out 3 years ago
feature_block.py test: Activate all regtest softforks at height 1, unless overridden 3 years ago
feature_blockfilterindex_prune.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
feature_blocksdir.py scripted-diff: Use generate* from TestFramework 3 years ago
feature_cltv.py test: Activate all regtest softforks at height 1, unless overridden 3 years ago
feature_coinstatsindex.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
feature_config_args.py test: Fix tests on Windows 3 years ago
feature_csv_activation.py test: Activate all regtest softforks at height 1, unless overridden 3 years ago
feature_dbcrash.py test: Implicitly sync after generate*, unless opted out 3 years ago
feature_dersig.py test: Activate all regtest softforks at height 1, unless overridden 3 years ago
feature_fee_estimation.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
feature_filelock.py wallet: Use PACKAGE_NAME to mention our software 3 years ago
feature_help.py test: use f-strings in feature_help.py 3 years ago
feature_includeconf.py Cleanup -includeconf error message 4 years ago
feature_loadblock.py test: Implicitly sync after generate*, unless opted out 3 years ago
feature_logging.py test: use f-strings in feature_logging.py 3 years ago
feature_maxuploadtarget.py test: Set peertimeout in write_config 3 years ago
feature_minchainwork.py test: Implicitly sync after generate*, unless opted out 3 years ago
feature_notifications.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
feature_nulldummy.py Introduce -testactivationheight=name@height setting 3 years ago
feature_presegwit_node_upgrade.py Introduce -testactivationheight=name@height setting 3 years ago
feature_proxy.py test: extend feature_proxy.py to test CJDNS 3 years ago
feature_pruning.py test: Implicitly sync after generate*, unless opted out 3 years ago
feature_rbf.py Make explicit the node param in init_wallet() 3 years ago
feature_reindex.py scripted-diff: Use generate* from TestFramework 3 years ago
feature_segwit.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
feature_settings.py test: use f-strings in feature_settings.py 3 years ago
feature_shutdown.py scripted-diff: Bump copyright headers 4 years ago
feature_signet.py test: Implicitly sync after generate*, unless opted out 3 years ago
feature_syscall_sandbox.py Add syscall sandboxing (seccomp-bpf) 3 years ago
feature_taproot.py test: introduce script_util helper for creating P2PK scripts 3 years ago
feature_uacomment.py
feature_utxo_set_hash.py scripted-diff: Use generate* from TestFramework 3 years ago
feature_versionbits_warning.py Add syscall sandboxing (seccomp-bpf) 3 years ago
interface_bitcoin_cli.py net: don't skip CJDNS from GetNetworksInfo() 3 years ago
interface_http.py test: use f-strings in interface_*.py tests 3 years ago
interface_rest.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
interface_rpc.py test: use f-strings in interface_*.py tests 3 years ago
interface_zmq.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
mempool_accept.py test: add script_util helper for creating bare multisig scripts 3 years ago
mempool_accept_wtxid.py scripted-diff: Use generate* from TestFramework 3 years ago
mempool_compatibility.py test: Implicitly sync after generate*, unless opted out 3 years ago
mempool_expiry.py scripted-diff: Use generate* from TestFramework 3 years ago
mempool_limit.py test: fix misleading fee unit in mempool_limit.py 3 years ago
mempool_package_limits.py test: Use generate* from TestFramework, not TestNode 3 years ago
mempool_package_onemore.py scripted-diff: Use generate* from TestFramework 3 years ago
mempool_packages.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
mempool_persist.py test: Implicitly sync after generate*, unless opted out 3 years ago
mempool_reorg.py test: Implicitly sync after generate*, unless opted out 3 years ago
mempool_resurrect.py scripted-diff: Use generate* from TestFramework 3 years ago
mempool_spend_coinbase.py test: Replace MiniWallet scan_blocks with rescan_utxos 3 years ago
mempool_unbroadcast.py test: Implicitly sync after generate*, unless opted out 3 years ago
mempool_updatefromblock.py scripted-diff: Use generate* from TestFramework 3 years ago
mining_basic.py test: Implicitly sync after generate*, unless opted out 3 years ago
mining_getblocktemplate_longpoll.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
mining_prioritisetransaction.py test: Implicitly sync after generate*, unless opted out 3 years ago
p2p_add_connections.py scripted-diff: Remove setup_clean_chain if default is not changed 4 years ago
p2p_addr_relay.py [addrman] Add Add_() inner function, fix Add() return semantics 3 years ago
p2p_addrfetch.py test: use test_framework.p2p P2P_SERVICES in functional tests 3 years ago
p2p_addrv2_relay.py [addrman] Add Add_() inner function, fix Add() return semantics 3 years ago
p2p_blockfilters.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
p2p_blocksonly.py p2p: Rename fBlocksOnly, Add test 3 years ago
p2p_compactblocks.py scripted-diff: Use generate* from TestFramework 3 years ago
p2p_compactblocks_blocksonly.py test: Implicitly sync after generate*, unless opted out 3 years ago
p2p_compactblocks_hb.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
p2p_disconnect_ban.py scripted-diff: Bump copyright headers 4 years ago
p2p_dns_seeds.py [test] Test the delay before querying DNS seeds 3 years ago
p2p_dos_header_tree.py scripted-diff: test: rename `FromHex` to `from_hex` 3 years ago
p2p_eviction.py scripted-diff: Use generate* from TestFramework 3 years ago
p2p_feefilter.py scripted-diff: Use generate* from TestFramework 3 years ago
p2p_filter.py test: use MiniWallet for p2p_filter.py 3 years ago
p2p_fingerprint.py scripted-diff: Use generate* from TestFramework 3 years ago
p2p_getaddr_caching.py scripted-diff: Remove setup_clean_chain if default is not changed 4 years ago
p2p_getdata.py
p2p_i2p_ports.py test: ensure I2P ports are handled as expected 3 years ago
p2p_ibd_txrelay.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
p2p_invalid_block.py scripted-diff: Use generate* from TestFramework 3 years ago
p2p_invalid_locator.py scripted-diff: Use generate* from TestFramework 3 years ago
p2p_invalid_messages.py log: improve addrman logging 3 years ago
p2p_invalid_tx.py scripted-diff: Use generate* from TestFramework 3 years ago
p2p_leak.py scripted-diff: Use generate* from TestFramework 3 years ago
p2p_leak_tx.py scripted-diff: Use generate* from TestFramework 3 years ago
p2p_message_capture.py test: remove type: comments in favour of actual annotations 4 years ago
p2p_nobloomfilter_messages.py scripted-diff: Bump copyright headers 4 years ago
p2p_node_network_limited.py test: Properly set sync_fun in NodeNetworkLimitedTest 3 years ago
p2p_permissions.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
p2p_ping.py p2p: Use mocktime for ping timeout 3 years ago
p2p_segwit.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
p2p_sendheaders.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
p2p_timeouts.py net: use peer=N instead of from=N in debug log 4 years ago
p2p_tx_download.py test: introduce `tx_from_hex` helper for tx deserialization 3 years ago
p2p_unrequested_blocks.py test: Implicitly sync after generate*, unless opted out 3 years ago
rpc_bind.py
rpc_blockchain.py test: Implicitly sync after generate*, unless opted out 3 years ago
rpc_createmultisig.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
rpc_decodescript.py test: refactor: remove `hex_str_to_bytes` helper 3 years ago
rpc_deprecated.py scripted-diff: Use generate* from TestFramework 3 years ago
rpc_deriveaddresses.py
rpc_dumptxoutset.py scripted-diff: Use generate* from TestFramework 3 years ago
rpc_estimatefee.py scripted-diff: Remove setup_clean_chain if default is not changed 4 years ago
rpc_fundrawtransaction.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
rpc_generate.py
rpc_generateblock.py scripted-diff: Use generate* from TestFramework 3 years ago
rpc_getblockfilter.py test: Implicitly sync after generate*, unless opted out 3 years ago
rpc_getblockstats.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
rpc_getchaintips.py test: Implicitly sync after generate*, unless opted out 3 years ago
rpc_getdescriptorinfo.py scripted-diff: Bump copyright headers 4 years ago
rpc_help.py rpc: add external signer RPC files 4 years ago
rpc_invalid_address_message.py Make explicit the node param in init_wallet() 3 years ago
rpc_invalidateblock.py test: Implicitly sync after generate*, unless opted out 3 years ago
rpc_misc.py blockstorage: use debug log category 3 years ago
rpc_named_arguments.py
rpc_net.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
rpc_packages.py scripted-diff: Use generate* from TestFramework 3 years ago
rpc_preciousblock.py test: Implicitly sync after generate*, unless opted out 3 years ago
rpc_psbt.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
rpc_rawtransaction.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
rpc_scantxoutset.py scripted-diff: Use generate* from TestFramework 3 years ago
rpc_setban.py style: remove () from assert in rpc_setban.py 3 years ago
rpc_signer.py Add syscall sandboxing (seccomp-bpf) 3 years ago
rpc_signmessagewithprivkey.py test: added test for disabled wallet 3 years ago
rpc_signrawtransaction.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
rpc_txoutproof.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
rpc_uptime.py util: Disallow negative mocktime 4 years ago
rpc_users.py scripted-diff: Bump copyright headers 4 years ago
rpc_whitelist.py
test-shell.md scripted-diff: Use generate* from TestFramework 3 years ago
test_runner.py tests: Add feature_segwit.py --descriptors to test_runner.py 3 years ago
tool_wallet.py Merge bitcoin/bitcoin#23311: wallet: Use PACKAGE_NAME to mention our software 3 years ago
wallet_abandonconflict.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_address_types.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_avoidreuse.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_backup.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_balance.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_basic.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_bumpfee.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_coinbase_category.py scripted-diff: Use generate* from TestFramework 3 years ago
wallet_create_tx.py test: get and decode tx with a single `gettransaction` RPC call 3 years ago
wallet_createwallet.py scripted-diff: Use generate* from TestFramework 3 years ago
wallet_descriptor.py test: Use generate* node RPC, not wallet RPC 3 years ago
wallet_disable.py scripted-diff: Use generate* from TestFramework 3 years ago
wallet_dump.py scripted-diff: Use generate* from TestFramework 3 years ago
wallet_encryption.py doc: fix various typos 4 years ago
wallet_fallbackfee.py scripted-diff: Use generate* from TestFramework 3 years ago
wallet_groups.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_hd.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_implicitsegwit.py
wallet_import_rescan.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_import_with_label.py
wallet_importdescriptors.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_importmulti.py test: Implicitly sync after generate*, unless opted out 3 years ago
wallet_importprunedfunds.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_keypool.py Merge bitcoin/bitcoin#22949: fee: Round up fee calculation to avoid a lower than expected feerate 3 years ago
wallet_keypool_topup.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_labels.py scripted-diff: Use generate* from TestFramework 3 years ago
wallet_listdescriptors.py Make explicit the node param in init_wallet() 3 years ago
wallet_listreceivedby.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_listsinceblock.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_listtransactions.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_multisig_descriptor_psbt.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_multiwallet.py test: Implicitly sync after generate*, unless opted out 3 years ago
wallet_orphanedreward.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_reorgsrestore.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_resendwallettransactions.py test: remove `ToHex` helper, use .serialize().hex() instead 3 years ago
wallet_send.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_signer.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_signmessagewithaddress.py test: added test for disabled wallet 3 years ago
wallet_startup.py scripted-diff: Bump copyright headers 4 years ago
wallet_taproot.py test: Implicitly sync after generate*, unless opted out 3 years ago
wallet_transactiontime_rescan.py test: Use generate* from TestFramework, not TestNode 3 years ago
wallet_txn_clone.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_txn_doublespend.py scripted-diff: Remove redundant sync_all and sync_blocks 3 years ago
wallet_upgradewallet.py test: Implicitly sync after generate*, unless opted out 3 years ago
wallet_watchonly.py scripted-diff: Use generate* from TestFramework 3 years ago

README.md

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: