bitcoin

History

fanquake 4e7442e743 Merge bitcoin/bitcoin#28573 : github actions: Fix test-one-commit when parent of head is merge commit `88c8e3a0e4` github actions: Fix test-one-commit when parent of head is merge commit (Ryan Ofsky) Pull request description: Instead of figuring out the commit after the last merge and rebasing on that with a ~1 suffix, just figure out the last merge commit directly and rebase on it. This way, if HEAD happens to be a merge commit, the rebase just succeeds immediately without blank variables or errors. Explanation of the problem from https://github.com/bitcoin/bitcoin/pull/28497#issuecomment-1743430631: > The problem is that the PR only contains a one commit after the last merge, so the job _should_ be skipped, but the `pull_request.commits != 1` check is not smart enough to skip it because the PR is based on another PR and has merge ancestor commits. So specifically what happens is that after HEAD~ is checked out, the new HEAD is a merge commit, so the range `$(git log --merges -1 --format=%H)..HEAD` is equivalent to HEAD..HEAD, which is empty, so the `COMMIT_AFTER_LAST_MERGE` variable is empty and the rebase command fails. Note: In the current version of this PR, the "test each commit" job is skipped, because this PR only contains a single commit. But I manually verified the code works in earlier versions of the PR that included dummy commits. ACKs for top commit: maflcko: lgtmrecr ACK `88c8e3a0e4` RandyMcMillan: utACK `88c8e3a` Tree-SHA512: a6865b5c8b96eb0b622b3255971a3cf050dd0f5a356cdfcf7f0cbb659e4a363612e8e62b3ae4fd6b5d9a40bc29176891bc4690659b026c5ef8feea25c8e263cc		1 year ago
..
ISSUE_TEMPLATE	doc: Fill in the required skills in the good_first_issue template	1 year ago
workflows	Merge bitcoin/bitcoin#28573 : github actions: Fix test-one-commit when parent of head is merge commit	1 year ago
PULL_REQUEST_TEMPLATE.md	doc: Add redirect for GUI issues and pull requests	4 years ago