bitcoin

History

fanquake f1a9fd627b Merge bitcoin/bitcoin#28251 : validation: fix coins disappearing mid-package evaluation `32c1dd1ad6` [test] mempool coins disappearing mid-package evaluation (glozow) `a67f460c3f` [refactor] split setup in mempool_limit test (glozow) `d08696120e` [test framework] add ability to spend only confirmed utxos (glozow) `3ea71feb11` [validation] don't LimitMempoolSize in any subpackage submissions (glozow) `d227b7234c` [validation] return correct result when already-in-mempool tx gets evicted (glozow) `9698b81828` [refactor] back-fill results in AcceptPackage (glozow) `8ad7ad3392` [validation] make PackageMempoolAcceptResult members mutable (glozow) `03b87c11ca` [validation] add AcceptSubPackage to delegate Accept* calls and clean up m_view (glozow) `3f01a3dab1` [CCoinsViewMemPool] track non-base coins and allow Reset (glozow) `7d7f7a1189` [policy] check for duplicate txids in package (glozow) Pull request description: While we are evaluating a package, we split it into "subpackages" for evaluation (currently subpackages all have size 1 except the last one). If a subpackage has size 1, we may add a tx to mempool and call `LimitMempoolSize()`, which evicts transactions if the mempool gets full. We handle the case where the just-submitted transaction is evicted immediately, but we don't handle the case in which a transaction from a previous subpackage (either just submitted or already in mempool) is evicted. Mainly, since the coins created by the evicted transaction are cached in `m_view`, we don't realize the UTXO has disappeared until `CheckInputsFromMempoolAndCache` asserts that they exist. Also, the returned `PackageMempoolAcceptResult` reports that the transaction is in mempool even though it isn't anymore. Fix this by not calling `LimitMempoolSize()` until the very end, and editing the results map with "mempool full" if things fall out. Pointed out by instagibbs in `faeed687e5` on top of the v3 PR. ACKs for top commit: instagibbs: reACK `32c1dd1ad6` Tree-SHA512: 61e7f69db4712e5e5bfa27d037ab66bdd97f1bf60a8d9ffb96adb1f0609af012c810d681102ee5c7baec7b5fe8cb7c304a60c63ccc445d00d86a2b7f0e7ddb90		1 year ago
..
__init__.py	…
address.py	refactor: move address_to_scriptpubkey to address.py	2 years ago
authproxy.py	test: Rename EncodeDecimal to serialization_fallback	1 year ago
bdb.py	scripted-diff: Bump copyright headers	3 years ago
bip340_test_vectors.csv	tests: add BIP340 Schnorr signature support to test framework	4 years ago
blockfilter.py	test: add compact block filter (BIP158) helper routines	2 years ago
blocktools.py	refactor: use address_to_scriptpubkey to retrieve addresses scriptpubkey	2 years ago
coverage.py	test: fix PEP484 no implicit optional argument types errors	1 year ago
descriptors.py	…
ellswift.py	test: add ellswift test vectors from BIP324	1 year ago
ellswift_decode_test_vectors.csv	test: add ellswift test vectors from BIP324	1 year ago
key.py	test: add secp256k1 module with FE (field element) and GE (group element) classes	1 year ago
messages.py	test: add support for all networks in CAddress in messages.py	1 year ago
muhash.py	test: remove modinv python util helper function	2 years ago
netutil.py	scripted-diff: Bump copyright headers	2 years ago
p2p.py	test: Combine sync_send_with_ping and sync_with_ping	1 year ago
psbt.py	test: PSBT: eliminate magic numbers for global unsigned tx key (0)	2 years ago
ripemd160.py	Add pure Python RIPEMD-160	3 years ago
script.py	test: refactor: deduplicate legacy ECDSA signing for tx inputs	1 year ago
script_util.py	scripted-diff: Bump copyright headers	2 years ago
secp256k1.py	test: EC: optimize scalar multiplication of G by using lookup table	1 year ago
segwit_addr.py	Use Bech32m encoding for v1+ segwit addresses	4 years ago
siphash.py	test: python E721 updates	1 year ago
socks5.py	test: add keep_alive option to socks5 proxy in test_framework	1 year ago
test_framework.py	script, test: add missing python type annotations	1 year ago
test_node.py	Merge bitcoin/bitcoin#28199 : test: tx orphan handling	1 year ago
test_shell.py	scripted-diff: Bump copyright headers	2 years ago
util.py	test: fix PEP484 no implicit optional argument types errors	1 year ago
wallet.py	[test framework] add ability to spend only confirmed utxos	1 year ago
wallet_util.py	test: refactor: introduce `generate_keypair` helper with WIF support	1 year ago
xswiftec_inv_test_vectors.csv	test: add ellswift test vectors from BIP324	1 year ago