You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

merge-script 5ee6b76c69 Merge bitcoin/bitcoin#29325: consensus: Store transaction nVersion as uint32_t ... 429ec1aaaa refactor: Rename CTransaction::nVersion to version (Ava Chow) 27e70f1f5b consensus: Store transaction nVersion as uint32_t (Ava Chow) Pull request description: Given that the use of a transaction's nVersion is always as an unsigned int, it doesn't make sense to store it as signed and then cast it to unsigned everywhere it is used and displayed. Since a few alternative implementations have recently been revealed to have made an error with this signedness that would have resulted in consensus failure, I think it makes sense for us to just make this always unsigned to make it clear that the version is treated as unsigned. This would also help us avoid future potential issues with signedness of this value. I believe that this is safe and does not actually change what transactions would or would not be considered both standard and consensus valid. Within consensus, the only use of the version in consensus is in BIP68 validation which was already casting it to uint32_t. Within policy, although it is used as a signed int for the transaction version number check, I do not think that this change would change standardness. Standard transactions are limited to the range [1, 2]. Negative numbers would have fallen under the < 1 condition, but by making it unsigned, they are still non-standard under the > 2 condition. Unsigned and signed ints are serialized and unserialized the same way so there is no change in serialization. ACKs for top commit: maflcko: ACK 429ec1aaaa 🐿 glozow: ACK 429ec1aaaa shaavan: ACK 429ec1aaaa 💯 Tree-SHA512: 0bcd92a245d7d16c3665d2d4e815a4ef28207ad4a1fb46c6f0203cdafeab1b82c4e95e4bdce7805d80a4f4a46074f6542abad708e970550d38a00d759e3dcef1		5 months ago
..
crypto	crypto: add NUMS_H const	6 months ago
__init__.py	…
address.py	test: add MiniWallet tagging support to avoid UTXO mixing	6 months ago
authproxy.py	test: use json-rpc 2.0 in all functional tests by default	5 months ago
bdb.py	…
bip340_test_vectors.csv	…
blockfilter.py	Merge bitcoin/bitcoin#28605: Fix typos	12 months ago
blocktools.py	[test]: remove duplicate WITNESS_SCALE_FACTOR	6 months ago
coverage.py	test: fix PEP484 no implicit optional argument types errors	1 year ago
descriptors.py	…
key.py	Merge bitcoin/bitcoin#28374: test: python cryptography required for BIP 324 functional tests	1 year ago
mempool_util.py	test: use tagged ephemeral MiniWallet instance in fill_mempool	6 months ago
messages.py	refactor: Rename CTransaction::nVersion to version	5 months ago
netutil.py	test: cover UNIX sockets in feature_proxy.py	8 months ago
p2p.py	scripted-diff: test: Use int.to_bytes over struct packing	6 months ago
psbt.py	…
script.py	refactor: Rename CTransaction::nVersion to version	5 months ago
script_util.py	…
segwit_addr.py	…
socks5.py	test: add keep_alive option to socks5 proxy in test_framework	1 year ago
test_framework.py	test: Remove redundant verack check	5 months ago
test_node.py	Merge bitcoin/bitcoin#30132: indexes: Don't wipe indexes again when continuing a prior reindex	5 months ago
test_shell.py	…
util.py	test: refactor: move fill_mempool to new module mempool_util	6 months ago
v2_p2p.py	[test] make v2transport arg in addconnection mandatory and few cleanups	9 months ago
wallet.py	Merge bitcoin/bitcoin#29325: consensus: Store transaction nVersion as uint32_t	5 months ago
wallet_util.py	Fix typos in description.md and wallet_util.py	7 months ago