bitcoin

History

fanquake a7f28af437 Merge bitcoin/bitcoin#22646 : build: tighter Univalue integration, remove `--with-system-univalue` `0f95247246` Integrate univalue into our buildsystem (Cory Fields) `9b49ed656f` Squashed 'src/univalue/' changes from 98fadc0909..a44caf65fe (fanquake) Pull request description: This PR more tightly integrates building Univalue into our build system. This follows the same approach we use for [LevelDB](https://github.com/bitcoin-core/leveldb/), ([`Makefile.leveldb.include`](https://github.com/bitcoin/bitcoin/blob/master/src/Makefile.leveldb.include)), and [CRC32C](https://github.com/bitcoin-core/crc32c) ([`Makefile.crc32c.include`](https://github.com/bitcoin/bitcoin/blob/master/src/Makefile.crc32c.include)), and will be the same approach we use for [minisketch](https://github.com/sipa/minisketch); see #23114. This approach yields a number of benefits, including: * Faster configuration due to one less subconfigure being run during `./configure` i.e 22s with this PR vs 26s * Faster autoconf i.e 13s with this PR vs 17s * Improved caching * No more issues with compiler flags i.e https://github.com/bitcoin/bitcoin/pull/12467 * More direct control means we can build exactly the objects we want There might be one argument against making this change, which is that builders should have the option to use "proper shared/system libraries". However, I think that falls down for a few reasons. The first being that we already don't support building with a number of system libraries (secp256k1, leveldb, crc32c); some for good reason. Univalue is really the odd one out at the moment. Note that the only fork of Core I'm aware of, that actively patches in support for using system libs, also explicitly marks them as ["DANGEROUS"](`a886811721/configure.ac (L1430)`) and ["NOT SUPPORTED"](`a886811721/configure.ac (L1312)`). So it would seem they exist more to satisfy a distro requirement, as opposed to something that anyone should, or would actually use in practice. PRs like #22412 highlight the "issue" with us operating with our own Univalue fork, where we actively fix bugs, and make improvements, when upstream (https://github.com/jgarzik/univalue) may not be taking those improvements, and by all accounts, is not currently actively maintained. Bitcoin Core should not be hamstrung into not being able to fix bugs in a library, and/or have to litter our source with "workarounds", i.e #22412, for bugs we've already fixed, based on the fact that an upstream project is not actively being maintained. Allowing builders to use system libs is really only exacerbating this problem, with little benefit to our project. Bitcoin Core is not quite like your average piece of distro packaged software. There is the potential for us to give the same treatment to libsecp256k1, however it seems doing that is currently less straightforward. ACKs for top commit: dongcarl: ACK `0f95247246` less my comment above, always nice to have an include-able `sources.mk` which makes integration easier. theuni: ACK `0f95247246`. Thanks fanquake for keeping this going. Tree-SHA512: a7f2e41ee7cba06ae72388638e86b264eca1b9a8b81c15d1d7b45df960c88c3b91578b4ade020f8cc61d75cf8d16914575f9a78fa4cef9c12be63504ed804b99		3 years ago
..
builder-keys	builder-keys: add kristapsk	3 years ago
debian	…
devtools	lint: enable mypy checking for missing imports	3 years ago
guix	Merge bitcoin/bitcoin#22646 : build: tighter Univalue integration, remove `--with-system-univalue`	3 years ago
init	…
linearize	refactor: replace remaining binascii method calls	3 years ago
macdeploy	release: remove gitian	3 years ago
message-capture	…
qos	…
seeds	contrib, p2p: update I2P hardcoded seeds	3 years ago
shell	…
signet	contrib: Ask for captcha in signet getcoins.py	3 years ago
testgen	…
tracing	tracing: drop block_connected hash.toString() arg	3 years ago
verify-commits	contrib: use hkps://keys.openpgp.org to retrieve builder keys	3 years ago
verifybinaries	Fix typo in comment	3 years ago
windeploy	…
zmq	refactor: replace remaining binascii method calls	3 years ago
README.md	release: remove gitian	3 years ago
bitcoin-cli.bash-completion	…
bitcoin-tx.bash-completion	…
bitcoind.bash-completion	…
filter-lcov.py	…
install_db4.sh	contrib: use newer config.guess & config.sub in install_db4.sh	3 years ago
valgrind.supp	…

README.md

Repository Tools

Developer tools

Specific tools for developers working on this repository. Additional tools, including the github-merge.py script, are available in the maintainer-tools repository.

Verify-Commits

Tool to verify that every merge commit was signed by a developer using the github-merge.py script.

Linearize

Construct a linear, no-fork, best version of the blockchain.

A Linux bash script that will set up traffic control (tc) to limit the outgoing bandwidth for connections to the Bitcoin network. This means one can have an always-on bitcoind instance running, and another local bitcoind/bitcoin-qt instance which connects to this node and receives blocks from it.

Seeds

Utility to generate the pnSeed[] array that is compiled into the client.

Build Tools and Keys

Packaging

The Debian subfolder contains the copyright file.

All other packaging related files can be found in the bitcoin-core/packaging repository.

Builder keys

PGP keys used for signing Bitcoin Core release results.

MacDeploy

Scripts and notes for Mac builds.

Test and Verify Tools

TestGen

Utilities to generate test vectors for the data-driven Bitcoin tests.

Verify Binaries

This script attempts to download and verify the signature file SHA256SUMS.asc from bitcoin.org.