You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
bitcoin/test/functional
MarcoFalke fa88c043d1
test: Fix intermittent feature_rbf issue
2 years ago
..
data scripted-diff: Bump copyright headers 2 years ago
mocks script, test: fix python linter E275 errors with flake8 5.0.4 2 years ago
test_framework scripted-diff: Use new python 3.7 keywords 2 years ago
.gitignore
README.md
combine_logs.py
combined_log_template.html
create_cache.py
example_test.py scripted-diff: Bump copyright headers 2 years ago
feature_abortnode.py
feature_addrman.py scripted-diff: Bump copyright headers 2 years ago
feature_anchors.py
feature_asmap.py
feature_assumevalid.py scripted-diff: Bump copyright headers 2 years ago
feature_bind_extra.py scripted-diff: Bump copyright headers 2 years ago
feature_bind_port_discover.py
feature_bind_port_externalip.py
feature_bip68_sequence.py test: remove redundant blocks generation logic 2 years ago
feature_block.py scripted-diff: Bump copyright headers 2 years ago
feature_blocksdir.py
feature_cltv.py scripted-diff: Bump copyright headers 2 years ago
feature_coinstatsindex.py script, test: fix python linter E275 errors with flake8 5.0.4 2 years ago
feature_config_args.py scripted-diff: Bump copyright headers 2 years ago
feature_csv_activation.py scripted-diff: Bump copyright headers 2 years ago
feature_dbcrash.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
feature_dersig.py scripted-diff: Bump copyright headers 2 years ago
feature_dirsymlinks.py
feature_discover.py test: add functional test for -discover 2 years ago
feature_fee_estimation.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
feature_filelock.py scripted-diff: Bump copyright headers 2 years ago
feature_help.py
feature_includeconf.py
feature_index_prune.py script, test: fix python linter E275 errors with flake8 5.0.4 2 years ago
feature_init.py scripted-diff: Bump copyright headers 2 years ago
feature_loadblock.py
feature_logging.py
feature_maxtipage.py test: add -maxtipage test for the maximum allowable value 2 years ago
feature_maxuploadtarget.py scripted-diff: Bump copyright headers 2 years ago
feature_minchainwork.py scripted-diff: Bump copyright headers 2 years ago
feature_notifications.py Merge bitcoin/bitcoin#23395: util: Add -shutdownnotify option 2 years ago
feature_nulldummy.py scripted-diff: Bump copyright headers 2 years ago
feature_presegwit_node_upgrade.py
feature_proxy.py scripted-diff: Bump copyright headers 2 years ago
feature_pruning.py rpc: Return accurate results for scanblocks 2 years ago
feature_rbf.py test: Fix intermittent feature_rbf issue 2 years ago
feature_reindex.py Faster -reindex by initially deserializing only headers 2 years ago
feature_segwit.py scripted-diff: Bump copyright headers 2 years ago
feature_settings.py
feature_shutdown.py
feature_signet.py scripted-diff: Bump copyright headers 2 years ago
feature_startupnotify.py test: Fix feature_startupnotify intermittent issue 2 years ago
feature_syscall_sandbox.py scripted-diff: Bump copyright headers 2 years ago
feature_taproot.py scripted-diff: Bump copyright headers 2 years ago
feature_txindex_compatibility.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
feature_uacomment.py
feature_unsupported_utxo_db.py
feature_utxo_set_hash.py scripted-diff: Bump copyright headers 2 years ago
feature_versionbits_warning.py scripted-diff: Bump copyright headers 2 years ago
interface_bitcoin_cli.py scripted-diff: Bump copyright headers 2 years ago
interface_http.py
interface_rest.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
interface_rpc.py scripted-diff: Bump copyright headers 2 years ago
interface_usdt_coinselection.py test: Remove wallet option from non-wallet tests 2 years ago
interface_usdt_net.py
interface_usdt_utxocache.py test: remove redundant blocks generation logic 2 years ago
interface_usdt_validation.py script, test: fix python linter E275 errors with flake8 5.0.4 2 years ago
interface_zmq.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
mempool_accept.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
mempool_accept_wtxid.py
mempool_compatibility.py scripted-diff: Bump copyright headers 2 years ago
mempool_datacarrier.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
mempool_dust.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
mempool_expiry.py test: simplify tests by using the pre-mined chain 2 years ago
mempool_limit.py test: remove `-spendzeroconfchange` setting from mempool_limit.py 2 years ago
mempool_package_limits.py test: Return chain of MiniWallet txs from MiniWallet chain method 2 years ago
mempool_package_onemore.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
mempool_packages.py test: Run mempool_packages.py with MiniWallet 2 years ago
mempool_persist.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
mempool_reorg.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
mempool_resurrect.py test: simplify tests by using the pre-mined chain 2 years ago
mempool_spend_coinbase.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
mempool_unbroadcast.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
mempool_updatefromblock.py scripted-diff: Bump copyright headers 2 years ago
mining_basic.py scripted-diff: Bump copyright headers 2 years ago
mining_getblocktemplate_longpoll.py test: remove redundant blocks generation logic 2 years ago
mining_prioritisetransaction.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
p2p_add_connections.py
p2p_addr_relay.py script, test: fix python linter E275 errors with flake8 5.0.4 2 years ago
p2p_addrfetch.py
p2p_addrv2_relay.py
p2p_block_sync.py
p2p_blockfilters.py scripted-diff: Bump copyright headers 2 years ago
p2p_blocksonly.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
p2p_compactblocks.py scripted-diff: Bump copyright headers 2 years ago
p2p_compactblocks_blocksonly.py
p2p_compactblocks_hb.py
p2p_disconnect_ban.py test: Fix wrong types passed to RPCs 2 years ago
p2p_dns_seeds.py
p2p_dos_header_tree.py scripted-diff: Bump copyright headers 2 years ago
p2p_eviction.py
p2p_feefilter.py test: remove redundant blocks generation logic 2 years ago
p2p_filter.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
p2p_fingerprint.py
p2p_getaddr_caching.py script, test: fix python linter E275 errors with flake8 5.0.4 2 years ago
p2p_getdata.py
p2p_headers_sync_with_minchainwork.py script, test: fix python linter E275 errors with flake8 5.0.4 2 years ago
p2p_i2p_ports.py
p2p_i2p_sessions.py doc: clarify -i2pacceptincoming help documentation 2 years ago
p2p_ibd_txrelay.py
p2p_initial_headers_sync.py
p2p_invalid_block.py
p2p_invalid_locator.py
p2p_invalid_messages.py
p2p_invalid_tx.py scripted-diff: Bump copyright headers 2 years ago
p2p_leak.py scripted-diff: Bump copyright headers 2 years ago
p2p_leak_tx.py test: remove redundant blocks generation logic 2 years ago
p2p_message_capture.py script, test: fix python linter E275 errors with flake8 5.0.4 2 years ago
p2p_nobloomfilter_messages.py
p2p_node_network_limited.py
p2p_permissions.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
p2p_ping.py scripted-diff: Bump copyright headers 2 years ago
p2p_segwit.py [rpc] return effective-includes in testmempoolaccept and submitpackage 2 years ago
p2p_sendheaders.py
p2p_sendtxrcncl.py test, refactor: Reorder sendtxrcncl tests for better readability 2 years ago
p2p_timeouts.py scripted-diff: Bump copyright headers 2 years ago
p2p_tx_download.py
p2p_tx_privacy.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
p2p_unrequested_blocks.py scripted-diff: Bump copyright headers 2 years ago
rpc_bind.py
rpc_blockchain.py script, test: fix python linter E275 errors with flake8 5.0.4 2 years ago
rpc_createmultisig.py scripted-diff: Bump copyright headers 2 years ago
rpc_decodescript.py scripted-diff: Bump copyright headers 2 years ago
rpc_deprecated.py
rpc_deriveaddresses.py scripted-diff: Bump copyright headers 2 years ago
rpc_dumptxoutset.py scripted-diff: Bump copyright headers 2 years ago
rpc_estimatefee.py scripted-diff: Bump copyright headers 2 years ago
rpc_generate.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
rpc_getblockfilter.py
rpc_getblockfrompeer.py scripted-diff: Bump copyright headers 2 years ago
rpc_getblockstats.py test: Test exclusion of OP_RETURN from getblockstats 2 years ago
rpc_getchaintips.py
rpc_getdescriptorinfo.py RPC: unify arg type error message 2 years ago
rpc_help.py scripted-diff: Bump copyright headers 2 years ago
rpc_invalid_address_message.py test: Add test for missing and omitted required arg 2 years ago
rpc_invalidateblock.py scripted-diff: Bump copyright headers 2 years ago
rpc_mempool_info.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
rpc_misc.py scripted-diff: Bump copyright headers 2 years ago
rpc_named_arguments.py scripted-diff: Bump copyright headers 2 years ago
rpc_net.py test: simplify tests by using the pre-mined chain 2 years ago
rpc_packages.py test: Return chain of MiniWallet txs from MiniWallet chain method 2 years ago
rpc_preciousblock.py
rpc_psbt.py Wallet/RPC: Allow specifying min & max chain depth for inputs used by fund calls 2 years ago
rpc_rawtransaction.py test: simplify tests by using the pre-mined chain 2 years ago
rpc_scanblocks.py Merge bitcoin/bitcoin#26886: test: add `rescan utxos` inside MiniWallet's initialization 2 years ago
rpc_scantxoutset.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
rpc_setban.py
rpc_signer.py scripted-diff: Bump copyright headers 2 years ago
rpc_signmessagewithprivkey.py scripted-diff: Bump copyright headers 2 years ago
rpc_signrawtransactionwithkey.py
rpc_txoutproof.py test: simplify tests by using the pre-mined chain 2 years ago
rpc_uptime.py scripted-diff: Bump copyright headers 2 years ago
rpc_users.py scripted-diff: Use new python 3.7 keywords 2 years ago
rpc_whitelist.py
test-shell.md doc: test: update/fix TestShell example instructions 2 years ago
test_runner.py scripted-diff: Use new python 3.7 keywords 2 years ago
tool_signet_miner.py test: Remove wallet option from non-wallet tests 2 years ago
tool_wallet.py scripted-diff: Use new python 3.7 keywords 2 years ago
wallet_abandonconflict.py scripted-diff: Bump copyright headers 2 years ago
wallet_address_types.py scripted-diff: Bump copyright headers 2 years ago
wallet_avoid_mixing_output_types.py test: Remove wallet option from non-wallet tests 2 years ago
wallet_avoidreuse.py script, test: fix python linter E275 errors with flake8 5.0.4 2 years ago
wallet_backup.py scripted-diff: Bump copyright headers 2 years ago
wallet_backwards_compatibility.py script, test: fix python linter E275 errors with flake8 5.0.4 2 years ago
wallet_balance.py scripted-diff: Bump copyright headers 2 years ago
wallet_basic.py test: wallet: add coverage for `-spendzeroconfchange` setting 2 years ago
wallet_bumpfee.py Merge bitcoin/bitcoin#26675: wallet: For feebump, ignore abandoned descendant spends 2 years ago
wallet_coinbase_category.py scripted-diff: Bump copyright headers 2 years ago
wallet_create_tx.py scripted-diff: Bump copyright headers 2 years ago
wallet_createwallet.py scripted-diff: Bump copyright headers 2 years ago
wallet_crosschain.py Merge bitcoin/bitcoin#26747: wallet: fix confusing error / GUI crash on cross-chain legacy wallet restore 2 years ago
wallet_descriptor.py Merge bitcoin/bitcoin#26039: refactor: Run type check against RPCArgs (1/2) 2 years ago
wallet_disable.py scripted-diff: Bump copyright headers 2 years ago
wallet_dump.py scripted-diff: Bump copyright headers 2 years ago
wallet_encryption.py scripted-diff: Bump copyright headers 2 years ago
wallet_fallbackfee.py scripted-diff: Bump copyright headers 2 years ago
wallet_fast_rescan.py test: add `rescan_utxos` in MiniWallet's initialization 2 years ago
wallet_fundrawtransaction.py Wallet/RPC: Allow specifying min & max chain depth for inputs used by fund calls 2 years ago
wallet_groups.py scripted-diff: Bump copyright headers 2 years ago
wallet_hd.py scripted-diff: Bump copyright headers 2 years ago
wallet_implicitsegwit.py script, test: fix python linter E275 errors with flake8 5.0.4 2 years ago
wallet_import_rescan.py scripted-diff: Bump copyright headers 2 years ago
wallet_import_with_label.py scripted-diff: Bump copyright headers 2 years ago
wallet_importdescriptors.py test: Remove redundant function call 2 years ago
wallet_importmulti.py scripted-diff: Bump copyright headers 2 years ago
wallet_importprunedfunds.py scripted-diff: Bump copyright headers 2 years ago
wallet_inactive_hdchains.py scripted-diff: Bump copyright headers 2 years ago
wallet_keypool.py scripted-diff: Bump copyright headers 2 years ago
wallet_keypool_topup.py scripted-diff: Bump copyright headers 2 years ago
wallet_labels.py Merge bitcoin/bitcoin#26730: test: add coverage for `purpose` arg in `listlabels` 2 years ago
wallet_listdescriptors.py scripted-diff: Bump copyright headers 2 years ago
wallet_listreceivedby.py scripted-diff: Bump copyright headers 2 years ago
wallet_listsinceblock.py scripted-diff: Bump copyright headers 2 years ago
wallet_listtransactions.py scripted-diff: Bump copyright headers 2 years ago
wallet_migration.py test: wallet: check that labels are migrated to watchonly wallet 2 years ago
wallet_miniscript.py test: Remove wallet option from non-wallet tests 2 years ago
wallet_multisig_descriptor_psbt.py scripted-diff: Bump copyright headers 2 years ago
wallet_multiwallet.py Merge bitcoin/bitcoin#26192: rpc: Improve error when wallet is already loaded 2 years ago
wallet_orphanedreward.py scripted-diff: Bump copyright headers 2 years ago
wallet_pruning.py test: Wallet imports on pruned nodes 2 years ago
wallet_reorgsrestore.py script, test: fix python linter E275 errors with flake8 5.0.4 2 years ago
wallet_resendwallettransactions.py scripted-diff: Bump copyright headers 2 years ago
wallet_send.py Wallet/RPC: Allow specifying min & max chain depth for inputs used by fund calls 2 years ago
wallet_sendall.py rpc: add minconf and maxconf options to sendall 2 years ago
wallet_signer.py script, test: fix python linter E275 errors with flake8 5.0.4 2 years ago
wallet_signmessagewithaddress.py scripted-diff: Bump copyright headers 2 years ago
wallet_signrawtransactionwithwallet.py scripted-diff: Bump copyright headers 2 years ago
wallet_simulaterawtx.py scripted-diff: Bump copyright headers 2 years ago
wallet_startup.py scripted-diff: Bump copyright headers 2 years ago
wallet_taproot.py script, test: fix python linter E275 errors with flake8 5.0.4 2 years ago
wallet_timelock.py test: Remove wallet option from non-wallet tests 2 years ago
wallet_transactiontime_rescan.py scripted-diff: Bump copyright headers 2 years ago
wallet_txn_clone.py scripted-diff: Bump copyright headers 2 years ago
wallet_txn_doublespend.py scripted-diff: Bump copyright headers 2 years ago
wallet_upgradewallet.py scripted-diff: Bump copyright headers 2 years ago
wallet_watchonly.py scripted-diff: Bump copyright headers 2 years ago

README.md

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports.
  • If more than one name from a module is needed, use lexicographically sorted multi-line imports in order to reduce the possibility of potential merge conflicts.
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: