You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

fanquake 01ebaa05a4 Merge #16572: wallet: Fix Char as Bool in Wallet ... 2dbfb37b40 Fix Char as Bool in interfaces (Jeremy Rubin) Pull request description: In a few places in src/wallet/wallet.h, we use a char when semantically we want a bool. This is kind of an issue because it means we can unserialize the same transaction with different fFromMe flags (as differing chars) and evaluate the following section in wallet/wallet.cpp ```c++ if (wtxIn.fFromMe && wtxIn.fFromMe != wtx.fFromMe) { wtx.fFromMe = wtxIn.fFromMe; fUpdated = true; } ``` incorrectly (triggering an fUpdated where both fFromMe values represent true, via different chars). I don't think this is a vulnerability, but it's just a little messy and unsemantic, and could lead to issues with stored wtxIns not being findable in a map by their hash. The serialize/unserialize code for bool internally uses a char, so it should be safe to make this substitution. NOTE: Technically, this is a behavior change -- I haven't checked too closely that nowhere is depending on storing information in this char. Theoretically, this could break something because after this change a tx unserialized with such a char would preserve it's value, but now it is converted to a ~true~ canonical bool. ACKs for top commit: achow101: Code review ACK 2dbfb37b40 meshcollider: Code review ACK 2dbfb37b40 Tree-SHA512: 8c0dc9cf672aa2276c694facbf50febe7456eaa8bf2bd2504f81a61052264b8b30cdb5326e1936893adc3d33504667aee3c7e207a194c71d87b3e7b5fe199c9d		5 years ago
..
test	Merge #16277: [Tests] Suppress output in test_bitcoin for expected errors	5 years ago
coincontrol.cpp	extract min & max depth onto coin control	5 years ago
coincontrol.h	extract min & max depth onto coin control	5 years ago
coinselection.cpp	Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection	6 years ago
coinselection.h	…
crypter.cpp	Remove CCryptoKeyStore and move all of it's functionality into CWallet	5 years ago
crypter.h	Remove CCryptoKeyStore and move all of it's functionality into CWallet	5 years ago
db.cpp	Merge #15588: Log the actual wallet file version and no longer publicly expose the "version" record	5 years ago
db.h	Merge #15588: Log the actual wallet file version and no longer publicly expose the "version" record	5 years ago
feebumper.cpp	Restrict lifetime of ReserveDestination to CWallet::CreateTransaction	5 years ago
feebumper.h	scripted-diff: Bump copyright headers in wallet	6 years ago
fees.cpp	[wallet] abort when attempting to fund a transaction above maxtxfee	5 years ago
fees.h	Remove uses of fee globals in wallet code	6 years ago
init.cpp	Use ArgsManager::NETWORK_ONLY flag	5 years ago
ismine.cpp	Move various SigningProviders to signingprovider.{cpp,h}	5 years ago
ismine.h	Change ismine to take a CWallet instead of CKeyStore	5 years ago
load.cpp	scripted-diff: Make translation bilingual	5 years ago
load.h	scripted-diff: Bump copyright headers in wallet	6 years ago
psbtwallet.cpp	Merge #15427: Add support for descriptors to utxoupdatepsbt	5 years ago
psbtwallet.h	Remove unused TransactionError constants	6 years ago
rpcdump.cpp	Give more errors for specific failure conditions	5 years ago
rpcwallet.cpp	Merge #16383: rpcwallet: default include_watchonly to true for watchonly wallets	5 years ago
rpcwallet.h	Merge #15870: wallet: Only fail rescan when blocks have actually been pruned	6 years ago
wallet.cpp	[wallet] Restore confirmed/conflicted tx check in SubmitMemoryPoolAndRelay()	5 years ago
wallet.h	Merge #16572: wallet: Fix Char as Bool in Wallet	5 years ago
walletdb.cpp	wallet: Drop unused OldKey	5 years ago
walletdb.h	Add setting as known type	5 years ago
wallettool.cpp	scripted-diff: Replace fprintf with tfm::format	6 years ago
wallettool.h	Move ismine to wallet module	5 years ago
walletutil.cpp	Merge #15870: wallet: Only fail rescan when blocks have actually been pruned	6 years ago
walletutil.h	…