You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

MarcoFalke a421e0a22f Merge #18376: net: fix use-after-free in tests ... 7d8e1dec3b net: fix use-after-free in tests (Vasil Dimov) Pull request description: In PeerLogicValidation::PeerLogicValidation() we would schedule a lambda function to execute later, capturing the local variable `consensusParams` by reference. Presumably this was considered safe because `consensusParams` is a reference itself to a global variable which is not supposed to change, but it can in tests. Fixes https://github.com/bitcoin/bitcoin/issues/18372 <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. --> <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. --> <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. --> ACKs for top commit: sipa: ACK 7d8e1dec3b practicalswift: ACK 7d8e1dec3b MarcoFalke: ACK 7d8e1dec3b Tree-SHA512: fe0f6e5fac1976d38dfb249517eef142dcb8837e178d7d199e5e854e3ab428822c6da9d96fe312293d39b6c6cac0c97896f3b5760013db200cccd729ae1b0710		5 years ago
..
bench	Merge #16902: O(1) OP_IF/NOTIF/ELSE/ENDIF script implementation	5 years ago
compat	scripted-diff: Bump copyright of files changed in 2019	5 years ago
config	…
consensus	Update merkle.cpp	5 years ago
crc32c	Import crc32c using subtree merge as as 'src/crc32c'	5 years ago
crypto	Merge #17691: doc: Add missed copyright headers	5 years ago
index	make BlockUntilSyncedToCurrentChain() const	5 years ago
interfaces	Replace GetSigningProvider with GetSolvingProvider	5 years ago
leveldb	Update to leveldb upstream using subtree merge	5 years ago
logging	doc: Correct spelling errors in comments	5 years ago
node	doc: Correct spelling errors in comments	5 years ago
policy	scripted-diff: Bump copyright of files changed in 2020	5 years ago
primitives	scripted-diff: Bump copyright of files changed in 2019	5 years ago
qt	qt: Periodical translations update	5 years ago
rpc	Merge #18346: rpc: Document an RPCResult for all calls; Enforce at compile time	5 years ago
script	Merge #16902: O(1) OP_IF/NOTIF/ELSE/ENDIF script implementation	5 years ago
secp256k1	…
support	scripted-diff: Bump copyright of files changed in 2019	5 years ago
test	Merge #18155: tests: Add harness which fuzzes EvalScript and VerifyScript using a fuzzed signature checker	5 years ago
univalue	Update univalue subtree	5 years ago
util	Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyMan	5 years ago
wallet	Merge #18289: refactor: Make scheduler methods type safe	5 years ago
zmq	rpc: Auto-format RPCResult	5 years ago
.clang-format	util: Add AllowShortCaseLabelsOnASingleLine option	5 years ago
Makefile.am	Move FillPSBT to be a member of CWallet	5 years ago
Makefile.bench.include	[test] move wallet helper functions into test library	5 years ago
Makefile.crc32c.include	build: CRC32C build system integration	5 years ago
Makefile.leveldb.include	build: CRC32C build system integration	5 years ago
Makefile.qt.include	Merge #17513: refactor, qt: Nuke some circular dependencies	5 years ago
Makefile.qt_locale.include	Restore English translation option	5 years ago
Makefile.qttest.include	build: Create test utility library from src/test/util/	5 years ago
Makefile.test.include	tests: Add harness which fuzzes EvalScript and VerifyScript using a fuzzed signature checker	5 years ago
Makefile.test_util.include	[test] move wallet helper functions into test library	5 years ago
addrdb.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
addrdb.h	Convert addrdb/addrman to new serialization	5 years ago
addrman.cpp	logging: asmap logging and #include fixups	5 years ago
addrman.h	logging: asmap logging and #include fixups	5 years ago
amount.h	…
arith_uint256.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
arith_uint256.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
attributes.h	…
banman.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
banman.h	refactor: move DUMP_BANS_INTERVAL to banman.h	5 years ago
base58.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
base58.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
bech32.cpp	Add some general std::vector utility functions	5 years ago
bech32.h	Assert that the HRP is lowercase in Bech32::Encode	5 years ago
bitcoin-cli-res.rc	…
bitcoin-cli.cpp	scripted-diff: Replace MilliSleep with UninterruptibleSleep	5 years ago
bitcoin-tx-res.rc	…
bitcoin-tx.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
bitcoin-wallet-res.rc	…
bitcoin-wallet.cpp	bitcoin-wallet: Use PACKAGE_NAME in usage help	5 years ago
bitcoind-res.rc	…
bitcoind.cpp	scripted-diff: Replace MilliSleep with UninterruptibleSleep	5 years ago
blockencodings.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
blockencodings.h	Convert blockencodings.h to new serialization framework	5 years ago
blockfilter.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
blockfilter.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
bloom.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
bloom.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
chain.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
chain.h	Get rid of VARINT default argument	5 years ago
chainparams.cpp	[test] add chainparams property to indicate chain allows time mocking	5 years ago
chainparams.h	[test] add chainparams property to indicate chain allows time mocking	5 years ago
chainparamsbase.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
chainparamsbase.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
chainparamsseeds.h	contrib: Remove invalid nodes from seeds list	5 years ago
checkqueue.h	refactor: Remove redundant conditional	5 years ago
clientversion.cpp	…
clientversion.h	…
coins.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
coins.h	Convert compression.h to new serialization framework	5 years ago
compat.h	…
compressor.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
compressor.h	Merge #17917: tests: Add amount compression/decompression fuzzing to existing fuzzing harness	5 years ago
core_io.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
core_memusage.h	…
core_read.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
core_write.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
cuckoocache.h	Use correct C++11 header for std::swap()	5 years ago
dbwrapper.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
dbwrapper.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
dummywallet.cpp	scripted-diff: Bump copyright of files changed in 2020	5 years ago
flatfile.cpp	…
flatfile.h	Get rid of VARINT default argument	5 years ago
fs.cpp	scripted-diff: Add missed copyright headers	5 years ago
fs.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
hash.cpp	…
hash.h	…
httprpc.cpp	scripted-diff: Replace MilliSleep with UninterruptibleSleep	5 years ago
httprpc.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
httpserver.cpp	httpserver: use own HTTP status codes	5 years ago
httpserver.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
indirectmap.h	Add missing includes	5 years ago
init.cpp	Merge #18289: refactor: Make scheduler methods type safe	5 years ago
init.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
key.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
key.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
key_io.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
key_io.h	…
limitedmap.h	…
logging.cpp	scripted-diff: Bump copyright of files changed in 2020	5 years ago
logging.h	scripted-diff: Bump copyright of files changed in 2020	5 years ago
memusage.h	Add missing includes	5 years ago
merkleblock.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
merkleblock.h	…
miner.cpp	Refactor FormatStateMessage into ValidationState	5 years ago
miner.h	rpc: Remove mempool global from miner	5 years ago
net.cpp	scheduler: Make schedule* methods type safe	5 years ago
net.h	refactor: Convert ping wait time from double to int64_t	5 years ago
net_permissions.cpp	net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface	5 years ago
net_permissions.h	net: Remove forcerelay of rejected txs	5 years ago
net_processing.cpp	net: fix use-after-free in tests	5 years ago
net_processing.h	refactor: Remove mempool global from net	5 years ago
net_types.h	refactor: Remove addrdb.h dependency from node.h	5 years ago
netaddress.cpp	net: extract conditional to bool CNetAddr::IsHeNet	5 years ago
netaddress.h	net: extract conditional to bool CNetAddr::IsHeNet	5 years ago
netbase.cpp	Merge #17754: net: Don't allow resolving of std::string with embedded NUL characters. Add tests.	5 years ago
netbase.h	net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface	5 years ago
netmessagemaker.h	…
noui.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
noui.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
optional.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
outputtype.cpp	Revert "Store p2sh scripts in AddAndGetDestinationForScript"	5 years ago
outputtype.h	List output types in an array in order to be iterated over	5 years ago
pow.cpp	…
pow.h	…
prevector.h	Make VectorFormatter support stateful formatters	5 years ago
protocol.cpp	p2p: Remove BIP61 reject messages	5 years ago
protocol.h	Merge #17474: Bugfix: GUI: Recognise NETWORK_LIMITED in formatServicesStr	5 years ago
psbt.cpp	Merge #17156: psbt: check that various indexes and amounts are within bounds	5 years ago
psbt.h	Fix doxygen errors	5 years ago
pubkey.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
pubkey.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
random.cpp	doc: fix GetTimeMicros() comment in random.cpp	5 years ago
random.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
randomenv.cpp	Drop unused mach time headers	5 years ago
randomenv.h	[MOVEONLY] Move perfmon data gathering to new randomenv module	5 years ago
rest.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
reverse_iterator.h	…
scheduler.cpp	scheduler: Make schedule* methods type safe	5 years ago
scheduler.h	scheduler: Make schedule* methods type safe	5 years ago
serialize.h	Merge #18112: Serialization improvements step 5 (blockencodings)	5 years ago
shutdown.cpp	…
shutdown.h	…
span.h	…
streams.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
sync.cpp	sync.h: add REVERSE_LOCK	5 years ago
sync.h	Fix missing header in sync.h	5 years ago
threadinterrupt.cpp	…
threadinterrupt.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
threadsafety.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
timedata.cpp	scripted-diff: Bump copyright of files changed in 2020	5 years ago
timedata.h	…
tinyformat.h	util: Update tinyformat to upstream	5 years ago
torcontrol.cpp	net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface	5 years ago
torcontrol.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
txdb.cpp	Get rid of VARINT default argument	5 years ago
txdb.h	scripted-diff: Bump copyright of files changed in 2020	5 years ago
txmempool.cpp	Make UpdateTransactionsFromBlock use Epochs	5 years ago
txmempool.h	doc: Correct spelling errors in comments	5 years ago
ui_interface.cpp	scripted-diff: Bump copyright of files changed in 2020	5 years ago
ui_interface.h	scripted-diff: Bump copyright of files changed in 2020	5 years ago
uint256.cpp	refactor: define a UINT256_ONE global constant	5 years ago
uint256.h	refactor: define a UINT256_ONE global constant	5 years ago
undo.h	Convert undo.h to new serialization framework	5 years ago
validation.cpp	Merge #15283: log: Fix UB with bench on genesis block	5 years ago
validation.h	scripted-diff: Bump copyright of files changed in 2020	5 years ago
validationinterface.cpp	Refactor FormatStateMessage into ValidationState	5 years ago
validationinterface.h	scripted-diff: Bump copyright of files changed in 2020	5 years ago
version.h	…
versionbits.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
versionbits.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
versionbitsinfo.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
versionbitsinfo.h	…
walletinitinterface.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago
warnings.cpp	scripted-diff: Bump copyright of files changed in 2019	5 years ago
warnings.h	scripted-diff: Bump copyright of files changed in 2019	5 years ago