You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
bitcoin/test/functional
Andrew Chow 1abbae65eb
Merge bitcoin/bitcoin#24584: wallet: avoid mixing different `OutputTypes` during coin selection
2 years ago
..
data tests: Test taproot fields for PSBT 2 years ago
mocks Check descriptors returned by external signers 3 years ago
test_framework test: support passing PSBTMaps directly to PSBT ctor 2 years ago
.gitignore
README.md doc: Fix a link to `test/lint/lint-python.py` 3 years ago
combine_logs.py
combined_log_template.html
create_cache.py
example_test.py
feature_abortnode.py
feature_addrman.py streams: Add AutoFile without ser-type and ser-version 2 years ago
feature_anchors.py Merge bitcoin/bitcoin#23392: test: move check_node_connections to util 3 years ago
feature_asmap.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 3 years ago
feature_assumevalid.py test: refactor: take use of `create_block` txlist parameter 3 years ago
feature_backwards_compatibility.py test: previous releases: add v23.0 3 years ago
feature_bind_extra.py test: Fix out-of-range port collisions 2 years ago
feature_bind_port_discover.py net: only assume all local addresses if listening on any 3 years ago
feature_bind_port_externalip.py net: fix GetListenPort() to derive the proper port 3 years ago
feature_bip68_sequence.py test: refactor: take use of `create_block` txlist parameter 3 years ago
feature_block.py test: refactor: add constant for sequence number `SEQUENCE_FINAL` 3 years ago
feature_blocksdir.py
feature_cltv.py Merge bitcoin/bitcoin#23508: Add getdeploymentinfo RPC 3 years ago
feature_coinstatsindex.py test: stop node before calling assert_start_raises_init_error 3 years ago
feature_config_args.py Merge bitcoin/bitcoin#24830: init: Allow -proxy="" setting values 3 years ago
feature_csv_activation.py test: MiniWallet: always rehash after signing (P2PK mode) 3 years ago
feature_dbcrash.py test: pass `dustrelayfee=0` option for tests using dust (instead of `acceptnonstdtxn=1`) 2 years ago
feature_dersig.py Merge bitcoin/bitcoin#23508: Add getdeploymentinfo RPC 3 years ago
feature_dirsymlinks.py test: Run symlink regression tests on Windows 3 years ago
feature_fee_estimation.py test: Return new_utxos from create_self_transfer_multi in MiniWallet 2 years ago
feature_filelock.py
feature_help.py
feature_includeconf.py
feature_index_prune.py Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block 2 years ago
feature_init.py test: Fix wait_for_debug_log UnicodeDecodeError 2 years ago
feature_loadblock.py
feature_logging.py
feature_maxtipage.py test: add functional test for `-maxtipage` parameter 3 years ago
feature_maxuploadtarget.py test: pass `datacarriersize` option for tests using large outputs (instead of `acceptnonstdtxn`) 2 years ago
feature_minchainwork.py test: remove unnecessary parens 2 years ago
feature_notifications.py
feature_nulldummy.py test: remove wallet dependency from feature_nulldummy.py 2 years ago
feature_presegwit_node_upgrade.py
feature_proxy.py test: Fix out-of-range port collisions 2 years ago
feature_pruning.py Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block 2 years ago
feature_rbf.py scripted-diff: [test] Rename BIP125_SEQUENCE_NUMBER to MAX_BIP125_RBF_SEQUENCE 2 years ago
feature_reindex.py
feature_segwit.py test: Fix generate calls and comments in feature_segwit 3 years ago
feature_settings.py
feature_shutdown.py
feature_signet.py test: Fail if connect_nodes fails 2 years ago
feature_startupnotify.py test: wait rather than assert presence of file in startupnotify test 3 years ago
feature_syscall_sandbox.py test: Properly skip feature_syscall_sandbox in valgrind 3 years ago
feature_taproot.py refactor: move helper `random_bytes` to util library 2 years ago
feature_txindex_compatibility.py Replace "can not" with "cannot" in docs, user messages, and tests 3 years ago
feature_uacomment.py
feature_unsupported_utxo_db.py Remove utxo db upgrade code 3 years ago
feature_utxo_set_hash.py Remove buggy and confusing IncrementExtraNonce 3 years ago
feature_versionbits_warning.py test, contrib, refactor: use `with` when opening a file 3 years ago
interface_bitcoin_cli.py test: fix test feature_coinstatsindex.py for descriptor wallets 3 years ago
interface_http.py
interface_rest.py test: compare `/mempool/info` response with `getmempoolinfo` RPC 3 years ago
interface_rpc.py
interface_usdt_coinselection.py test: Add test for coinselection tracepoints 3 years ago
interface_usdt_net.py test: net:in/out_message tracepoint tests 3 years ago
interface_usdt_utxocache.py test: fix failing test interface_usdt_utxocache.py 2 years ago
interface_usdt_validation.py test: validation:block_connected tracepoint test 3 years ago
interface_zmq.py [move only] remove `is_wallet_compiled` checks 3 years ago
mempool_accept.py scripted-diff: [test] Rename BIP125_SEQUENCE_NUMBER to MAX_BIP125_RBF_SEQUENCE 2 years ago
mempool_accept_wtxid.py
mempool_compatibility.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 3 years ago
mempool_expiry.py scripted-diff: Rename DEFAULT_MEMPOOL_EXPIRY to indicate time unit 2 years ago
mempool_limit.py test: pass `datacarriersize` option for tests using large outputs (instead of `acceptnonstdtxn`) 2 years ago
mempool_package_limits.py
mempool_package_onemore.py test: use MiniWallet for mempool_package_onemore.py 3 years ago
mempool_packages.py Add RPC to get mempool txs spending outputs 3 years ago
mempool_persist.py test/mempool_persist: Test manual savemempool when -persistmempool=0 2 years ago
mempool_reorg.py test: Return new_utxo from create_self_transfer in MiniWallet 2 years ago
mempool_resurrect.py
mempool_spend_coinbase.py test: Remove MiniWallet mempool_valid option 2 years ago
mempool_unbroadcast.py test: Remove from_node from create_self_transfer* MiniWallet helpers 2 years ago
mempool_updatefromblock.py test: remove wallet dependency from mempool_updatefromblock.py 2 years ago
mining_basic.py test: use MiniWallet for mining_basic.py 3 years ago
mining_getblocktemplate_longpoll.py
mining_prioritisetransaction.py univalue: Return more detailed type check error messages 2 years ago
p2p_add_connections.py scripted-diff: Bump copyright headers 3 years ago
p2p_addr_relay.py Add tests for addr destination rotation 3 years ago
p2p_addrfetch.py
p2p_addrv2_relay.py
p2p_block_sync.py Add functional test for block sync from inbound peers 3 years ago
p2p_blockfilters.py test: add coverage for unknown -blockfilterindex 2 years ago
p2p_blocksonly.py refactor: Introduce PeerManagerImpl::RejectIncomingTxs 2 years ago
p2p_compactblocks.py test: check for `getblocktxn` request with out-of-bounds tx index 2 years ago
p2p_compactblocks_blocksonly.py [net processing] Only advertise support for version 2 compact blocks 3 years ago
p2p_compactblocks_hb.py
p2p_disconnect_ban.py test: set ban after mocking time 3 years ago
p2p_dns_seeds.py
p2p_dos_header_tree.py
p2p_eviction.py
p2p_feefilter.py
p2p_filter.py test: introduce `getnewdestination` helper for generating various address types 3 years ago
p2p_fingerprint.py
p2p_getaddr_caching.py test: Fix out-of-range port collisions 2 years ago
p2p_getdata.py
p2p_i2p_ports.py
p2p_ibd_txrelay.py Merge bitcoin/bitcoin#21327: net_processing: ignore transactions while in IBD 3 years ago
p2p_invalid_block.py Remove GetAdjustedTime from init.cpp 3 years ago
p2p_invalid_locator.py
p2p_invalid_messages.py
p2p_invalid_tx.py Merge bitcoin/bitcoin#19393: test: Add more tests for orphan tx handling 2 years ago
p2p_leak.py
p2p_leak_tx.py
p2p_message_capture.py test: Check msg type in msg capture is followed by zeros 3 years ago
p2p_nobloomfilter_messages.py
p2p_node_network_limited.py
p2p_permissions.py test: `-whitebind` and `-bind` with `-listen=0` should throw an error 2 years ago
p2p_ping.py
p2p_segwit.py scripted-diff: [test] Rename BIP125_SEQUENCE_NUMBER to MAX_BIP125_RBF_SEQUENCE 2 years ago
p2p_sendheaders.py
p2p_timeouts.py test: passing a non-positive integer value to `-peertimeout` should throw an error 2 years ago
p2p_tx_download.py
p2p_unrequested_blocks.py test: Fix intermittent race in p2p_unrequested_blocks.py 3 years ago
rpc_bind.py
rpc_blockchain.py univalue: Return more detailed type check error messages 2 years ago
rpc_createmultisig.py test: implement 'bech32m' mode for `getnewdestination()` helper 2 years ago
rpc_decodescript.py Replace "can not" with "cannot" in docs, user messages, and tests 3 years ago
rpc_deprecated.py
rpc_deriveaddresses.py
rpc_dumptxoutset.py rpc: check `fopen` return code in dumptxoutset 3 years ago
rpc_estimatefee.py
rpc_fundrawtransaction.py univalue: Return more detailed type check error messages 2 years ago
rpc_generate.py test: move-only: Move all generate* tests to a single file 3 years ago
rpc_getblockfilter.py
rpc_getblockfrompeer.py Merge bitcoin/bitcoin#24944: rpc: add getblockfrompeer RPCTypeCheck and invalid input test coverage 2 years ago
rpc_getblockstats.py rpc: Quote user supplied strings in error messages 3 years ago
rpc_getchaintips.py
rpc_getdescriptorinfo.py rpc: Quote user supplied descriptor in error msg 3 years ago
rpc_help.py univalue: Return more detailed type check error messages 2 years ago
rpc_invalid_address_message.py Report encoding type in bech32 error message 3 years ago
rpc_invalidateblock.py
rpc_mempool_info.py test: Remove unused call to generate in rpc_mempool_info 2 years ago
rpc_misc.py util/check: Add CHECK_NONFATAL identity function, NONFATAL_UNREACHABLE AND UNREACHABLE macros 3 years ago
rpc_named_arguments.py
rpc_net.py Sanitize port in `addpeeraddress()` 3 years ago
rpc_packages.py scripted-diff: [test] Rename BIP125_SEQUENCE_NUMBER to MAX_BIP125_RBF_SEQUENCE 2 years ago
rpc_preciousblock.py
rpc_psbt.py test: check that combining PSBTs with different txs fails 2 years ago
rpc_rawtransaction.py univalue: Return more detailed type check error messages 2 years ago
rpc_scantxoutset.py test: use MiniWallet for rpc_scantxoutset.py 3 years ago
rpc_setban.py
rpc_signer.py
rpc_signmessagewithprivkey.py
rpc_signrawtransactionwithkey.py test: refactor rpc_signrawtransaction.py 2 years ago
rpc_txoutproof.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 3 years ago
rpc_uptime.py Replace "can not" with "cannot" in docs, user messages, and tests 3 years ago
rpc_users.py Reject invalid rpcauth formats 3 years ago
rpc_whitelist.py
test-shell.md
test_runner.py test: functional test for new coin selection logic 2 years ago
tool_signet_miner.py test: add test for signet miner script 3 years ago
tool_wallet.py wallettool: Check that the dumpfile checksum is the correct size 3 years ago
wallet_abandonconflict.py test: add more wallet conflicts assertions 3 years ago
wallet_address_types.py test: remove unused if statements 2 years ago
wallet_avoid_mixing_output_types.py test: functional test for new coin selection logic 2 years ago
wallet_avoidreuse.py test: Test for disabling wallet flags 3 years ago
wallet_backup.py refactor: remove the wallet folder if the restore fails 3 years ago
wallet_balance.py rpc, wallet: Document and test mempool scan after importprivkey 2 years ago
wallet_basic.py univalue: Return more detailed type check error messages 2 years ago
wallet_bumpfee.py scripted-diff: [test] Rename BIP125_SEQUENCE_NUMBER to MAX_BIP125_RBF_SEQUENCE 2 years ago
wallet_coinbase_category.py test: speedup wallet_coinbase_category.py 2 years ago
wallet_create_tx.py
wallet_createwallet.py tests: Do not always create a descriptor wallet in wallet_createwallet 3 years ago
wallet_crosschain.py tests: add tests for cross-chain wallet use prevention 3 years ago
wallet_descriptor.py doc: Update importaddress mention incompatibility with descriptor wallet 2 years ago
wallet_disable.py test: move-only: Move all generate* tests to a single file 3 years ago
wallet_dump.py
wallet_encryption.py Replace "can not" with "cannot" in docs, user messages, and tests 3 years ago
wallet_fallbackfee.py
wallet_groups.py wallet: Strictly match tx change type to improve privacy 3 years ago
wallet_hd.py univalue: Return more detailed type check error messages 2 years ago
wallet_implicitsegwit.py
wallet_import_rescan.py test, wallet: Add mempool rescan test for import RPCs 2 years ago
wallet_import_with_label.py
wallet_importdescriptors.py Merge bitcoin/bitcoin#25351: rpc, wallet: Scan mempool after import* - Second attempt 2 years ago
wallet_importmulti.py rpc: Add missing BlockUntilSyncedToCurrentChain to wallet RPCs 3 years ago
wallet_importprunedfunds.py test: check for importprunedfunds RPC errors 3 years ago
wallet_inactive_hdchains.py tests: Tests for inactive HD chains 3 years ago
wallet_keypool.py Create a tr() descriptor bech32m DescriptorScriptPubKeyMan by default 3 years ago
wallet_keypool_topup.py
wallet_labels.py
wallet_listdescriptors.py Create a tr() descriptor bech32m DescriptorScriptPubKeyMan by default 3 years ago
wallet_listreceivedby.py test: add coverage for 'listreceivedbyaddress' no change addrs return 2 years ago
wallet_listsinceblock.py scripted-diff: [test] Rename BIP125_SEQUENCE_NUMBER to MAX_BIP125_RBF_SEQUENCE 2 years ago
wallet_listtransactions.py test: check for invalid listtransactions RPC parameters 3 years ago
wallet_miniscript.py qa: functional test Miniscript watchonly support 2 years ago
wallet_multisig_descriptor_psbt.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 3 years ago
wallet_multiwallet.py univalue: Return more detailed type check error messages 2 years ago
wallet_orphanedreward.py
wallet_reorgsrestore.py
wallet_resendwallettransactions.py scripted-diff: rename TxRelay members 3 years ago
wallet_send.py tests: Use descriptor that requires both legacy and segwit 3 years ago
wallet_sendall.py add tests for no recipient and using send_max while inputs are specified 3 years ago
wallet_signer.py Add sendall RPC née sweep 3 years ago
wallet_signmessagewithaddress.py
wallet_signrawtransactionwithwallet.py test: refactor rpc_signrawtransaction.py 2 years ago
wallet_startup.py
wallet_taproot.py test: Test signing psbts without explicitly having scripts 2 years ago
wallet_timelock.py Replace "can not" with "cannot" in docs, user messages, and tests 3 years ago
wallet_transactiontime_rescan.py test: fix test wallet_transactiontime_rescan.py for descriptor wallets 3 years ago
wallet_txn_clone.py
wallet_txn_doublespend.py
wallet_upgradewallet.py tests: Test upgrading wallet with privkeys disabled 3 years ago
wallet_watchonly.py

README.md

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: