You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
bitcoin/test/functional
Sjors Provoost 709f8685ac
[wallet] CreateTransaction: simplify change address check
5 years ago
..
data scripted-diff: Bump copyright of files changed in 2019 5 years ago
test_framework Merge #16115: On bitcoind startup, write config args to debug.log 5 years ago
.gitignore
README.md Add documentation for test_shell submodule 5 years ago
combine_logs.py scripted-diff: Add missed copyright headers 5 years ago
combined_log_template.html
create_cache.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
example_test.py [qa] Fix race condition in example_test.py 5 years ago
feature_abortnode.py bump test timeouts so that functional tests run in valgrind 5 years ago
feature_assumevalid.py test: Bump timeouts in slow running tests 5 years ago
feature_bip68_sequence.py Merge #17004: validation: Remove REJECT code from CValidationState 5 years ago
feature_block.py bump test timeouts so that functional tests run in valgrind 5 years ago
feature_blocksdir.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
feature_cltv.py scripted-diff: [validation] Rename CheckInputs to CheckInputScripts 5 years ago
feature_config_args.py on startup, write config options to debug.log 5 years ago
feature_csv_activation.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
feature_dbcrash.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
feature_dersig.py scripted-diff: [validation] Rename CheckInputs to CheckInputScripts 5 years ago
feature_fee_estimation.py test: Explain why -whitelist is used in feature_fee_estimation 5 years ago
feature_filelock.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
feature_help.py bump test timeouts so that functional tests run in valgrind 5 years ago
feature_includeconf.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
feature_loadblock.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
feature_logging.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
feature_maxuploadtarget.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
feature_minchainwork.py
feature_notifications.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 5 years ago
feature_nulldummy.py [logging] Don't log REJECT code when transaction is rejected 5 years ago
feature_proxy.py scripted-diff: Update copyright in ./test 6 years ago
feature_pruning.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
feature_rbf.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
feature_reindex.py
feature_segwit.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 5 years ago
feature_shutdown.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
feature_uacomment.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
feature_versionbits_warning.py scripted-diff: Update copyright in ./test 6 years ago
interface_bitcoin_cli.py Merge #17650: util: remove unwanted fields from bitcoin-cli -getinfo 5 years ago
interface_http.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
interface_rest.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
interface_rpc.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
interface_zmq.py zmq: Fix due to invalid argument and multiple notifiers 5 years ago
mempool_accept.py Merge #17541: test: add functional test for non-standard bare multisig txs 5 years ago
mempool_limit.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
mempool_package_onemore.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 5 years ago
mempool_packages.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 5 years ago
mempool_persist.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
mempool_reorg.py bump test timeouts so that functional tests run in valgrind 5 years ago
mempool_resurrect.py scripted-diff: Update copyright in ./test 6 years ago
mempool_spend_coinbase.py
mining_basic.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
mining_getblocktemplate_longpoll.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
mining_prioritisetransaction.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
p2p_blocksonly.py Disconnect peers violating blocks-only mode 5 years ago
p2p_compactblocks.py [Consensus] Bury segwit deployment 5 years ago
p2p_disconnect_ban.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
p2p_dos_header_tree.py [logging] Don't log REJECT code when transaction is rejected 5 years ago
p2p_feefilter.py modify p2p_feefilter test to catch rounding error 5 years ago
p2p_fingerprint.py
p2p_invalid_block.py New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137. 6 years ago
p2p_invalid_locator.py
p2p_invalid_messages.py Merge #17770: test: bump test timeouts so that functional tests run in valgrind 5 years ago
p2p_invalid_tx.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
p2p_leak.py scripted-diff: Update copyright in ./test 6 years ago
p2p_leak_tx.py
p2p_mempool.py
p2p_node_network_limited.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 5 years ago
p2p_permissions.py test: Add p2p test for forcerelay permission 5 years ago
p2p_segwit.py test: Make msg_tx a witness tx 5 years ago
p2p_sendheaders.py test: Remove unused imports 6 years ago
p2p_timeouts.py
p2p_tx_download.py test: Use connect_nodes when connecting nodes in the test_framework 5 years ago
p2p_unrequested_blocks.py test: Remove unused imports 6 years ago
rpc_bind.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
rpc_blockchain.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
rpc_createmultisig.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
rpc_decodescript.py scripted-diff: Update copyright in ./test 6 years ago
rpc_deprecated.py scripted-diff: Update copyright in ./test 6 years ago
rpc_deriveaddresses.py tests: Use a default of supports_cli=True (instead of supports_cli=False) 5 years ago
rpc_dumptxoutset.py test: add dumptxoutset RPC test 5 years ago
rpc_fundrawtransaction.py [wallet] CreateTransaction: simplify change address check 5 years ago
rpc_getaddressinfo_label_deprecation.py test: getaddressinfo label deprecation test 5 years ago
rpc_getaddressinfo_labels_purpose_deprecation.py Merge #17585: rpc: deprecate getaddressinfo label 5 years ago
rpc_getblockfilter.py rpc: Add getblockfilter RPC method. 6 years ago
rpc_getblockstats.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
rpc_getchaintips.py test: Remove unused imports 6 years ago
rpc_help.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
rpc_invalidateblock.py rpc: Add generatetodescriptor 5 years ago
rpc_misc.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
rpc_named_arguments.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
rpc_net.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
rpc_preciousblock.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
rpc_psbt.py psbt: check output index is within bounds before accessing 5 years ago
rpc_rawtransaction.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
rpc_scantxoutset.py rpc: require second argument only for scantxoutset start action 5 years ago
rpc_setban.py bump test timeouts so that functional tests run in valgrind 5 years ago
rpc_signmessage.py scripted-diff: Update copyright in ./test 6 years ago
rpc_signrawtransaction.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 5 years ago
rpc_txoutproof.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
rpc_uptime.py scripted-diff: Update copyright in ./test 6 years ago
rpc_users.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
rpc_whitelist.py test: Change filemode of rpc_whitelist.py 5 years ago
test-shell.md TestShell: Return self from setup() 5 years ago
test_runner.py test: getaddressinfo label deprecation test 5 years ago
tool_wallet.py test: skip tool_wallet test when bitcoin-wallet isn't compiled 5 years ago
wallet_abandonconflict.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 5 years ago
wallet_address_types.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
wallet_avoidreuse.py Merge #17843: wallet: Reset reused transactions cache 5 years ago
wallet_backup.py test: speedup wallet_backup by whitelisting peers (immediate tx relay) 5 years ago
wallet_balance.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 5 years ago
wallet_basic.py test: remove getaddressinfo label tests 5 years ago
wallet_bumpfee.py Test watchonly wallet bumpfee with PSBT return 5 years ago
wallet_bumpfee_totalfee_deprecation.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 5 years ago
wallet_coinbase_category.py
wallet_create_tx.py test: Add test for maxtxfee option 5 years ago
wallet_createwallet.py tests: Use a default of supports_cli=True (instead of supports_cli=False) 5 years ago
wallet_disable.py scripted-diff: Update copyright in ./test 6 years ago
wallet_dump.py bump test timeouts so that functional tests run in valgrind 5 years ago
wallet_encryption.py scripted-diff: Bump copyright of files changed in 2019 5 years ago
wallet_fallbackfee.py
wallet_groups.py Merge #17770: test: bump test timeouts so that functional tests run in valgrind 5 years ago
wallet_hd.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
wallet_implicitsegwit.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
wallet_import_rescan.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
wallet_import_with_label.py Merge #17585: rpc: deprecate getaddressinfo label 5 years ago
wallet_importmulti.py test: remove getaddressinfo label tests 5 years ago
wallet_importprunedfunds.py
wallet_keypool.py scripted-diff: Update copyright in ./test 6 years ago
wallet_keypool_topup.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 5 years ago
wallet_labels.py Merge #17585: rpc: deprecate getaddressinfo label 5 years ago
wallet_listreceivedby.py test: remove getaddressinfo label tests 5 years ago
wallet_listsinceblock.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 5 years ago
wallet_listtransactions.py rpc: Expose block height of wallet transactions 5 years ago
wallet_multiwallet.py tests: Use a default of supports_cli=True (instead of supports_cli=False) 5 years ago
wallet_reorgsrestore.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 5 years ago
wallet_resendwallettransactions.py rpc: Clarify that block count means height excl genesis 5 years ago
wallet_txn_clone.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
wallet_txn_doublespend.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 5 years ago
wallet_watchonly.py tests: Use a default of supports_cli=True (instead of supports_cli=False) 5 years ago
wallet_zapwallettxes.py

README.md

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The Travis linter also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramwork, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use '{}'.format(x) for string formatting, not '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel or on Travis).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x50=1250 BTC) in its wallet.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • messages.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

  • Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

mininode.py

Basic code to support P2P connectivity to a bitcoind.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

bignum.py

Helpers for script.py

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2p.send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: